[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2007-09-20 02:06 EST --- Closing this review as package already got built successfully on koji. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-09-07 02:21 EST --- New Package CVS Request === Package Name: nabi Short Description: Hangul X Input Method Owners: sbehera Branches: F-7 InitialCC: petersen Cvsextras Commits: Yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-09-07 14:37 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-09-05 03:12 EST --- Here is the source diff output for the record: $ diff -ur nabi-0.18 nabi-0.18_fedora Only in nabi-0.18/themes: MSWindows Only in nabi-0.18/themes: MSWindowsXP Only in nabi-0.18/themes: Mac All issues have been addressed and the package looks good to me. Thanks Subhransu for your patience and work on this. I am happy to approve the package. :) BTW note if you want to build the package for F7 then it will have to be with the older release since f7 libhangul is still 0.0.4 which is not new enough to build the latest nabi. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-09-05 03:42 EST --- It would help if you could do one so-called package pre-review and I am happy to sponsor you for cvsextras. :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-09-04 02:39 EST --- Package updated with version: 0.18-7 Spec URL: http://oriya.sourceforge.net/0.18-7/nabi.spec SRPM URL: http://oriya.sourceforge.net/0.18-7/nabi-0.18-7.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-09-03 20:21 EST --- Since it is taking a bit longer for the upstream release than expected let's go ahead with just removing the questionable themes from the tarball as per http://fedoraproject.org/wiki/Packaging/SourceURL#head-b46af5567f2338faafa13aff9855caa3c91f2c8c. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-24 05:51 EST --- Well, what is the status of this bug? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-24 06:04 EST --- Hi Mamoru San, We're waiting for upstream to remove the unappropriate images till the end of the this month. Or else, we can go ahead as per as the suggestion of Jens. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-24 06:41 EST --- Okay, thank you for imformation. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-16 20:42 EST --- I suggest preparing a new tarball with the unappropriate images removed. Upstream has agreed to remove them in the next release. The new tarball should have a distinct name from the upstream one: say something like nabi-0.18_fedora.tar.gz. Probably need to patch some of the makefiles too for the removed themes. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-16 21:03 EST --- Created an attachment (id=161708) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=161708action=view) nabi-remove-bad-themes A small shellscript does the theme removal. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-10 02:24 EST --- Package Updated. Spec URL: http://oriya.sourceforge.net/0.18-6/nabi.spec SRPM URL: http://oriya.sourceforge.net/0.18-6/nabi-0.18-6.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-09 19:47 EST --- I contacted upstream about the questionable themes which we are excluding from the package. I hope they can be removed in a future release. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-08 02:41 EST --- Package Updated. Spec URL: http://oriya.sourceforge.net/0.18-5/nabi.spec SRPM URL: http://oriya.sourceforge.net/0.18-5/nabi-0.18-5.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-08 12:19 EST --- Seems okay to me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-08 23:59 EST --- Here is my review: Good: + rpmlint clean + package follows naming and packaging guidelines + specifies GPL version and includes COPYING + spec file is legible + source is pristine 0d0fba8851a1ac367d7b52840e6bef3e nabi-0.18.tar.gz + builds in mock and runs correctly + buildreqs listed + uses %find_lang + file and dir ownership looks correct + consistent macro usage + does not contain devel files + scriplets reasonable Need attention: - actually thinking more, I realised that the desktop is not needed since we don't normally run input methods from the desktop menu - they should be configured with im-chooser instead. - minor, but I think ChangeLog can be dropped from %doc Apart from that all MUST items from ReviewGuidelines are satisfied. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-09 00:03 EST --- Created an attachment (id=160954) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160954action=view) nabi.spec-6.patch this patch fixes the above: - remove unnecessary desktop file - tidy doc filelist -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-07 03:17 EST --- Package Updated. Spec URL: http://oriya.sourceforge.net/0.18-4/nabi.spec SRPM URL: http://oriya.sourceforge.net/0.18-4/nabi-0.18-4.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-07 07:52 EST --- * rpmlint - rpmlint complains about: --- W: nabi invalid-license GPL W: nabi rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT --- - License tag policy is updated so please change license tag accordingly. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines http://fedoraproject.org/wiki/Licensing As far as I checked the source code, this is GPLv2+. - rm -rf $RPM_BUILD_ROOT is not needed for %prep -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-07 07:52 EST --- Other things seems okay for me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-07 22:04 EST --- Thanks, Tasaka-san, for your careful checking: seems the new version of rpmlint is more strict. Ok, Subhransu, if you can do one more update I'd like to move into the final formal next. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-06 02:13 EST --- So actually it should be the nabi config file listed there not the directory. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-06 03:57 EST --- Upgraded with required fixes. Spec URL: http://oriya.sourceforge.net/0.18-3/nabi.spec SRPM URL: http://oriya.sourceforge.net/0.18-3/nabi-0.18-3.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-06 20:24 EST --- (In reply to comment #15) Which package should own %_sysconfdir/X11/xinit/xinput.d ? I think it should be owned by im-chooser now. BTW Tagoh already kindly fixed this in bug 250960. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-06 22:52 EST --- Created an attachment (id=160792) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160792action=view) nabi.spec-5.patch This should hopefully address the rest of the points raised by Tasaka-san. Please check them and update package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-08-06 01:58 EST --- (In reply to comment #14) Which package should own %_sysconfdir/X11/xinit/xinput.d ? I think it should be owned by im-chooser now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-07-30 03:18 EST --- Created an attachment (id=160216) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160216action=view) nabi.spec-4.patch some more fixes - please check I didn't break anything. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-07-30 03:19 EST --- Created an attachment (id=160217) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160217action=view) nabi.desktop -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: nabi - hangul and hanja X input method
Alias: nabi
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227
--- Additional Comments From [EMAIL PROTECTED] 2007-07-30 10:06 EST ---
(In reply to comment #11)
Upgraded to 0.18 release.
Spec URL: http://oriya.sourceforge.net/nabi.spec
(In reply to comment #12)
Created an attachment (id=160216)
--
(https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160216action=view)
[edit]
nabi.spec-4.patch
some more fixes - please check I didn't break anything. :)
(I only glanced at both spec files)
More cleanup:
* Please use full path for the commands which are not under
normal users' paths.
* The following is smarter
---
desktop-file-install --dir=${RPM_BUILD_ROOT}%{_datadir}/applications/ \
%SOURCE1
---
! Note: desktop-file-install automatically fix the following,
however Categories must be seperated by semicolon: i.e.
---
Categories=System;
---
* What is the use of the line:
---
%attr(755,root,root)
---
? Question
Which package should own %_sysconfdir/X11/xinit/xinput.d ?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]| |) | --- Additional Comments From [EMAIL PROTECTED] 2007-07-24 03:15 EST --- I am waiting for newer version of libhangul (0.18) to be built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-07-24 03:17 EST --- Right probably nabi-0.18 requires libhangul-0.0.6 and the current version in fedora in 0.0.4. I asked the owner to update it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-07-23 08:52 EST --- By the way are there any information when upstream will release new version? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 --- Additional Comments From [EMAIL PROTECTED] 2007-07-23 19:32 EST --- It was already released on the 8th, see: http://kldp.net/frs/?group_id=275 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: Nabi - |Review Request: nabi - |hangul and hanja X input|hangul and hanja X input |method |method --- Additional Comments From [EMAIL PROTECTED] 2007-07-20 04:09 EST --- Ok, please update with the new .spec file and srpm url when it is ready. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: Nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added Alias||nabi -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: Nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Nabi - hangul and hanja X input method https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]| |) | --- Additional Comments From [EMAIL PROTECTED] 2007-07-12 05:38 EST --- Hi Mamoru, Thanks for pointing out the probable mistakes. As nabi-0.18 is released by upstream I am planning to build the srpm for the same. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: Nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Nabi - hangul and hanja X input method https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO Flag||needinfo?([EMAIL PROTECTED] ||) --- Additional Comments From [EMAIL PROTECTED] 2007-07-12 01:27 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: Nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Nabi - hangul and hanja X input method
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227
--- Additional Comments From [EMAIL PROTECTED] 2007-07-06 07:21 EST ---
Well, you may want to check the spec files of other packages.
For example, there is scim spec:
http://cvs.fedoraproject.org/viewcvs/*checkout*/rpms/scim/devel/scim.spec
Please check the packaging guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
* SourceURL must be given with full URL.
* Don't rebuild in mock. At least, libhangul-devel is missing for
BuildRequires
* Fedora specific compilation flags are not honored. Perhaps
this can be resolved by using %configure macro.
* Please support parallel make when possible.
* install-strip is forbidden. This disables to create debuginfo
rpm.
* Please keep timestamps. When using install command, use it
with '-p' option.
* Use macros (e.g. /usr/share - %{_datadir})
* Categories 'Application' 'X-Red-Hat-Base' are deprecated and
should be removed
* desktop file must be installed by using desktop-file-install
(BR: desktop-file-utils is needed)
* The binaries which are not under normal users' paths must be
specified with full path.
* gettext .mo files must be registered in %files entry by using
%find_lang macro.
* files under %_sysconfdir should be marked as %config(noreplace)
* We recommend %defattr(-,root,root,-)
* Please remove unused macros.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247227] Review Request: Nabi - hangul and hanja X input method
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Nabi - hangul and hanja X input method
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227
--- Additional Comments From [EMAIL PROTECTED] 2007-07-06 07:34 EST ---
And:
* %{_sbindir}/alternatives must be added to Requires()
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
