[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libflaim - Flaim Database Engine
https://bugzilla.redhat.com/show_bug.cgi?id=251020
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution||NEXTRELEASE
--- Additional Comments From [EMAIL PROTECTED] 2007-09-09 07:00 EST ---
(In reply to comment #13)
libflaim.pc contains the line:
Libs: -lpthread -lrt -lstdc++ -ldl -lncurses -lflaim -L${libdir}
-lncurses means that libflaim-devel should have Requires: ncurses-devel.
But make check if -lncurses is really needed. For libflaim.so
the linkage against libncurses.so MUST be done in advance and
-lncurses is usually not needed.
Thanks for the additional info Mamoru. I'll add this on the next build. Buildsys
seems to be having problems at the moment. :(
Closing now as per package process - thanks everyone.
Regards
Chris
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libflaim - Flaim Database Engine
https://bugzilla.redhat.com/show_bug.cgi?id=251020
--- Additional Comments From [EMAIL PROTECTED] 2007-09-08 12:26 EST ---
libflaim.pc contains the line:
Libs: -lpthread -lrt -lstdc++ -ldl -lncurses -lflaim -L${libdir}
-lncurses means that libflaim-devel should have Requires: ncurses-devel.
But make check if -lncurses is really needed. For libflaim.so
the linkage against libncurses.so MUST be done in advance and
-lncurses is usually not needed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libflaim - Flaim Database Engine https://bugzilla.redhat.com/show_bug.cgi?id=251020 --- Additional Comments From [EMAIL PROTECTED] 2007-09-07 04:56 EST --- (In reply to comment #8) - todo before import: * add a libflaim prefix to the patch, i.e. rename it to: libflaim-permissions.patch Okay, done. * fix license tag Okay, done. Cheers Chris -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libflaim - Flaim Database Engine https://bugzilla.redhat.com/show_bug.cgi?id=251020 --- Additional Comments From [EMAIL PROTECTED] 2007-09-07 05:10 EST --- Package is APPROVED, you need to follow: http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess (step 8) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libflaim - Flaim Database Engine https://bugzilla.redhat.com/show_bug.cgi?id=251020 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-09-07 05:25 EST --- New Package CVS Request === Package Name: libflaim Short Description: Flaim Database Engine Owners: snecker Branches: F-7 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libflaim - Flaim Database Engine https://bugzilla.redhat.com/show_bug.cgi?id=251020 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-09-07 14:33 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libflaim - Flaim Database Engine
https://bugzilla.redhat.com/show_bug.cgi?id=251020
--- Additional Comments From [EMAIL PROTECTED] 2007-09-06 10:55 EST ---
Hi Till,
Thanks for assigning yourself to this.
(In reply to comment #3)
The release should be an integer, imho it is in the Naming Guidelines
(http://fedoraproject.org/wiki/Packaging/NamingGuidelines)
So change
Release: 9.2%{?dist}
to
Release: 10%{?dist}
You can later use
Release: 10%{?dist}.1
If you need to increment only in one Fedora Collection that is not Rawhide.
Source0 is not valid (anymore):
$ curl -I
http://forgeftp.novell.com/flaim/development/flaim/downloads/source/libflaim-4.9.1046.tar.gz
HTTP/1.1 404 Not Found
According to the URL in the spec file the latest tarball is:
libflaim-4.9.989.tar.gz
Is this older version intentional?
The version being built is newer, essentially a subversion checkout therefore I
have made the necessary changes to reflect this.
The buildroot is not ok, see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
You should use %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
or
some other example from the wiki.
Okay, done.
Please use rm -rf %{buildroot} instead of rm -Rf %{buildroot}
Okay, done.
Did you build your packages with mock? When I build it and run rpmlint on the
rpms, I get:
$ rpmlint libflaim-*
W: libflaim unstripped-binary-or-object /usr/lib/libflaim.so.5.2
E: libflaim-debuginfo empty-debuginfo-package
W: libflaim-devel no-documentation
The third warning can be ignored. The build.log shows:
ldconfig /var/tmp/libflaim-4.9.1046-build/usr/lib
Installation complete.
+ /usr/lib/rpm/find-debuginfo.sh /builddir/build/BUILD/libflaim-4.9.1046
0 blocks
find: /var/tmp/libflaim-4.9.1046-build/usr/lib/debug: No such file or
directory
But I do not know, why.
This was because the shared object was not installed executable - I have
attached a small patch to resolve this and should hopefully get this upstream
quickly.
Updated RPMS as usual at:
http://snecker.fedorapeople.org/libflaim/
Regards
Chris
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libflaim - Flaim Database Engine https://bugzilla.redhat.com/show_bug.cgi?id=251020 --- Additional Comments From [EMAIL PROTECTED] 2007-09-06 11:31 EST --- (In reply to comment #5) http://forgeftp.novell.com/flaim/development/flaim/downloads/source/libflaim-4.9.1046.tar.gz HTTP/1.1 404 Not Found According to the URL in the spec file the latest tarball is: libflaim-4.9.989.tar.gz Is this older version intentional? The version being built is newer, essentially a subversion checkout therefore I have made the necessary changes to reflect this. This still needs some work. I do not understand where the 1046 comes from in the Version tag. Is this the svn revision? Did you built the svn snapshot yourself? In this case, you need to add instructions to the spec how to rebuild the snapshot, see: http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49 The URL in Source0 does not work here: $ curl --insecure -I https://forgesvn1.novell.com/svn/flaim/libflaim-4.9.1046.tar.gz HTTP/1.1 404 Not Found [...] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libflaim - Flaim Database Engine https://bugzilla.redhat.com/show_bug.cgi?id=251020 --- Additional Comments From [EMAIL PROTECTED] 2007-09-06 16:30 EST --- (In reply to comment #6) This still needs some work. I do not understand where the 1046 comes from in the Version tag. Is this the svn revision? It was, kinda, sorta. I had used the some RPMS from a SUSE developers repo as a starting point and that tarball was included as source. I can't figure out how it was generated as pulling from svn also brings down a number of other header files and such which cause the build to fail. Therefore I've downgraded the spec a little to an official release which builds fine using the patch. The patch was accepted upstream today btw. I have uploaded new builds. Rpmlint is quiet on these now. Cheers Chris -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libflaim - Flaim Database Engine https://bugzilla.redhat.com/show_bug.cgi?id=251020 --- Additional Comments From [EMAIL PROTECTED] 2007-09-05 16:51 EST --- I just realized that the broken debuginfo affects your rpm packages, too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libflaim - Flaim Database Engine
https://bugzilla.redhat.com/show_bug.cgi?id=251020
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-09-05 16:49 EST ---
The release should be an integer, imho it is in the Naming Guidelines
(http://fedoraproject.org/wiki/Packaging/NamingGuidelines)
So change
Release:9.2%{?dist}
to
Release:10%{?dist}
You can later use
Release:10%{?dist}.1
If you need to increment only in one Fedora Collection that is not Rawhide.
Source0 is not valid (anymore):
$ curl -I
http://forgeftp.novell.com/flaim/development/flaim/downloads/source/libflaim-4.9.1046.tar.gz
HTTP/1.1 404 Not Found
According to the URL in the spec file the latest tarball is:
libflaim-4.9.989.tar.gz
Is this older version intentional?
The buildroot is not ok, see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
You should use %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX) or
some other example from the wiki.
Please use rm -rf %{buildroot} instead of rm -Rf %{buildroot}
Did you build your packages with mock? When I build it and run rpmlint on the
rpms, I get:
$ rpmlint libflaim-*
W: libflaim unstripped-binary-or-object /usr/lib/libflaim.so.5.2
E: libflaim-debuginfo empty-debuginfo-package
W: libflaim-devel no-documentation
The third warning can be ignored. The build.log shows:
ldconfig /var/tmp/libflaim-4.9.1046-build/usr/lib
Installation complete.
+ /usr/lib/rpm/find-debuginfo.sh /builddir/build/BUILD/libflaim-4.9.1046
0 blocks
find: /var/tmp/libflaim-4.9.1046-build/usr/lib/debug: No such file or directory
But I do not know, why.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libflaim - Flaim Database Engine
https://bugzilla.redhat.com/show_bug.cgi?id=251020
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-08-30 09:50 EST ---
- static libraries should be in a -static package or not packaged at all:
%{_libdir}/libflaim.a - see:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7
- - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
- Add Reuires: pkgconfig to %package devel
- you should use $RPM_OPT_FLAGS instead of %optflags:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 251020] Review Request: libflaim - Flaim Database Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libflaim - Flaim Database Engine
https://bugzilla.redhat.com/show_bug.cgi?id=251020
--- Additional Comments From [EMAIL PROTECTED] 2007-08-30 10:51 EST ---
(In reply to comment #1)
Thanks for the review Till.
- static libraries should be in a -static package or not packaged at all:
%{_libdir}/libflaim.a - see:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7
Done.
- - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
- Add Reuires: pkgconfig to %package devel
Done.
- you should use $RPM_OPT_FLAGS instead of %optflags:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf
Done.
Updated pkgs at:
http://snecker.fedorapeople.org/libflaim/
I am still working on iFolder and simias which are the other two packages that
form the reqs necessary to get iFolder working on Fedora.
Regards
Chris
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
