[Bug 255381] Review Request: openmsx - An emulator for the MSX home computer system

2007-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openmsx - An emulator for the MSX home computer system


https://bugzilla.redhat.com/show_bug.cgi?id=255381


Bug 255381 depends on bug 255361, which changed state.

Bug 255361 Summary: Review Request: cbios - A third party BIOS compatible with 
the MSX BIOS
https://bugzilla.redhat.com/show_bug.cgi?id=255361

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 255381] Review Request: openmsx - An emulator for the MSX home computer system

2007-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openmsx - An emulator for the MSX home computer system


https://bugzilla.redhat.com/show_bug.cgi?id=255381


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 255381] Review Request: openmsx - An emulator for the MSX home computer system

2007-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openmsx - An emulator for the MSX home computer system


https://bugzilla.redhat.com/show_bug.cgi?id=255381


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-08-28 03:21 EST ---
Looks perfect now, approved!


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 255381] Review Request: openmsx - An emulator for the MSX home computer system

2007-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openmsx - An emulator for the MSX home computer system


https://bugzilla.redhat.com/show_bug.cgi?id=255381


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-08-28 14:05 EST ---
Thanks for the review!


New Package CVS Request
===
Package Name: openmsx
Short Description: An emulator for the MSX home computer system
Owners: oddsocks
Branches: FC-6 F-7
InitialCC: 
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 255381] Review Request: openmsx - An emulator for the MSX home computer system

2007-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openmsx - An emulator for the MSX home computer system


https://bugzilla.redhat.com/show_bug.cgi?id=255381


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 255381] Review Request: openmsx - An emulator for the MSX home computer system

2007-08-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openmsx - An emulator for the MSX home computer system


https://bugzilla.redhat.com/show_bug.cgi?id=255381


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2007-08-27 14:12 EST ---
I've done a full review, there is one must fix and one should fix.

Must FIX

* I couldn't find a specification of the license version anywhere, so the 
license
  tag should be GPL+ not GPLv2.

Should FIX
==
* please use the preferred form of the sourceforge download URL for Source0:
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 255381] Review Request: openmsx - An emulator for the MSX home computer system

2007-08-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openmsx - An emulator for the MSX home computer system


https://bugzilla.redhat.com/show_bug.cgi?id=255381





--- Additional Comments From [EMAIL PROTECTED]  2007-08-27 17:06 EST ---
This should fix those issues:

Spec URL: http://dribble.org.uk/reviews/openmsx.spec
SRPM URL: http://dribble.org.uk/reviews/openmsx-0.6.2-4.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 255381] Review Request: openmsx - An emulator for the MSX home computer system

2007-08-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openmsx - An emulator for the MSX home computer system


https://bugzilla.redhat.com/show_bug.cgi?id=255381


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||255361




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review