[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-03-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-03-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951





--- Additional Comments From [EMAIL PROTECTED]  2008-03-19 10:14 EST ---
Chris, please close this bug as log4net is already built.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-02-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951





--- Additional Comments From [EMAIL PROTECTED]  2008-02-24 16:30 EST ---
(In reply to comment #4)
 Because of the ExcludeArch you should also create a bug to track this issue 
 and
 make it block FE-ExcludeArch-ppc64=238953, see e.g. #309191.

https://bugzilla.redhat.com/show_bug.cgi?id=434700

Nant is not yet in rawhide so I am unable to build this in rawhide yet:

https://bugzilla.redhat.com/show_bug.cgi?id=434711

Will close once I am able.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-02-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951





--- Additional Comments From [EMAIL PROTECTED]  2008-02-24 17:26 EST ---
nant existed in devel for i386 and x86_64, but few minutes after you tried to
build log4net in devel nant was updated and built also for ppc :-)

Also increase the revision for devel to 3 as you have done for F-8 and F-7 to
keep the upgrade path working.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-02-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-22 13:01 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-02-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-21 04:23 EST ---
Don't forget to increase %Release tag (and also update changelog entry) for each
spec file public update. This iteration should be 1.2.10-2.

Formal review is here:
OK  source files match upstream:
4f8ff9892665469f915855692c9fc02801038837  
incubating-log4net-1.2.10.zip
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros 
consistently.
OK  dist tag is present.
OK  build root is correct.
OK  license field matches the actual license.
OK  license is open source-compatible (ASL 2.0). License text included in 
package.
OK  latest version is being packaged.
OK  BuildRequires are proper.
N/A compiler flags are appropriate (Mono app).
OK  %clean is present.
OK  package builds in mock (x86_64 Rawhide).
N/A debuginfo package looks complete (no debuginfo - Mono app).
OK  rpmlint is silent.

log4net.x86_64: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

OK for Mono app

log4net.x86_64: E: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

OK for Mono app

OK  final provides and requires look sane.
OK  no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  no scriptlets present.
OK  code, not content.
OK  documentation is small, so no -docs subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  has pkgconfig files in -devel subpackage.
OK  no libtool .la droppings.
OK  not a GUI app.

This package is APPROVED with the release updated to 2 (see above).

Because of the ExcludeArch you should also create a bug to track this issue and
make it block FE-ExcludeArch-ppc64=238953, see e.g. #309191.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-02-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-02-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951





--- Additional Comments From [EMAIL PROTECTED]  2008-02-21 15:56 EST ---
(In reply to comment #4)
 Don't forget to increase %Release tag (and also update changelog entry) for 
 each
 spec file public update. This iteration should be 1.2.10-2.

Gah, well spotted.

 This package is APPROVED with the release updated to 2 (see above).

Many thanks for the review Dan, greatly appreciated.

 Because of the ExcludeArch you should also create a bug to track this issue 
 and
 make it block FE-ExcludeArch-ppc64=238953, see e.g. #309191.

Will do, as soon as it gets imported and appears in the bz list.

Thanks again,
Chris

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-02-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
   Flag|fedora-cvs? |




--- Additional Comments From [EMAIL PROTECTED]  2008-02-21 16:05 EST ---
Please use a new package template from 
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
so we know what branches you want, what owners, etc. 

please reset the fedora-cvs flag when you are ready. 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-02-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-21 16:35 EST ---
New Package CVS Request
===
Package Name: log4net
Short Description: Logging for the .Net Framework
Owners: snecker
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2008-02-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951





--- Additional Comments From [EMAIL PROTECTED]  2008-02-20 03:38 EST ---
some notes
- the log4net.pc file should be installed into %{_libdir}/pkgconfig (other .NET
devel packages are installing the *.pc files there)
- the %{_libdir}/mono/gac directory is owned by mono-core, so you should package
only the %{_libdir}/mono/gac/log4net subdirectory
- you must also set ExcludeArch: ppc64 as Mono doesn't exist there


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2007-09-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2007-09-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review+  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 283951] Review Request: log4net - A .NET framework for logging

2007-09-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-09-09 07:12 EST ---
*** Bug 187828 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review