[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741





--- Additional Comments From [EMAIL PROTECTED]  2008-02-25 04:23 EST ---
1. Please update the Fedora comps file
(Cf grouping section of http://fedoraproject.org/wiki/Packaging/FontsPolicy)

2. Please add this package to the "Packaged fonts" list at
http://fedoraproject.org/wiki/SIGs/Fonts/Triaging/Pipeline

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-23 09:51 EST ---
Build now. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-22 03:50 EST ---
is this built?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-18 15:16 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741





--- Additional Comments From [EMAIL PROTECTED]  2008-02-18 12:47 EST ---

Yes. Sorry I missed that. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-18 12:33 EST ---
Is there no Short Description here? Should it be "Free Sarai Hindi Truetype 
Font" ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-18 05:26 EST ---

Thanks for the review. 

New Package CVS Request
===
Package Name: sarai-fonts
Short Description: 
Owners: sundaram,pnemade
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-17 14:35 EST ---
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
b5f792b2fb76b7448c96f6a8f77b1390  Sarai_07.ttf
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ font is open source-compatible.
+ License text is included in package.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ fonts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI App.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741





--- Additional Comments From [EMAIL PROTECTED]  2008-02-15 18:30 EST ---
 

New revision

http://sundaram.fedorapeople.org/packages/sarai-fonts.spec
http://sundaram.fedorapeople.org/packages/sarai-fonts-1.0-3.fc8.src.rpm

Fixed the two issues pointed out. Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741





--- Additional Comments From [EMAIL PROTECTED]  2008-02-15 04:05 EST ---
Output of rpmlint:
"sarai-fonts.noarch: E: description-line-too-long This package provides a free
Sarai Hindi TrueType font. It is meant for print and publishing needs."

There should be a line break every 80 characters.
The URL given for Source0 is not a direct link to the font file. It gives
another webpage. I would suggest to keep the earlier source, i.e. just
"Sarai_07.ttf".



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741





--- Additional Comments From [EMAIL PROTECTED]  2008-02-15 00:05 EST ---
New revision:

http://sundaram.fedorapeople.org/packages/sarai-fonts.spec
http://sundaram.fedorapeople.org/packages/sarai-fonts-1.0-2.fc8.src.rpm


Fixed URL
Used macro as suggested
Added License

I checked the policies and didn't see one enforcing a particular style of
buildroot. The packaging guidelines suggests the package maintainer pick one and
stick to it which is what I am doing now. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741





--- Additional Comments From [EMAIL PROTECTED]  2008-02-14 07:39 EST ---
Output of rpmlint:
$ rpmlint sarai-fonts-1.0-1.fc8.noarch.rpm 
sarai-fonts.noarch: W: no-documentation

The above may be ignored, but it is recommended to include a license text file
as a part of documentation.

You may use %{fontname} in following line:
  4 Name:sarai-fonts

I think URL should be the one from sarai.net. 
http://www.sarai.net/practices/indic-localization/downloads-1/Sarai_07.ttf

According to new policies, please replace $RPM_BUILD_ROOT with %{buildroot}.
Rest all looks fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 432741] Review Request: sarai-fonts - Free Sarai Hindi Truetype Font

2008-02-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sarai-fonts - Free Sarai Hindi Truetype Font


https://bugzilla.redhat.com/show_bug.cgi?id=432741


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review