[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 --- Comment #25 from Fedora Update System [EMAIL PROTECTED] 2008-11-05 23:03:26 EDT --- mirrormanager-1.2.6-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 Fedora Update System [EMAIL PROTECTED] changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 Fedora Update System [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #24 from Fedora Update System [EMAIL PROTECTED] 2008-10-20 16:26:12 EDT --- mirrormanager-1.2.6-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mirrormanager'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-8911 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 --- Comment #23 from Fedora Update System [EMAIL PROTECTED] 2008-10-14 15:41:29 EDT --- mirrormanager-1.2.6-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/mirrormanager-1.2.6-1.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=445126
Paul Howarth [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #22 from Paul Howarth [EMAIL PROTECTED] 2008-10-02 11:38:11 EDT
---
What's the point of %define debug_package %{nil} in this package?
noarch packages don't generate debuginfo by default...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #21 from Kevin Fenzi [EMAIL PROTECTED] 2008-10-01 15:00:05 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 --- Comment #16 from manuel wolfshant [EMAIL PROTECTED] 2008-09-30 08:58:43 EDT --- I've done a local mock build and except of %Source0 (which once again does not match the content of https://fedorahosted.org/releases/m/i --- there is an extra mirrormanager/ folder in the way ) everything seems fine. If Jon does not have the time for a review and/or you want a fast forward, let me know. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 --- Comment #17 from Jon Stanley [EMAIL PROTECTED] 2008-09-30 10:01:28 EDT --- Fast forward sounds good to me :). Source0 in the 1.2.2 spec (the last one that I looked at) did have m/i/mirrormanager in it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=445126
manuel wolfshant [EMAIL PROTECTED] changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #18 from manuel wolfshant [EMAIL PROTECTED] 2008-09-30 10:18:30
EDT ---
ref #17: indeed, I missed a %{name} in the link
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64
[x] Rpmlint output:
source RPM: empty
binary RPMs:empty
[x] Package is not relocatable.
[x] Buildroot is correct (%(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XX))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type:MIT and GPLv2
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package match the upstream source, as provided
in the spec URL.
SHA1SUM of package: b584c6e192bea7b9a1d1e7eab0d9ac61d6e19a24
/tmp/mirrormanager-1.2.3.tar.bz2
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present (dependency is not
needed)
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: devel/x86_64
[?] Package should compile and build into binary rpms on all supported
architectures.
Tested on:
[x] Package functions as described.
note: only the client was tested
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
As far as I am I concerned, this packages seems OK so I am glad to say:
*** APPROVED ***
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 --- Comment #19 from Matt Domsch [EMAIL PROTECTED] 2008-09-30 10:29:55 EDT --- Sweet. Jon, I would sponsor you, but as I rewrote the whole spec from scratch here myself, I haven't reviewed any of your work. :-) Jon, do you want to maintain this package in Fedora, or should I? Thanks, Matt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 Jon Stanley [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #20 from Jon Stanley [EMAIL PROTECTED] 2008-09-30 14:10:36 EDT --- No worries on the sponsorship, I've been sponsored for awhile now for other packages I've done :) New Package CVS Request === Package Name: mirrormanager Short Description: A mirror management system Owners: mdomsch jstanley Branches: EL-5 F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 --- Comment #15 from Matt Domsch [EMAIL PROTECTED] 2008-09-29 00:35:12 EDT --- I've tagged a version 1.2.3 and uploaded a new spec and the tarball to the Source0 URL as one would expect. I have rearranged the upstream source tree to eliminate the whole mirrors/mirrors part of the directory name, and added a few Requires that some scripts brought to light. Thanks, Matt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 --- Comment #13 from manuel wolfshant [EMAIL PROTECTED] 2008-09-27 14:09:43 EDT --- Source URL seems incorrect: https://fedorahosted.org/releases/m/i/mirrormanager/mirrormanager-1.2.2.tar.bz2 gives: The requested URL /releases/m/i/mirrormanager/mirrormanager-1.2.2.tar.bz2 was not found on this server. Which is no surprise, since https://fedorahosted.org/releases/m/i/mirrormanager/ is empty Is /usr/share/mirrormanager/mirrors/mirrors really the intended path ? It looks a bit odd. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 --- Comment #14 from Matt Domsch [EMAIL PROTECTED] 2008-09-27 14:57:33 EDT --- wolfy: thanks for the review. I'll get the tarball posted soon; 1.2.2 was buggy and useless, so I didn't post the tarball. As for the mirrors/mirrors part, yes, that is intentional, though I understand it looks odd. It stems from the very earliest days of the code, before it was named mirrormanager. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445126] Review Request: mirrormanager - Fedora MirrorManager server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445126 Matt Domsch [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Summary|Review Request: |Review Request: |report-mirror - Fedora |mirrormanager - Fedora |MirrorManager client|MirrorManager server and ||client Flag|fedora-review+ |fedora-review? --- Comment #12 from Matt Domsch [EMAIL PROTECTED] 2008-09-26 16:13:27 EDT --- as upstream maintainer, I have now packaged this into tarballs and prepared it a spec for it, as one SRPM (mirrormanager) with two RPMs (mirrormanager - the server side, and mirrormanager-client - the downstream mirror side). http://domsch.com/linux/fedora/mirrormanager has the SPEC and SRPM for review. Jon and/or Jeroen, would you mind reviewing this? Thanks, Matt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
