[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-09-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #41 from Fedora Update System [EMAIL PROTECTED]  2008-09-10 
03:00:11 EDT ---
ntop-3.3.6-5.fc8 has been pushed to the Fedora 8 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-09-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #40 from Fedora Update System [EMAIL PROTECTED]  2008-09-10 
02:45:26 EDT ---
ntop-3.3.6-5.fc9 has been pushed to the Fedora 9 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #38 from Richard W.M. Jones [EMAIL PROTECTED]  2008-08-29 
05:19:20 EDT ---
OK, this is now built in the EL-5 branch.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #39 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-29 06:06:57 EDT 
---
https://admin.fedoraproject.org/pkgdb/packages/name/ntop

@Richard
Thanks Richard
May you add yourself as owner of that branch. I will release ownership for
EL-5.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397


Rakesh Pandit [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397


Richard W.M. Jones [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #36 from Richard W.M. Jones [EMAIL PROTECTED]  2008-08-28 
04:34:52 EDT ---
Package Change Request
==
Package Name: ntop
New Branches: EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #37 from Kevin Fenzi [EMAIL PROTECTED]  2008-08-29 00:53:11 EDT 
---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #29 from Mamoru Tasaka [EMAIL PROTECTED]  2008-08-12 04:55:11 EDT 
---
*** Bug 458770 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #30 from Michal Marciniszyn [EMAIL PROTECTED]  2008-08-12 
06:52:04 EDT ---
(In reply to comment #28)
 Michal: I can't seem to find you in the packager group. 
 Have you been sponsored? Only folks in the packager group can formally approve
 package reviews. 
 
 Is your account under another name/address in that group?

Hi,

I've just created fedoraprojec account (my fault, being 2 years with redhat
without this account is blame) and have been added to packager group. Thanks
for your notice.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #31 from Kevin Fenzi [EMAIL PROTECTED]  2008-08-12 13:17:43 EDT 
---
cvs done. 

Do consider EPEL branches here if this package builds/works there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #32 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-12 13:24:52 EDT 
---
@peter
I have started doing initial import now. May you add yourself to page:
https://admin.fedoraproject.org/pkgdb/packages/name/ntop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #33 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-12 13:35:47 EDT 
---
@peter

You are automatically added already:-)

@Kevin

Yes, will consider adding to EPEL branches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #34 from Fedora Update System [EMAIL PROTECTED]  2008-08-12 
15:15:25 EDT ---
ntop-3.3.6-5.fc8 has been submitted as an update for Fedora 8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #35 from Fedora Update System [EMAIL PROTECTED]  2008-08-12 
15:17:13 EDT ---
ntop-3.3.6-5.fc9 has been submitted as an update for Fedora 9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397


Pavel Alexeev [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #27 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-11 12:32:27 EDT 
---
Branches where missing:

New Package CVS Request
===
Package Name: ntop
Short Description: A network traffic probe similar to the UNIX top command
Owners: rakesh pvrabec
Branches: F-8 F-9
InitialCC:rakesh pvrabec
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397


Kevin Fenzi [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Comment #28 from Kevin Fenzi [EMAIL PROTECTED]  2008-08-11 13:13:14 EDT 
---
Michal: I can't seem to find you in the packager group. 
Have you been sponsored? Only folks in the packager group can formally approve
package reviews. 

Is your account under another name/address in that group?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #16 from Peter Vrabec [EMAIL PROTECTED]  2008-08-08 08:09:33 EDT 
---
Hi Rakesh, I think there is no need to package update if package proposed by me
pass the review.  I hope this tool will be available in F10 so we need to
finish the review as soon as possible. Is it OK?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397


Michal Marciniszyn [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #17 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-08 09:53:13 EDT 
---
No it is not okay.

You assigned request to yourself first, so you where supposed to review
request. I thought you wanted to review.

Review was submitted by me. So, if you really want to help , you are welcome.
Best way would have been to submit a patch. But as you have built then it is
okay. I would update with proper changelog mentioning your contribution and
Jakub's contribution.

But, if I am right about process, until and unless I say that I am not
interested in this package further or i don't respond quickly as and when
needed, you are not supposed to duplicate the package and say this is my
package and review it

I am and will be happy to own and maintain this package. In case you want to
co-maintain you are welcome -- there is a procedure for everything.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397


Patrice Dumas [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #18 from Patrice Dumas [EMAIL PROTECTED]  2008-08-08 10:13:29 EDT 
---
(In reply to comment #17)
 No it is not okay.

 But, if I am right about process, until and unless I say that I am not
 interested in this package further or i don't respond quickly as and when
 needed, you are not supposed to duplicate the package and say this is my
 package and review it
 
 I am and will be happy to own and maintain this package. In case you want to
 co-maintain you are welcome -- there is a procedure for everything.

You are right. 

However, if somebody comes and informally review Peter srpm and approve 
it it is still an interesting data point, though, in te end it is your 
package that will have to be formally reviewed and approved.

It would even be acceptable if you said, instead of 'not ok' something
along, 'reviewer, you can review Peter package as if I had prposed it 
myself'. But you seem to prefer that you resubmit somethin for the 
review and it is your choice, and since you are th esubmitter it 
has to be accepted by the reviewer (but as I said just above anybody can 
still comment on Peter package). 



@Peter: a review should never ever be done in a hurry. If the package 
does'nt make F10 launch, it will be in the updates. In my opinion
this is especially true for this review since it was first entered
2 years ago...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #19 from Michal Marciniszyn [EMAIL PROTECTED]  2008-08-08 
10:37:24 EDT ---
I looked at the package, everything seems ok, except that -devel package is not
build (which was explained by pvrabec to be ok) and there is small error in the
init script. There are followin tests in main run of initscript:

[ -x $ntop ] || exit 1
[ -r /etc/ntop.conf ] || exit 1
[ -r /var/lib/ntop/ntop_pw.db ] || exit 1

that should be moved in the start function instead. Also error codes can be
more precise, as 2nd and 3rd test failure indicates that the service is not
configured. So, correct version is

[ -x $ntop ] || exit 1
[ -r /etc/ntop.conf ] || exit 6
[ -r /var/lib/ntop/ntop_pw.db ] || exit 6

placed at the begining of start() function.

Except for this small problem, the package is ready for fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #20 from Peter Vrabec [EMAIL PROTECTED]  2008-08-08 10:45:03 EDT 
---
hey I'm sorry I didn't want to make a review, so reassigning to me was my
fault. I wanted to push this further. What do you suggest to do now?

I can provide new package ASAP. Then we(you or me) can import into cvs.

I'll appreciate if I can be maintainer or co-maintainer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #21 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-08 10:49:26 EDT 
---
@patrice

Thanks for clarification. I am happy that peter is interested. Actually I was
confused, because peter assigned request to himself first and also proposed the
package.

@peter

I am also sorry for creating confusion. I would be very happy if you would
rebuild clearing the above thing mentioned by Michal. Lets work on it
collectively. Please, you may like to be co-maintainer

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #22 from Peter Vrabec [EMAIL PROTECTED]  2008-08-08 11:02:36 EDT 
---
here we go

Spec URL: http://people.redhat.com/pvrabec/rpms/ntop.spec
SRPM URL: http://people.redhat.com/pvrabec/rpms/ntop-3.3.6-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #23 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-08 11:34:56 EDT 
---
Just updated the changelog mentioning Jakub H's patch update.

SRPM: http://rakesh.fedorapeople.org/srpm/ntop-3.3.6-3.fc9.src.rpm
SPEC: http://rakesh.fedorapeople.org/spec/ntop.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #24 from Peter Vrabec [EMAIL PROTECTED]  2008-08-08 11:57:06 EDT 
---
some more init script tuning

Spec URL: http://people.redhat.com/pvrabec/rpms/ntop.spec
SRPM URL: http://people.redhat.com/pvrabec/rpms/ntop-3.3.6-4.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #25 from Peter Vrabec [EMAIL PROTECTED]  2008-08-08 12:28:59 EDT 
---
so much tuning that I made small but important typo.(time to go home :) )

Spec URL: http://people.redhat.com/pvrabec/rpms/ntop.spec
SRPM URL: http://people.redhat.com/pvrabec/rpms/ntop-3.3.6-5.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #13 from Peter Vrabec [EMAIL PROTECTED]  2008-08-07 11:32:26 EDT 
---
Update !!!

Spec URL: http://people.redhat.com/pvrabec/rpms/ntop.spec
SRPM URL: http://people.redhat.com/pvrabec/rpms/ntop-3.3.6-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #14 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-07 11:48:04 EDT 
---
Peter thanks!!

It went out of my mind for long now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Comment #15 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-07 23:58:42 EDT 
---
I will update package today evening IST

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-08-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448397


Peter Vrabec [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
Customer Facing||---
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-07-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Additional Comments From [EMAIL PROTECTED]  2008-07-28 15:51 EST ---
Created an attachment (id=312813)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=312813action=view)
A modified patch

A modified ntop-am.patch that applies even with --fuzz=0.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-07-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Additional Comments From [EMAIL PROTECTED]  2008-07-28 15:54 EST ---
Doh, I haven't sent the comment describing the attachment, sorry. Here's the
thing - the ntop-am.patch did not apply due to --fuzz=0 being used in rawhide
and thus ntop did not build cleanly. I've modified the patch to make things work
again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-07-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Additional Comments From [EMAIL PROTECTED]  2008-07-28 16:25 EST ---
Thanks for your work ;-)

I will apply it and rebuild soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-07-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|177841  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2008-07-16 20:28 EST ---
Removing needsponsor, I have sponsored Rakesh.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Additional Comments From [EMAIL PROTECTED]  2008-07-14 13:47 EST ---
Corrected release number:
SRPM: http://rakesh.fedorapeople.org/srpm/ntop-3.3-4.fc8.src.rpm
SPEC: http://rakesh.fedorapeople.org/spec/ntop.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Additional Comments From [EMAIL PROTECTED]  2008-07-02 04:37 EST ---
(In reply to comment #5)
 There is one more warning which comes:
 ntop.i386: W: dangerous-command-in-%postun userdel
 
 Actually, this one cleans ntop username which was created while installing 
 ntop. It look to me Okay.

Actually it's not OK. We don't remove users/groups created in packages. See
http://fedoraproject.org/wiki/Packaging/UsersAndGroups

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Additional Comments From [EMAIL PROTECTED]  2008-07-02 14:16 EST ---
Actually it's not OK. We don't remove users/groups cre ted in packages. See
 ttp://fedoraproject.org/wiki/Packaging/UsersAndGroups

Thanks for pointing out. 
Fixed


Updated:
Spec URL: http://rakesh.gnulinuxcentar.org/ntop.spec
SRPM URL: http://rakesh.gnulinuxcentar.org/ntop-3.3-3.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-07-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Additional Comments From [EMAIL PROTECTED]  2008-07-01 22:05 EST ---
 Will update soon on rpath.

Fixed

Spec URL: http://rakesh.gnulinuxcentar.org/ntop.spec
SRPM URL: http://rakesh.gnulinuxcentar.org/ntop-3.3-3.fc8.src.rpm

There is one more warning which comes:
ntop.i386: W: dangerous-command-in-%postun userdel

Actually, this one cleans ntop username which was created while installing 
ntop. It look to me Okay.

--
Regards
Rakesh Pandit

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397





--- Additional Comments From [EMAIL PROTECTED]  2008-06-29 12:27 EST ---
  E: binary-or-shlib-defines-rpath /usr/sbin/ntop ['/usr/lib64']
  E: binary-or-shlib-defines-rpath /usr/lib64/libntopreport-3.3.so 
   ['/usr/lib64']
These need to be fixed.  The information at

I was not able to reproduce on my m/c. Will try to check on 64 bit m/c

  W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /lib64/
libcrypt.so.1
  W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /lib64/
libnsl.so.1
  W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /lib64/
libssl.so.7
  W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /usr/lib64/
libsensors.so.4
These indicate that the ntop libs are linked against various other libraries

Fixed.

You can drop the %if 0%{?fedora} = 7 conditional stuff

Fixed.

Spec URL: http://rakesh.gnulinuxcentar.org/ntop.spec
SRPM URL: http://rakesh.gnulinuxcentar.org/ntop-3.3-3.fc8.src.rpm

Will update soon on rpath. 

--
Rakesh Pandit

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448397] Review Request: ntop - A network traffic probe similar to the UNIX top command

2008-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop_package

https://bugzilla.redhat.com/show_bug.cgi?id=448397


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-06-06 14:27 EST ---
Just to recap our recent discussion on IRC:

You can drop the %if 0%{?fedora} = 7 conditional stuff, since we no longer 
support any release where it would trigger.

The specfile should consistently use either the macro forms like %{__mv} or 
the regular mv; I personally prefer the non-macro forms because it's less 
typing, but it's up to you.

I went ahead and built the package; rpmlint has many complaints.  Ignoring 
non-standard-{gid,dir-perm,executable-perm} and such, I see:

  E: binary-or-shlib-defines-rpath /usr/sbin/ntop ['/usr/lib64']
  E: binary-or-shlib-defines-rpath /usr/lib64/libntopreport-3.3.so 
   ['/usr/lib64']
These need to be fixed.  The information at
http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath should
help.

  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so static_ntop
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so welcome
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so setAdminPassword
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so usage
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so welcome
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so showUsers
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so addURL
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so doAddURL
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so doChangeFilter
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so addUser
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so doAddUser
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so deleteUser
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so showURLs
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so deleteURL
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so 
addDefaultAdminUser
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so changeFilter
  W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so handleNtopConfig
  W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so static_ntop
  W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so welcome
  W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so setAdminPassword
  W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so usage
  W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so welcome
It seems that libntopreport isn't linked against libntop, and libntop isn't
linked against some other library.  Which seems odd, but isn't necessarily
problem as long as all of the executables that use them are linked properly or
provide the proper symbols.

  W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so 
/lib64/libpcre.so.0
  W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so 
/usr/lib64/mysql/libmysqlclient_r.so.15
  W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so 
/lib64/libnsl.so.1
  W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so 
/usr/lib64/libsensors.so.4
  W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so 
/usr/lib64/libnetsnmp.so.15
  W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so 
/usr/lib64/librrd_th.so.2
  W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so 
/lib64/libcrypt.so.1
  W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /lib64/libnsl.so.1
  W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /lib64/libssl.so.7
  W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so 
/usr/lib64/libsensors.so.4
These indicate that the ntop libs are linked against various other libraries
but don't actually call them.  It's not strictly necessary to fix these as
they're only inefficient, but there's some info at
http://fedoraproject.org/wiki/PackageMaintainers/CommonRpmlintIssues#unused-direct-shlib-dependency
if you're interested.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review