[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 Ben Boeckel [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #53 from Ben Boeckel [EMAIL PROTECTED] 2008-09-23 08:40:27 EDT --- Pushed to Bodhi this morning. Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #52 from Kevin Fenzi [EMAIL PROTECTED] 2008-09-20 20:33:15 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #48 from Ben Boeckel [EMAIL PROTECTED] 2008-09-19 08:32:17 EDT --- (In reply to comment #47) I found your account on FAS (Fedora Account System), however it seems that your FAS mail account differs from that you use on this bugzilla. Please fix either of them, then I will sponsor you. They differ by case. FAS and BZ says an email address already exists when I try to change either one of them (BZ used all lower case when I joined IIRC; I'd have used the correct case if I could). If they need to match 100%, where can I request that the already-exists error be overridden? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #49 from Ben Boeckel [EMAIL PROTECTED] 2008-09-19 09:23:55 EDT --- Nevermind, used an intermediate email address. FAS is now all lower case. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Blocks|177841 | --- Comment #50 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 09:46:57 EDT --- Okay now I am sponsoring you. Please follow Join wiki again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #51 from Ben Boeckel [EMAIL PROTECTED] 2008-09-19 10:21:30 EDT --- New Package CVS Request === Package Name: sigen Short Description: Strategy/RPG game engine Owners: mathstuf Branches: F-8 F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #47 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 01:49:34 EDT --- Okay, now as krazy2 is in good shape, This package (sigen) is APPROVED by mtasaka Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join I found your account on FAS (Fedora Account System), however it seems that your FAS mail account differs from that you use on this bugzilla. Please fix either of them, then I will sponsor you. If you want to import this package into Fedora 8/9, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #46 from Ben Boeckel [EMAIL PROTECTED] 2008-09-17 11:27:18 EDT --- Ah. Didn't understand that I needed two packages or reviews. Will work on krazy2 today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 Ben Boeckel [EMAIL PROTECTED] changed: What|Removed |Added Blocks|177841 | --- Comment #44 from Ben Boeckel [EMAIL PROTECTED] 2008-09-17 00:55:09 EDT --- I assume you have to enable CVS access. My FAS account is mathstuf. I don't see myself as part of the packager group yet (or do I have to apply first?) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Blocks||177841 --- Comment #45 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-17 01:36:55 EDT --- Well, as said on my comment 40, you have to either - pre-review other persion's review request - or submit another review request of yours so as to show that you have an understanding of the process and of the packaging guidelines before getting sponsored. This is one review request and for your case I am waiting for you to update bug 447844 (i.e. your another review request). Once re-setting NEEDSPONSOR. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 Itamar Reis Peixoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Alias||sigen -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #43 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-10 02:40:08 EDT --- Okay, now this package itself is okay. (In reply to comment #42) (In reply to comment #40) For your case, you have another review request (bug 447844), however your latest srpm on that bug does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=813914 Would you also update the srpm on bug 447844 for sponsoring process? It's going to take a bit longer than I thought it would when I first undertook the task. I need to analyze the buildscript provided and separate what is noarch and what isn't and make subpackages as needed. I'll keep working on it as it's a nice tool I'd like to have. Just noting that the actual build log is available from build.log on http://koji.fedoraproject.org/koji/taskinfo?taskID=813919 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Blocks|182235 | --- Comment #38 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-08 13:33:04 EDT --- Removing FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450371
--- Comment #39 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-08 14:07:42 EDT
---
Well, for sigen 0.0.2-0.16.svn
* Summary, description
- Usually The Sigma Game Engine is is redundant for summary
- rpmlint warns:
sigen.i386: E: description-line-too-long The Sigma Game Engine is an
RPG/Strategy game engine. The following is provided:
%description lines should have less than 80 characters.
* make build log more verbose
- Well, maybe I forgot to mention this before (umm), however
current build.log shows:
1766 Building CXX object sigscript/CMakeFiles/sigscript.dir/SigmodWrapper.o
1767 [ 51%]
1768 Building CXX object sigscript/CMakeFiles/sigscript.dir/SkinWrapper.o
1769 [ 51%]
1770 Building CXX object sigscript/CMakeFiles/sigscript.dir/SoundWrapper.o
1771 [ 51%]
1772 Building CXX object sigscript/CMakeFiles/sigscript.dir/SpeciesWrapper.o
1773 [ 52%]
1774 Building CXX object
sigscript/CMakeFiles/sigscript.dir/SpeciesAbilityWrapper.o
which is not useful, for example we cannot check from this log
if Fedora specific compilation flags are honored correctly.
Perhaps as this uses cmake make VERBOSE=1 %{_smp_mflags} will
show more verbose logs. Please refer to:
https://fedoraproject.org/wiki/Packaging/cmake
* %doc
- Files under %docdir are automatically marked as %doc
* Directory ownership issue
- The directory %{_docdir}/%{name}-%{version}/ is not owned by any packages
(please refer to:
https://fedoraproject.org/wiki/PackagingDrafts/UnownedDirectories )
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #40 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-08 14:09:58 EDT --- Then: - NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to show that you have an understanding of the process and of the packaging guidelines as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a pre-review of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on: http://fedoraproject.org/PackageReviewStatus/NEW.html (NOTE: please don't choose Merge Review) Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets For your case, you have another review request (bug 447844), however your latest srpm on that bug does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=813914 Would you also update the srpm on bug 447844 for sponsoring process? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #37 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-07 23:33:34 EDT --- (new spec/srpm from the reporter: Spec URL: http://benboeckel.net/sigen/sigen.spec SRPM URL: http://benboeckel.net/sigen/sigen-0.0.2-0.16.20080907svn255.fc9.src.rpm ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
