[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #69 from Fedora Update System upda...@fedoraproject.org 2010-01-07 16:45:46 EDT --- mod_proxy_html-3.1.2-6.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|3.1.2-5.fc11|3.1.2-6.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|3.1.2-6.fc12|3.1.2-6.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #70 from Fedora Update System upda...@fedoraproject.org 2010-01-07 16:54:50 EDT --- mod_proxy_html-3.1.2-6.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #66 from Fedora Update System upda...@fedoraproject.org 2009-12-17 23:21:29 EDT --- mod_proxy_html-3.1.2-6.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mod_proxy_html'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13279 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||3.1.2-5.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #67 from Fedora Update System upda...@fedoraproject.org 2009-12-17 23:24:23 EDT --- mod_proxy_html-3.1.2-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #68 from Fedora Update System upda...@fedoraproject.org 2009-12-17 23:37:03 EDT --- mod_proxy_html-3.1.2-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|3.1.2-5.fc12|3.1.2-5.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #63 from Fedora Update System upda...@fedoraproject.org 2009-12-16 17:54:51 EDT --- mod_proxy_html-3.1.2-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mod_proxy_html-3.1.2-5.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #62 from Fedora Update System upda...@fedoraproject.org 2009-12-16 17:53:13 EDT --- mod_proxy_html-3.1.2-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mod_proxy_html-3.1.2-5.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #65 from Fedora Update System upda...@fedoraproject.org 2009-12-16 19:00:18 EDT --- mod_proxy_html-3.1.2-6.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mod_proxy_html-3.1.2-6.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #64 from Fedora Update System upda...@fedoraproject.org 2009-12-16 19:00:13 EDT --- mod_proxy_html-3.1.2-6.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mod_proxy_html-3.1.2-6.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #57 from Philip Prindeville phil...@redfish-solutions.com 2009-12-15 20:46:33 EDT --- *** Bug 547930 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #58 from Philip Prindeville phil...@redfish-solutions.com 2009-12-15 20:57:03 EDT --- New Package CVS Request === Package Name: mod_proxy_html Short Description: reverse-proxy output filter for HTML Owners: philipp Branches: F-11 F-12 InitialCC: s4504kr limb -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #59 from Ray Van Dolson ra...@bludgeon.org 2009-12-15 21:08:58 EDT --- Please branch for EL-4 and EL-5 as well (if willing). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #60 from Philip Prindeville phil...@redfish-solutions.com 2009-12-15 21:18:05 EDT --- New Package CVS Request === Package Name: mod_proxy_html Short Description: reverse-proxy output filter for HTML Owners: philipp Branches: F-11 F-12 EL-4 EL-5 InitialCC: s4504kr limb -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #61 from Kevin Fenzi ke...@tummy.com 2009-12-16 00:30:47 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added CC||joc...@herr-schmitt.de AssignedTo|l...@jcomserv.net |joc...@herr-schmitt.de --- Comment #50 from Jochen Schmitt joc...@herr-schmitt.de 2009-12-10 13:57:53 EDT --- OK, I have take a short look on your package and have to recorgnise, that the packaged release is obsolete, because this is an old review. So it may be nice, if you can create a package for the current release 3.1. If this package may ok, I'm willing to sponsor you. Best Regards: Jochen Schmitt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Attachment #317209|0 |1 is obsolete|| --- Comment #52 from Philip Prindeville phil...@redfish-solutions.com 2009-12-10 14:08:18 EDT --- Created an attachment (id=377565) -- (https://bugzilla.redhat.com/attachment.cgi?id=377565) Replacement .src file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Attachment #317207|0 |1 is obsolete|| --- Comment #51 from Philip Prindeville phil...@redfish-solutions.com 2009-12-10 14:07:11 EDT --- Created an attachment (id=377563) -- (https://bugzilla.redhat.com/attachment.cgi?id=377563) Replacement .spec file Bump to 3.1.2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #53 from Jochen Schmitt joc...@herr-schmitt.de 2009-12-10 14:29:57 EDT --- Good: + Could download upstream sources via spectool -g + Packaged tar ball matches with upstr (md5sum: d6497b48d2bffc4150472472004618c3) + Local build works fine + Rpmlint is silent on source package + Rpmlint is silent on binary package + Rpmlint is silent on debuginfo package + Scratch build on koji works fine *** APPROVED *** Please do the following step: 1.) Create a FAS account 2.) Fullfill the CLA 3.) Request membership in the packages group 4.) Send me your FAS-id for sponsoring. A additional advice for future reviews: Please try to get a webspace and upload the SPEC file and the source rpms to it. and post the URLs in the bug report. Of course you can take the space on fedorapeople.org which you will get after you has a valid FAS account. Best Regards Jochen Schmitt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #54 from Philip Prindeville phil...@redfish-solutions.com 2009-12-10 14:46:53 EDT --- Jochen: id is philipp. I just sent in the packagers group request. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #55 from Jochen Schmitt joc...@herr-schmitt.de 2009-12-10 14:57:16 EDT --- I have approve your membership request. so you can now create a CVSAdmin request for your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added URL||http://www.djhsolutions.net ||/pprindeville/mod_proxy_htm ||l-3.1.2-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #56 from Philip Prindeville phil...@redfish-solutions.com 2009-12-10 16:35:55 EDT --- URLs: http://www.djhsolutions.net/pprindeville/mod_proxy_html-3.1.2-1.fc11.src.rpm http://www.djhsolutions.net/pprindeville/mod_proxy_html.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #48 from Jon Ciesla l...@jcomserv.net 2009-07-23 07:55:36 EDT --- FYI, Philip, I attempted to reply to your email, but: - The following addresses had permanent fatal errors - phil...@redfish-solutions.com (reason: 554 mail.redfish-solutions.com ESMTP not accepting messages) - Transcript of session follows - ... while talking to mail.redfish-solutions.com.: 554 mail.redfish-solutions.com ESMTP not accepting messages 554 5.0.0 Service unavailable -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #49 from Philip Prindeville phil...@redfish-solutions.com 2009-07-23 14:26:45 EDT --- (In reply to comment #48) FYI, Philip, I attempted to reply to your email, but: - The following addresses had permanent fatal errors - phil...@redfish-solutions.com (reason: 554 mail.redfish-solutions.com ESMTP not accepting messages) - Transcript of session follows - ... while talking to mail.redfish-solutions.com.: 554 mail.redfish-solutions.com ESMTP not accepting messages 554 5.0.0 Service unavailable I added whitelisting for 76.204.165.225. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Jon Ciesla l...@jcomserv.net changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@jcomserv.net AssignedTo|nob...@fedoraproject.org|l...@jcomserv.net Flag||fedora-review? --- Comment #46 from Jon Ciesla l...@jcomserv.net 2009-07-22 08:06:51 EDT --- Philip, I can sponsor and do the formal review. I'll start on that today. While I'm on that, can you point me to a few practice reviews you've done? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452636
--- Comment #47 from Jon Ciesla l...@jcomserv.net 2009-07-22 09:09:02 EDT ---
Formal review:
# MUST: rpmlint must be run on every package. The output should be posted in
the review.[1]
Clean.
# MUST: The package must be named according to the Package Naming Guidelines .
OK. Might want to change Source: to Source0:
# MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
OK.
# MUST: The package must meet the Packaging Guidelines .
OK.
# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
OK.
# MUST: The License field in the package spec file must match the actual
license. [3]
OK.
# MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
OK.
# MUST: The spec file must be written in American English. [5]
OK.
# MUST: The spec file for the package MUST be legible. [6]
OK.
# MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK.
# MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
OK.
# MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
N/A
# MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK.
# MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
OK.
# MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
N/A
# MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [11]
N/A
# MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [12]
OK.
# MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. [13]
OK.
# MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. [14]
OK.
# MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT). [15]
OK.
# MUST: Each package must consistently use macros. [16]
OK.
# MUST: The package must contain code, or permissable content. [17]
OK.
# MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
N/A
# MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]
OK.
# MUST: Header files must be in a -devel package. [19]
N/A
# MUST: Static libraries must be in a -static package. [20]
N/A
# MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability). [21]
N/A
# MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. [19]
Apache module, N/A
# MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} [22]
N/A
# MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.[20]
OK.
# MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Erik S. LaBianca erik.labia...@gmail.com changed: What|Removed |Added CC||erik.labia...@gmail.com --- Comment #42 from Erik S. LaBianca erik.labia...@gmail.com 2009-07-17 15:07:05 EDT --- Just as a point of interest, I downloaded the .src.rpm from comment #1 and was able to build and use it perfectly on CentOS 5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #43 from Philip Prindeville phil...@redfish-solutions.com 2009-07-17 15:51:36 EDT --- Posting to fedora-devel today to ask for a sponsor to be assigned. This fix has been good to go for 10 months now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #44 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2009-07-17 20:16:37 EDT --- new version 8.4.0 http://ispbrasil.com.br/pgsql/mingw32-postgresql.spec http://ispbrasil.com.br/pgsql/mingw32-postgresql-8.4.0-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #45 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2009-07-17 20:20:00 EDT --- (In reply to comment #44) oh my god! , I am sorry, posted in wrong bug, please ignore my previous post :-( my mistake -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #315605|0 |1 is obsolete|| --- Comment #37 from Philip Prindeville [EMAIL PROTECTED] 2008-09-19 11:30:18 EDT --- Created an attachment (id=317204) -- (https://bugzilla.redhat.com/attachment.cgi?id=317204) Replacement .spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #315606|0 |1 is obsolete|| --- Comment #38 from Philip Prindeville [EMAIL PROTECTED] 2008-09-19 11:31:08 EDT --- Created an attachment (id=317205) -- (https://bugzilla.redhat.com/attachment.cgi?id=317205) Replacement .src.rpm file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #39 from Joe Orton [EMAIL PROTECTED] 2008-09-19 11:42:35 EDT --- You lost BuildRequires: libxml2-devel httpd-devel somewhere along the way - if that was a result of my comments about losing the Requires, my apologies. The LoadModule for the module should be uncommented by default; i.e. the module should be loaded by default, when installed. If someone doesn't want the module loaded, they can remove the package :) Other than that, this looks great, thanks for persevering! I'm not an Official Sponsor so I can't do the formal review unfortunately. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #317204|0 |1 is obsolete|| --- Comment #40 from Philip Prindeville [EMAIL PROTECTED] 2008-09-19 11:58:54 EDT --- Created an attachment (id=317207) -- (https://bugzilla.redhat.com/attachment.cgi?id=317207) Replacement .spec file Put back BuildRequires: as before. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #317205|0 |1 is obsolete|| --- Comment #41 from Philip Prindeville [EMAIL PROTECTED] 2008-09-19 12:02:20 EDT --- Created an attachment (id=317209) -- (https://bugzilla.redhat.com/attachment.cgi?id=317209) Replacement .src.rpm file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Itamar Reis Peixoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Alias||mod_proxy_html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #36 from Philip Prindeville [EMAIL PROTECTED] 2008-09-06 15:12:31 EDT --- Quick question: should the LoadModule that enables this functionality be uncommented from the config file by default by installation? Or is that something that should be enabled explicitly by the end-user uncommenting that line? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #314112|0 |1 is obsolete|| --- Comment #31 from Philip Prindeville [EMAIL PROTECTED] 2008-09-02 19:25:17 EDT --- Created an attachment (id=315602) -- (https://bugzilla.redhat.com/attachment.cgi?id=315602) Replacement .spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #314111|0 |1 is obsolete|| --- Comment #32 from Philip Prindeville [EMAIL PROTECTED] 2008-09-02 19:27:11 EDT --- Created an attachment (id=315603) -- (https://bugzilla.redhat.com/attachment.cgi?id=315603) Replacement .src.rpm file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #33 from Philip Prindeville [EMAIL PROTECTED] 2008-09-02 19:29:43 EDT --- (In reply to comment #27) (In reply to comment #26) (In reply to comment #22) non-formal review: 4) Source: http://apache.webthing.com/mod_proxy_html/mod_proxy_html.tgz is bad - do upstream not provide versioned URLs? Unfortunately, they do not. upstream should be educated then ;) You'll need to work around that and version the tarball manually, I think this is covered in the wiki somewhere. Upstream has cooperated in adding numbered versions. All other issues have been addressed. Results from rpmlint: $ rpmlint mod_proxy_html.spec ../RPMS/i386/mod_proxy_html-debuginfo-3.0.1-7.fc8.i386.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. $ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #315602|0 |1 is obsolete|| --- Comment #34 from Philip Prindeville [EMAIL PROTECTED] 2008-09-02 19:34:09 EDT --- Created an attachment (id=315605) -- (https://bugzilla.redhat.com/attachment.cgi?id=315605) Replacement .spec file Forgot to update ChangeLog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #315603|0 |1 is obsolete|| --- Comment #35 from Philip Prindeville [EMAIL PROTECTED] 2008-09-02 19:35:02 EDT --- Created an attachment (id=315606) -- (https://bugzilla.redhat.com/attachment.cgi?id=315606) Replacement .src.rpm file Forgot to edit ChangeLog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452636
--- Comment #28 from Philip Prindeville [EMAIL PROTECTED] 2008-08-14
02:35:50 EDT ---
(In reply to comment #27)
(In reply to comment #26)
(In reply to comment #22)
non-formal review:
4) Source: http://apache.webthing.com/mod_proxy_html/mod_proxy_html.tgz
is bad - do upstream not provide versioned URLs?
Unfortunately, they do not.
upstream should be educated then ;)
That might be beyond the scope of this bug fix. ;-)
In any case, I've tried contacting the owners but not gotten any traction with
them.
You'll need to work around that and version the tarball manually, I think this
is covered in the wiki somewhere.
I looked at:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Non-Numeric_Version_in_Release
but didn't find it there. Nor is it in:
http://fedoraproject.org/wiki/Packaging/SourceURL
Can you point me at the right guidelines?
Also, rpmlint doesn't seem to have issue with Source0: not containing
%{version}. Is that a shortcoming of rpmlint?
5) using %{_sbindir}/apxs throughout is probably a good idea
Ok. I thought that allowing for the potential of testing an alternate
version
of apxs might be a good thing.
I'm not sure it really makes a difference, but it reduces predictability if
apxs is picked from $PATH.
All other comments have been addressed.
more nit-picking^W^Wreview:
1) this stuff is unnecessary obfuscation:
%define base proxy_html
%define modname mod_%{base}
Name: %{modname}
the spec file is for building mod_proxy_html, not an abstract httpd module; so
use Name: mod_proxy_html and hard-code proxy_html as necessary and
mod_proxy_html or %{name} otherwise.
2) the with-xml options should go; the module should be linked against -lxml2
and the conf file purged of LoadFile unconditionally. The upstream method of
providing a deliberately broken module is totally crazy and not something that
should be supported (even as an option) in Fedora.
Not sure I follow you. Why does Apache support LoadFile then? Or is it a
Fedora policy to discourage using it? (It's not documented in:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28httpd.2C_pam.2C_and_SDL.29
so where should I be looking?)
otherwise looks fine.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #29 from Ray Van Dolson [EMAIL PROTECTED] 2008-08-14 12:03:40 EDT --- I think either way would end up functionally the same; however, if we link against libxml2, we then get an implicit requires against libxml2 although I suppose you could just manually add an explicit Requires as well. I'm not a technical expert on the subject at all however, so I'd be interested in hearing why LoadFile would be a better alternative than linking? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Patrice Dumas [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #30 from Patrice Dumas [EMAIL PROTECTED] 2008-08-14 12:18:04 EDT --- (In reply to comment #29) I think either way would end up functionally the same; however, if we link against libxml2, we then get an implicit requires against libxml2 although I suppose you could just manually add an explicit Requires as well. I'm not a technical expert on the subject at all however, so I'd be interested in hearing why LoadFile would be a better alternative than linking? Using a loadfile is certainly not the way to go in fedora. Linking against libxml2 doesn't only add an automatic requires, this is a mere side effect of adding the soname dependency on the right libxml2 version in the binary (something along libxml2.so.2). The binary will refuse to run if the libxml2 shared object with the right version isn't found. There are ways to use another library at runtime (certainly by setting LD_LIBRARY_PATH), using LoadFile (which certainly does a dlopen) is not right. Ther are cases where using LoadFile or similar are right (like plugins for example), but here it doesn't seems to be the case at all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Joe Orton [EMAIL PROTECTED] changed: What|Removed |Added Attachment #314112|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452636
--- Comment #27 from Joe Orton [EMAIL PROTECTED] 2008-08-13 07:23:21 EDT ---
(In reply to comment #26)
(In reply to comment #22)
non-formal review:
4) Source: http://apache.webthing.com/mod_proxy_html/mod_proxy_html.tgz
is bad - do upstream not provide versioned URLs?
Unfortunately, they do not.
upstream should be educated then ;)
You'll need to work around that and version the tarball manually, I think this
is covered in the wiki somewhere.
5) using %{_sbindir}/apxs throughout is probably a good idea
Ok. I thought that allowing for the potential of testing an alternate version
of apxs might be a good thing.
I'm not sure it really makes a difference, but it reduces predictability if
apxs is picked from $PATH.
All other comments have been addressed.
more nit-picking^W^Wreview:
1) this stuff is unnecessary obfuscation:
%define base proxy_html
%define modname mod_%{base}
Name: %{modname}
the spec file is for building mod_proxy_html, not an abstract httpd module; so
use Name: mod_proxy_html and hard-code proxy_html as necessary and
mod_proxy_html or %{name} otherwise.
2) the with-xml options should go; the module should be linked against -lxml2
and the conf file purged of LoadFile unconditionally. The upstream method of
providing a deliberately broken module is totally crazy and not something that
should be supported (even as an option) in Fedora.
otherwise looks fine.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Joe Orton [EMAIL PROTECTED] changed: What|Removed |Added Attachment #311673|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452636
Joe Orton [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
Customer Facing||---
--- Comment #22 from Joe Orton [EMAIL PROTECTED] 2008-08-12 07:13:57 EDT ---
non-formal review:
1) remove the Vendor, Packager, Provides and Excludeos tags
2) remove Requires: httpd, libxml2 - only Requires necessary should be:
Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing)
3) use an approved BuildRoot tag, see wiki packaging guidelines
4) Source: http://apache.webthing.com/mod_proxy_html/mod_proxy_html.tgz
is bad - do upstream not provide versioned URLs?
5) using %{_sbindir}/apxs throughout is probably a good idea
6) License: GPL should follow the licensing conventions on the wiki
http://fedoraproject.org/wiki/Licensing
7) the package should be called simply mod_proxy_html, no httpd- prefix
necessary
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452636
--- Comment #23 from Philip Prindeville [EMAIL PROTECTED] 2008-08-12
12:01:52 EDT ---
(In reply to comment #22)
non-formal review:
1) remove the Vendor, Packager, Provides and Excludeos tags
2) remove Requires: httpd, libxml2 - only Requires necessary should be:
Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing)
3) use an approved BuildRoot tag, see wiki packaging guidelines
4) Source: http://apache.webthing.com/mod_proxy_html/mod_proxy_html.tgz
is bad - do upstream not provide versioned URLs?
5) using %{_sbindir}/apxs throughout is probably a good idea
6) License: GPL should follow the licensing conventions on the wiki
http://fedoraproject.org/wiki/Licensing
7) the package should be called simply mod_proxy_html, no httpd- prefix
necessary
The most recent version of the .rpm and .spec files are attached directly to
this bug report.
I'll make the remaining fixes that you suggest that haven't been made (most
already have).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #311672|0 |1 is obsolete|| --- Comment #24 from Philip Prindeville [EMAIL PROTECTED] 2008-08-12 12:20:14 EDT --- Created an attachment (id=314111) -- (https://bugzilla.redhat.com/attachment.cgi?id=314111) Replacement .src.rpm file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #311673|0 |1 is obsolete|| --- Comment #25 from Philip Prindeville [EMAIL PROTECTED] 2008-08-12 12:21:26 EDT --- Created an attachment (id=314112) -- (https://bugzilla.redhat.com/attachment.cgi?id=314112) Replacement .spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452636
--- Comment #26 from Philip Prindeville [EMAIL PROTECTED] 2008-08-12
12:23:59 EDT ---
(In reply to comment #22)
non-formal review:
4) Source: http://apache.webthing.com/mod_proxy_html/mod_proxy_html.tgz
is bad - do upstream not provide versioned URLs?
Unfortunately, they do not.
5) using %{_sbindir}/apxs throughout is probably a good idea
Ok. I thought that allowing for the potential of testing an alternate version
of apxs might be a good thing.
All other comments have been addressed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #311550|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2008-07-13 17:23 EST --- Created an attachment (id=311673) -- (https://bugzilla.redhat.com/attachment.cgi?id=311673action=view) Replacement .spec file Fixed gcc warning about missing braces/ambiguous else. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #311551|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2008-07-13 17:22 EST --- Created an attachment (id=311672) -- (https://bugzilla.redhat.com/attachment.cgi?id=311672action=view) Replacement .src.rpm file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Additional Comments From [EMAIL PROTECTED] 2008-07-13 17:25 EST --- New rpmlint run: $ rpmlint mod_proxy_html.spec ../RPMS/i386/mod_proxy_html-3.0.1-5.fc8.i386.rpm mod_proxy_html.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 47, tab: line 42) 1 packages and 1 specfiles checked; 0 errors, 1 warnings. $ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #310749|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2008-07-11 02:08 EST --- Created an attachment (id=311551) -- (https://bugzilla.redhat.com/attachment.cgi?id=311551action=view) Replacement .src.rpm file Built under FC8 on i386 processor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Additional Comments From [EMAIL PROTECTED] 2008-07-11 02:09 EST --- Ran rpmlint on file. It generates one warning, which is actually erroneous. $ rpmlint mod_proxy_html.spec mod_proxy_html.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 45, tab: line 40) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #310960|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2008-07-11 02:07 EST --- Created an attachment (id=311550) -- (https://bugzilla.redhat.com/attachment.cgi?id=311550action=view) Replacement .spec file Cleaned up 64-bit architecture issue. Made it pass rpmlint. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #310748|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2008-07-03 16:31 EST --- Created an attachment (id=310960) -- (https://bugzilla.redhat.com/attachment.cgi?id=310960action=view) Replacement .spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Additional Comments From [EMAIL PROTECTED] 2008-07-01 22:07 EST --- Created an attachment (id=310748) -- (https://bugzilla.redhat.com/attachment.cgi?id=310748action=view) Replacement .spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Additional Comments From [EMAIL PROTECTED] 2008-07-01 22:09 EST --- Created an attachment (id=310749) -- (https://bugzilla.redhat.com/attachment.cgi?id=310749action=view) Replacement .src.rpm file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Additional Comments From [EMAIL PROTECTED] 2008-07-01 22:05 EST --- Asked on #apache-modules, and the consensus was that having explicit control of where a shared-object library got loaded from was a good thing, especially if you might want to try out a newer version of that library, etc. I've added a --with xml option to build that adds it to the explicit list of dependencies for the shared-object, but this is off by default and should probably not be enabled in the distro release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #310748|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request:http-|Review Request: |mod_proxy_html - Module to |mod_proxy_html - Module to |rewrite content as it passes|rewrite content as it passes |through an apache proxy.|through an apache proxy. --- Additional Comments From [EMAIL PROTECTED] 2008-06-30 14:22 EST --- I'd like to get the opinion of the reviewer on that. My feeling is that linking libxml2.so against the module itself might be more Fedora-ish than using LoadFile. And as this RPM is for Fedora specifically Are you set up with a FAS account and all that good stuff? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Additional Comments From [EMAIL PROTECTED] 2008-06-30 14:25 EST --- I have closed my bug as a duplicate of this one. Spec: http://rayvd.fedorapeople.org/mod_proxy_html/mod_proxy_html.spec SRPM: http://rayvd.fedorapeople.org/mod_proxy_html/mod_proxy_html-3.0.1-5.src.rpm Phil, feel free to use my spec and SRPM there. Would you be willing to add me as a co-maintainer on this once it is approved? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Additional Comments From [EMAIL PROTECTED] 2008-06-30 14:32 EST --- (In reply to comment #8) I'd like to get the opinion of the reviewer on that. My feeling is that linking libxml2.so against the module itself might be more Fedora-ish than using LoadFile. And as this RPM is for Fedora specifically Are you set up with a FAS account and all that good stuff? No, no account yet. I'll wait for an opinion of a reviewer. Yeah, loading it might be more Fedoraish, but that's not necessarily a good thing. Sometimes just having configs that move easily from one platform to another without changes is a bigger win. (In reply to comment #10) Phil, feel free to use my spec and SRPM there. Would you be willing to add me as a co-maintainer on this once it is approved? Sure, that would be fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
