[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||0.2.2-2.fc10
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Comment #14 from Fedora Update System upda...@fedoraproject.org  
2009-03-13 14:36:26 EDT ---
iax-0.2.2-2.fc10 has been pushed to the Fedora 10 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review



[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Comment #15 from Fedora Update System upda...@fedoraproject.org  
2009-03-13 14:39:21 EDT ---
iax-0.2.2-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems
still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|0.2.2-2.fc10|0.2.2-2.fc9




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs+




--- Comment #11 from Tom spot Callaway tcall...@redhat.com  2009-03-12 
16:33:38 EDT ---
New Package CVS Request
===
Package Name: iax
Short Description: Implementation of Inter-Asterisk eXchange protocol
Owners: spot
Branches: F-9 F-10 devel
InitialCC: 

... and it's done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Comment #12 from Fedora Update System upda...@fedoraproject.org  
2009-03-12 17:04:56 EDT ---
iax-0.2.2-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/iax-0.2.2-2.fc9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Comment #13 from Fedora Update System upda...@fedoraproject.org  
2009-03-12 17:05:01 EDT ---
iax-0.2.2-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/iax-0.2.2-2.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Comment #9 from manuel wolfshant wo...@nobugconsulting.ro  2009-03-07 
14:55:37 EDT ---
Orcan, the libtool file is not included in the binary package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #10 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-07 
16:30:54 EDT ---
Alright then. I wasn't sure.

--
This package (iax) is APPROVED by oget
--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||oget.fed...@gmail.com
 AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Comment #6 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-06 
14:16:12 EDT ---
ok, here are my notes:

- rpmlint says:
   iax-devel.x86_64: W: no-documentation
but there is not much we can do about it

- the patch is trivial but seems packaging specific. I leave it up to you to
send it upstream.

* I couldn't check the URL. It doesn't respond.

* I think the file iax-config.in needs sed'ded because it assumes the libdir to
be $prefix/lib/

? I suggest making use of the %name macro. Up to you

* You might want to kill the rpath

* Shouldn't the license field be GPL+ and LGPL+, because some source files are
GPL, some are LGPL?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Comment #7 from Tom spot Callaway tcall...@redhat.com  2009-03-06 
16:25:29 EDT ---

(In reply to comment #6)
 ok, here are my notes:
 
 - rpmlint says:
iax-devel.x86_64: W: no-documentation
 but there is not much we can do about it

Indeed.

 * I couldn't check the URL. It doesn't respond.

Fixed it to point to the download toplevel dir for iax.

 * I think the file iax-config.in needs sed'ded because it assumes the libdir 
 to
 be $prefix/lib/

You're right. Fixed in -2.

 ? I suggest making use of the %name macro. Up to you

I did it everywhere except the libiax.so references.

 * You might want to kill the rpath

I don't see any bad rpath... /usr/lib/rpm/check-rpaths says it is clean.

 * Shouldn't the license field be GPL+ and LGPL+, because some source files are
 GPL, some are LGPL?  

Good catch.

New Spec URL: http://auroralinux.org/people/spot/review/coccinella/iax.spec
New SRPM URL:
http://auroralinux.org/people/spot/review/coccinella/iax-0.2.2-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Comment #8 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-06 
16:40:42 EDT ---
Thanks. I saw this on the build.log

   /bin/sh ../libtool --mode=link gcc  -g -Wall -Wstrict-prototypes -I .
-DDEBUG_SUPPORT -DDEBUG_DEFAULT  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o
libiax.la -rpath /usr/lib64  iax.lo md5.lo
  ^^

I don't know how important this is but -rpath is passed to libtool here.

Can this be ignored?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454008


Till Maas [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #5 from Till Maas [EMAIL PROTECTED]  2008-08-08 06:33:17 EDT ---
There should be a comment about the status of your patch in the spec according
to:
https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2008-07-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iax - Implementation of Inter-Asterisk eXchange 
protocol


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Additional Comments From [EMAIL PROTECTED]  2008-07-29 10:23 EST ---
iax.spec.in is really irrelevant, as I'm not using or packaging the system
provided spec file (it really isn't any good).

I'm also not surprised that rpmbuild fails on Ubuntu, nor do I care if it 
works. :)

Thanks for the feedback.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2008-07-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iax - Implementation of Inter-Asterisk eXchange 
protocol


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Additional Comments From [EMAIL PROTECTED]  2008-07-28 18:04 EST ---
1. iax.spec.in still refers to the license as LGPL and breaks when I install and
build from the source RPM
2. FYI, my rpmbuild failed on Ubuntu (it could not find any .so packages to
install). It works on Fedora.

Comments

1. The package owns the directories and files it creates
2. ldconfig is run
3. %doc is used correctly
4. Header files and .so are in -devel 
5. Main package contains .so.version files
6. -devel package depends on main
7. Package does not contain any .la archives
8. Package does rm -rf %{buildroot} at the beginning of install
9. Package installs to DESTDIR

Balbir

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2008-07-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iax - Implementation of Inter-Asterisk eXchange 
protocol


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Additional Comments From [EMAIL PROTECTED]  2008-07-04 16:48 EST ---
Is it a problem that iax-client.h and iax.h are GPL and not LGPL?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2008-07-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iax - Implementation of Inter-Asterisk eXchange 
protocol


https://bugzilla.redhat.com/show_bug.cgi?id=454008





--- Additional Comments From [EMAIL PROTECTED]  2008-07-04 17:09 EST ---
Ehh, the License tag should be GPL+. My mistake.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2008-07-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iax - Implementation of Inter-Asterisk eXchange 
protocol


https://bugzilla.redhat.com/show_bug.cgi?id=454008


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||454010
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454008] Review Request: iax - Implementation of Inter-Asterisk eXchange protocol

2008-07-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iax - Implementation of Inter-Asterisk eXchange 
protocol


https://bugzilla.redhat.com/show_bug.cgi?id=454008


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||454022
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review