[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Comment #18 from Fedora Update System [EMAIL PROTECTED] 2008-09-24 20:10:55 EDT --- oggvideotools-0.5-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456603 Fedora Update System [EMAIL PROTECTED] changed: What|Removed |Added Resolution|RAWHIDE |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Comment #19 from Fedora Update System [EMAIL PROTECTED] 2008-09-24 20:18:51 EDT --- oggvideotools-0.5-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Comment #14 from Matt Domsch [EMAIL PROTECTED] 2008-08-12 09:44:21 EDT --- Package Change Request == Package Name: oggvideotools New Branches: EL-4 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Comment #15 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-12 13:20:14 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Comment #17 from Fedora Update System [EMAIL PROTECTED] 2008-08-12 18:59:03 EDT --- oggvideotools-0.5-1.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Comment #16 from Fedora Update System [EMAIL PROTECTED] 2008-08-12 18:58:26 EDT --- oggvideotools-0.5-1.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-07-29 02:31 EST --- Reassigning back as the review must remain assigned to the reviewer. And you should close it when the package is imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||0.4-1 Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2008-07-29 07:54 EST --- imported and built, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-07-28 03:37 EST --- For the C*FLAGS I think that you should use CXXFLAGS=$CXXFLAGS -Wall -std=c++0x instead of only CXXFLAGS=-Wall -std=c++0x. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Additional Comments From [EMAIL PROTECTED] 2008-07-28 04:49 EST --- OK source files match upstream: ae804223c15ac2ed39988bd82bd0996bb8c566f2 oggvideotools-0.4.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text included in package. OK latest version is being packaged. BAD BuildRequires are proper. BAD compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). BAD debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - you should add BR: libogg-devel, libtheora-devel, SDL-devel or is this intentional ??? - see my comment #4 for the flags, correct debuginfo depends on them too - the Patch: tags are using tabs instead of spaces -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Additional Comments From [EMAIL PROTECTED] 2008-07-28 12:07 EST --- Thanks for the review. Regarding the missing BRs - the package needs some autoconf/automake love, which I haven't had time to provide, nor am I an expert in such. I omitted them, because right now if they are present, it builds one extra (and IMHO useless) application, and has the bad side-effect of unnecessarily linking those libs into all the other executables it creates. I've spoken with the author on these points, and he isn't an autoconf/automake master either, so I would like to simply omit the extra BRs until such a time this is fixed upstream. I've fixed the tabs-as-spaces and CXXFLAGS in the spec I had posted, but I guess I didn't post the new srpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Additional Comments From [EMAIL PROTECTED] 2008-07-28 15:19 EST --- updated spec and SRPM posted at the above URLs. I wound up fixing up upstream's autotools breakage, and sent them the patches to include in the next version. Please complete review. Thanks, Matt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-28 16:14 EST --- All issues are fixed, so this package is APPROVED. But when you publish an updated package, you should increase the release too. It makes easier for the reviewer to track the changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-07-28 17:38 EST --- New Package CVS Request === Package Name: oggvideotools Short Description: Toolbox for manipulating Ogg video files Owners: mdomsch Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-29 00:02 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Additional Comments From [EMAIL PROTECTED] 2008-07-29 01:22 EST --- oggvideotools-0.4-1.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Additional Comments From [EMAIL PROTECTED] 2008-07-24 18:22 EST --- yes, I know it doesn't build in mock; I need to figure out how to get autoconf to run, as the one patch necessarily changes configure.ac. right now autoconf and autoreconf both fail. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456603] Review Request: oggvideotools - Toolbox for manipulating Ogg video files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oggvideotools - Toolbox for manipulating Ogg video files https://bugzilla.redhat.com/show_bug.cgi?id=456603 --- Additional Comments From [EMAIL PROTECTED] 2008-07-24 22:19 EST --- ok, I fixed it up so autoconf during build isn't needed, on F9 and rawhide at least. Please review the URLs noted above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
