[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 Daniel Berrange [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #8 from Daniel Berrange [EMAIL PROTECTED] 2008-10-03 11:57:28 EDT --- Built into rawhide.. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 --- Comment #7 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED] 2008-10-03 01:57:39 EDT --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 --- Comment #5 from Daniel Berrange [EMAIL PROTECTED] 2008-10-02 06:06:31 EDT --- Odd that it source tar.gz doesn't exist there - it is certainly supposed to. I'll change the URL to point to the alternate location indexed by author instead of by module. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 Daniel Berrange [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Daniel Berrange [EMAIL PROTECTED] 2008-10-02 06:07:41 EDT --- New Package CVS Request === Package Name: perl-Software-License Short Description: Package that provides templated software licenses Owners: berrange Branches: F-9 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Jason Tibbitts [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review+
--- Comment #4 from Jason Tibbitts [EMAIL PROTECTED] 2008-10-01 13:54:40 EDT
---
The Source: URL seems incorrect; at least, I get 404 when trying to download
it.
Not sure what's up there, but I found the package at:
http://search.cpan.org/CPAN/authors/id/R/RJ/RJBS/Software-License-%{version}.tar.gz
I don't see that this should hold up approval of this package, though; it may
simply be an error at CPAN. I guess you can switch to the more complicated URL
or bug CPAN to fix the issue; either way works for me, and if nothing changes
then the automated source-fetching report will start bugging you.
After fixing that:
* source files match upstream:
d5e2f5aca8813132eb3fd7306e56f0c9b2863625c7d545ab606c5b25d499b05d
Software-License-0.008.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
perl(Software::License) = 0.008
perl(Software::License::AGPL_3)
perl(Software::License::Apache_1_1)
perl(Software::License::Apache_2_0)
perl(Software::License::Artistic_1_0)
perl(Software::License::Artistic_2_0)
perl(Software::License::BSD)
perl(Software::License::FreeBSD)
perl(Software::License::GFDL_1_2)
perl(Software::License::GPL_1)
perl(Software::License::GPL_2)
perl(Software::License::GPL_3)
perl(Software::License::LGPL_2_1)
perl(Software::License::LGPL_3_0)
perl(Software::License::MIT)
perl(Software::License::Mozilla_1_0)
perl(Software::License::Mozilla_1_1)
perl(Software::License::Perl_5)
perl(Software::License::QPL_1_0)
perl(Software::License::Sun)
perl(Software::License::Zlib)
perl(Software::LicenseUtils)
perl-Software-License = 0.008-3.fc10
=
perl = 0:5.006
perl(:MODULE_COMPAT_5.10.0)
perl(Data::Section)
perl(Software::License::Artistic_1_0)
perl(Software::License::GPL_1)
perl(Sub::Install)
perl(Text::Template)
perl(base)
perl(strict)
perl(warnings)
* %check is present and all tests pass:
All tests successful.
Files=2, Tests=8, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.06 cusr 0.01
csys = 0.09 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED!
The package review process needs reviewers! If you haven't done any package
reviews recently, please consider doing one.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 --- Comment #3 from Daniel Berrange [EMAIL PROTECTED] 2008-09-20 14:07:10 EDT --- Updated package dropping the redundant Requires: tags http://berrange.fedorapeople.org/review/perl-Software-License/perl-Software-License-0.008-3.fc9.src.rpm Specfile in same URL as before -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 Chris Weyl [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #2 from Chris Weyl [EMAIL PROTECTED] 2008-09-13 04:21:48 EDT --- The explicit requires in the specfile should be dropped; they're duplicating the autogenerated requires: requires for perl-Software-License-0.008-2.fc9.noarch.rpm perl = 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(Data::Section) perl(Data::Section) = 0.000 perl(Software::License::Artistic_1_0) perl(Software::License::GPL_1) perl(Sub::Install) perl(Sub::Install) = 0.000 perl(Text::Template) perl(Text::Template) = 0.000 perl(base) perl(strict) perl(warnings) Scratch build looks good. == http://koji.fedoraproject.org/koji/taskinfo?taskID=824276 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 Bug 461307 depends on bug 461303, which changed state. Bug 461303 Summary: Review Request: perl-Data-Section - Read multiple hunks of data out of your DATA section https://bugzilla.redhat.com/show_bug.cgi?id=461303 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 --- Comment #1 from Daniel Berrange [EMAIL PROTECTED] 2008-09-06 06:29:42 EDT --- Updated SRPM to fix a missing BuildRequires, and fix description. Spec file at same URL as before http://berrange.fedorapeople.org/review/perl-Software-License/perl-Software-License-0.008-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 Daniel Berrange [EMAIL PROTECTED] changed: What|Removed |Added Depends on||461303 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
