[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Bug 462181 depends on bug 469972, which changed state. Bug 469972 Summary: Review Request: glfw - A portable framework for OpenGL https://bugzilla.redhat.com/show_bug.cgi?id=469972 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #18 from Lubomir Rintel lkund...@v3.sk 2009-01-08 10:13:49 EDT --- Imported; build pending. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #17 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:09:37 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Bug 462181 depends on bug 478581, which changed state. Bug 478581 Summary: Package Review: pnglite - A lightweight C library for loading PNG images https://bugzilla.redhat.com/show_bug.cgi?id=478581 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Simon Wesp cassmod...@fedoraproject.org changed: What|Removed |Added Depends on||469972 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Depends on||478581 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #13 from Simon Wesp cassmod...@fedoraproject.org 2009-01-01 17:55:25 EDT --- Spec: http://cassmodiah.fedorapeople.org/teeworlds-0.4.3/teeworlds.spec SRPM http://cassmodiah.fedorapeople.org/teeworlds-0.4.3/teeworlds-0.4.3-4.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462181
Lubomir Rintel lkund...@v3.sk changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #14 from Lubomir Rintel lkund...@v3.sk 2009-01-01 18:25:42 EDT
---
Well done,
APPROVED
Just a few notes, none of them blockers and can be addressed on import:
1.) please drop the first line from %description -- it duplicates Summary
2.) Do -data really have to depend on %{name}? Probably they are usable in
server-only installations?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462181
Simon Wesp cassmod...@fedoraproject.org changed:
What|Removed |Added
Flag||fedora-cvs?
--- Comment #15 from Simon Wesp cassmod...@fedoraproject.org 2009-01-01
19:17:53 EDT ---
(In reply to comment #14)
APPROVED
Thank you
1.) please drop the first line from %description -- it duplicates Summary
i removed it
2.) Do -data really have to depend on %{name}? Probably they are usable in
server-only installations?
ooops :-( I removed it
SPEC: http://cassmodiah.fedorapeople.org/teeworlds-0.4.3/teeworlds.spec
SRPM:
http://cassmodiah.fedorapeople.org/teeworlds-0.4.3/teeworlds-0.4.3-5.fc10.src.rpm
New Package CVS Request
===
Package Name: teeworlds
Short Description: A portable OpenGL framework
Owners: cassmodiah, lkundrak
Branches: F-10 F-9
InitialCC:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #16 from Lubomir Rintel lkund...@v3.sk 2009-01-01 19:34:01 EDT --- New Package CVS Request === Package Name: teeworlds Short Description: Online multi-player platform 2D shooter Owners: cassmodiah, lkundrak Branches: F-10 F-9 (Just correcting the short description) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #11 from Lubomir Rintel lkund...@v3.sk 2008-12-31 13:03:46 EDT --- (In reply to comment #10) would you patch out the internal libs/applications/dependencies? i can´t do that, because 1.) i can´t patch them out or/and 2.) i patch it out and the build or the application run failed, because the internals are modified or not compatible to the fedora supplied. So, in fact they did no local modifications (well, some windows-specific fixes to glfw, but they are of no interest to us). Please look into these: http://v3.sk/~lkundrak/teeworlds/ I added a patch for the external dependencies (it may have broken sound, but I can not verify that now :), and a line that patches the bamfile into using our compiler flags. I also made packages for pnglite and glfw. Unfortunately I had to make up sonames for both -- it can't be done right unless upstream does that. I'm wondering if you could take at least one of the two packages and submit them for review and maintain? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #12 from Simon Wesp cassmod...@fedoraproject.org 2008-12-31 17:27:03 EDT --- yeah, that rocks glfw is not relevant, its already in rawhide, but there are still some problems with this package and the maintainer won't include it in f-10. please don't ask me why! the pnglite is the one that is missing. please open a review for pnglite -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Bug 462181 depends on bug 469492, which changed state. Bug 469492 Summary: Review Request: bam - A fast and flexible build system https://bugzilla.redhat.com/show_bug.cgi?id=469492 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #10 from Simon Wesp [EMAIL PROTECTED] 2008-11-07 03:57:44 EDT --- okay, we finished bam, but it is not builded yet. i will build it today or tomorrow. would you patch out the internal libs/applications/dependencies? i can´t do that, because 1.) i can´t patch them out or/and 2.) i patch it out and the build or the application run failed, because the internals are modified or not compatible to the fedora supplied. perhaps you can fix it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Simon Wesp [EMAIL PROTECTED] changed: What|Removed |Added Depends on||469492 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #8 from Simon Wesp [EMAIL PROTECTED] 2008-10-29 13:17:59 EDT --- not really :-/ please don´t be angry with me. I try my best, but it´s not very easy. I hope I´m not on the wrong track.. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #9 from Lubomir Rintel [EMAIL PROTECTED] 2008-10-29 13:52:10 EDT --- (In reply to comment #8) not really :-/ please don´t be angry with me. I try my best, but it´s not very easy. I hope I´m not on the wrong track.. No problem. Just a reminder -- any time you need help feel free to ask. And posting work-in-progress (even unfinished, unrunnable or uncompilable) packages can get you early reviews :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #7 from Lubomir Rintel [EMAIL PROTECTED] 2008-10-27 05:14:02 EDT --- (In reply to comment #6) i spoke with upstream teeworlds 0.5 will be released in a few weeks bam is up to now unversioned. with teeworlds 0.5 bam will be versioned. perhaps we should really start with 0.5? what do you mean? We have communicated this via IRC with result Package anything that works :) Any progress here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #6 from Simon Wesp [EMAIL PROTECTED] 2008-10-17 10:16:16 EDT --- i spoke with upstream teeworlds 0.5 will be released in a few weeks bam is up to now unversioned. with teeworlds 0.5 bam will be versioned. perhaps we should really start with 0.5? what do you mean? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #5 from Simon Wesp [EMAIL PROTECTED] 2008-10-16 11:47:11 EDT --- pong was on vacation. now i'm back and fighting with bam :-( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #4 from Lubomir Rintel [EMAIL PROTECTED] 2008-10-03 06:15:51 EDT --- Ping. Is there any progress on this? Do you need any help with this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #2 from Lubomir Rintel [EMAIL PROTECTED] 2008-09-28 03:41:43 EDT --- Hi! I did package teewars (at the time it had a bad license so I never submitted it into fedora). Here's my package, in case you'll be interested in it (Unfortunately I lost the bam package): http://netbsd.sk/~lkundrak/teewars/ (In reply to comment #1) Some ideas: - exclude bam in an extra package - replace lua included in bam with lua from the fedora - replace zlib included in teeworlds with zlib from the fedora - replace wavpack included in teeworlds with wavpack from the fedora - replace portaudio included in teeworlds with portaudio from the fedora - create pnglite[2] as extra package and include it as dependency - create glfw[3] as extra package and include it as dependency please give me feedback! ^^^ I consider all of these to be good ideas. Please go ahead and do that. Feel free to ask if you need any help (e.g. packing and/or with reviewing of the dependencies). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462181
--- Comment #3 from Lubomir Rintel [EMAIL PROTECTED] 2008-09-28 03:52:07 EDT
---
1.) Sane description
Please remove the first line of %description, you duplicate Summary:
2.) Dependencies on data package
Shouldn't dependencies of data package on code and vice versa be versioned?
3.) Please do not do the following:
find -name '*.c' -o -name '*.cpp' -exec sed -i 's:data/:%{_datadir}/%{name}/:g'
datasrc/data.ds {} \;
Replace that with a patch.
4.) Preserving a timestamp of readme.txt while doing the conversion to utf8
might be a good idea.
5.) Use macros consistently
Replace %{buildroot} with $RPM_BUILD_ROOT (or the reverse).
6.) Launch server with server icon, and client with client icon
You seem to have reversed the contents of the .desktop files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Lubomir Rintel [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #1 from Simon Wesp [EMAIL PROTECTED] 2008-09-18 12:30:55 EDT --- updated SPEC to 0.4.3-2 Spec URL: http://cassmodiah.fedorapeople.org/teeworlds-0.4.3/teeworlds.spec SRPM URL: http://cassmodiah.fedorapeople.org/teeworlds-0.4.3/teeworlds-0.4.3-2.fc9.src.rpm I added Teeworlds as License [1] Some ideas: - exclude bam in an extra package - replace lua included in bam with lua from the fedora - replace zlib included in teeworlds with zlib from the fedora - replace wavpack included in teeworlds with wavpack from the fedora - replace portaudio included in teeworlds with portaudio from the fedora - create pnglite[2] as extra package and include it as dependency - create glfw[3] as extra package and include it as dependency please give me feedback! ^^^ [1] https://www.redhat.com/archives/fedora-legal-list/2008-September/msg00019.html [2] http://www.karlings.com/~danne/pnglite/ [3] http://glfw.sourceforge.net/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
