[Bug 462250] Review Request: Pmw - python megawidgets
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462250
--- Comment #5 from Tim Fenn [EMAIL PROTECTED] 2008-10-03 23:23:31 EDT ---
(In reply to comment #4)
For 1.3.2-2:
* URL
- I think http://pmw.sourceforge.net/ is better for URL
* SourceURL
- For tarball on sourceforge.net please refer to
https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
done.
* %prep
---
%setup -q -n Pmw.1.3.2/src
---
- After rebuilding the directory Pmw.1.3.2/src under %_builddir
But it leaved Pmw.1.3.2 directory undeleted, which is not
right.
%setup directory (relative to %_builddir) must not contain
any slash.
fixed.
* License
--- Some files under src/Pmw/Pmw_1_3/contrib/ are under GPLv2+
--- Others are under MIT (from src/Pmw/Pmw_1_3/doc/copyright.html)
- So the license tag should be MIT and GPLv2+.
fixed.
* %clean, %install
- %clean section is empty
See https://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
MUST: Each package must have a %clean section,
- Also %install does not contain any cleaning line.
fixed.
* Directory ownership issue
- The directory %{python_sitelib}/ itself is owned by python and
should not be owned by this rpm.
fixed.
* Documents
- As license information is in src/Pmw/Pmw_1_3/doc/copyright.html
at least this file should be included in %doc.
I guess
-
%doc src/Pmw/Pmw_1_3/doc/
-
is better.
done.
I also fixed the egg-info packaging according to
https://fedoraproject.org/wiki/Packaging/Python/Eggs.
spec url: http://www.stanford.edu/~fenn/packs/python-pmw.spec
srpm url: http://www.stanford.edu/~fenn/packs/python-pmw-1.3.2-3.f8.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462250] Review Request: Pmw - python megawidgets
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462250
--- Comment #4 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-02 12:16:33 EDT
---
For 1.3.2-2:
* URL
- I think http://pmw.sourceforge.net/ is better for URL
* SourceURL
- For tarball on sourceforge.net please refer to
https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
* %prep
---
%setup -q -n Pmw.1.3.2/src
---
- After rebuilding the directory Pmw.1.3.2/src under %_builddir
But it leaved Pmw.1.3.2 directory undeleted, which is not
right.
%setup directory (relative to %_builddir) must not contain
any slash.
%build
%install
rm -rf
* License
--- Some files under src/Pmw/Pmw_1_3/contrib/ are under GPLv2+
--- Others are under MIT (from src/Pmw/Pmw_1_3/doc/copyright.html)
- So the license tag should be MIT and GPLv2+.
* %clean, %install
- %clean section is empty
See https://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
MUST: Each package must have a %clean section,
- Also %install does not contain any cleaning line.
https://fedoraproject.org/wiki/Packaging/Guidelines#PreppingBuildRootForInstall
* Directory ownership issue
- The directory %{python_sitelib}/ itself is owned by python and
should not be owned by this rpm.
* Documents
- As license information is in src/Pmw/Pmw_1_3/doc/copyright.html
at least this file should be included in %doc.
I guess
-
%doc src/Pmw/Pmw_1_3/doc/
-
is better.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462250] Review Request: Pmw - python megawidgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462250 --- Comment #3 from Tim Fenn [EMAIL PROTECTED] 2008-10-01 19:32:53 EDT --- Sorry for the late reply, I'm away from home and with a rather spotty connection. (In reply to comment #1) Some notes. * Build failure - Your srpm does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=843287 * At least python is needed for BuildRequires * Also even after python is added to BuildRequires the build fails (on F-9+) like: error: Installed (but unpackaged) file(s) found: /usr/lib/python2.5/site-packages/Pmw-1.3.2-py2.5.egg-info Fixed. * Redundant definition macro - %python_sitearch is used nowhere - Also it is not needed to define %version, %release macro explicitly. * Source URL - %SOURCE must be written with full URL: https://fedoraproject.org/wiki/Packaging/SourceURL Fixed. * The line - [ $RPM_BUILD_ROOT != / ] rm -rf $RPM_BUILD_ROOT - - is not needed. You define $RPM_BUILD_ROOT. Fixed. * Also I think this srpm should be named as python-pmw: Done. spec url: http://www.stanford.edu/~fenn/packs/python-pmw.spec srpm url: http://www.stanford.edu/~fenn/packs/python-pmw-1.3.2-2.f8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462250] Review Request: Pmw - python megawidgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462250 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-26 03:01:01 EDT --- Some notes. * Build failure - Your srpm does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=843287 * At least python is needed for BuildRequires * Also even after python is added to BuildRequires the build fails (on F-9+) like: error: Installed (but unpackaged) file(s) found: /usr/lib/python2.5/site-packages/Pmw-1.3.2-py2.5.egg-info RPM build errors: user fenn does not exist - using root Installed (but unpackaged) file(s) found: /usr/lib/python2.5/site-packages/Pmw-1.3.2-py2.5.egg-info - * Redundant definition macro - %python_sitearch is used nowhere - Also it is not needed to define %version, %release macro explicitly. * Source URL - %SOURCE must be written with full URL: https://fedoraproject.org/wiki/Packaging/SourceURL * The line - [ $RPM_BUILD_ROOT != / ] rm -rf $RPM_BUILD_ROOT - - is not needed. You define $RPM_BUILD_ROOT. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462250] Review Request: Pmw - python megawidgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462250 --- Comment #2 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-26 03:25:30 EDT --- * Also I think this srpm should be named as python-pmw: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462250] Review Request: Pmw - python megawidgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462250 Itamar Reis Peixoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Alias||Pmw -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462250] Review Request: Pmw - python megawidgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462250 Tim Fenn [EMAIL PROTECTED] changed: What|Removed |Added Summary|Pmw - python megawidgets|Review Request: Pmw - ||python megawidgets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462250] Review Request: Pmw - python megawidgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462250 Tim Fenn [EMAIL PROTECTED] changed: What|Removed |Added Blocks|435018 |177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
