[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag||needinfo?(bl...@verdurin.co ||m) --- Comment #15 from Jason Tibbitts ti...@math.uh.edu 2009-11-08 14:01:28 EDT --- Was there ever a decision as to whether this ticket would be pursued? It's been a month since comment #14, so I guess I'll go ahead and close this soon if there's no further activity. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 Adam Huffman bl...@verdurin.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG Flag|needinfo?(bl...@verdurin.co | |m) | --- Comment #16 from Adam Huffman bl...@verdurin.com 2009-11-08 14:55:35 EDT --- Yes - I'd rather expend my energy on actively maintained packages. Thanks for the efforts of the reviewers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 --- Comment #14 from Thomas Janssen thom...@fedoraproject.org 2009-10-07 06:06:31 EDT --- If you still want it, you could try to ask upstream if they're still alive :) If they gave up you could become upstream ;) Question is, is it worth. But that's up to you. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 Thomas Janssen thom...@fedoraproject.org changed: What|Removed |Added CC||thom...@fedoraproject.org Flag||needinfo?(bl...@verdurin.co ||m) --- Comment #12 from Thomas Janssen thom...@fedoraproject.org 2009-10-04 05:45:00 EDT --- Ping? -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 Adam Huffman bl...@verdurin.com changed: What|Removed |Added Flag|needinfo?(bl...@verdurin.co | |m) | --- Comment #13 from Adam Huffman bl...@verdurin.com 2009-10-04 06:46:24 EDT --- As far as I can tell, the upstream project is inactive - no commits since August 2008. Wondering whether it's worth persisting? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 Juha Tuomala t...@iki.fi changed: What|Removed |Added URL||http://pyroman.alioth.debia ||n.org/ CC||t...@iki.fi Alias||pyroman -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463035
--- Comment #11 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04
01:30:36 EDT ---
Phew, it's been 6 months. This was one of my first reviews and I barely
remember it.
Anyway, since then, there were some changes in the guidelines too. I had a
quick look at the package:
* The problem that I reported before remains:
When I run the pyroman script I get the error:
No rule files found in directory './examples/base'!
I think you need to change the default_rules_path in the launching script (to
%{_sysconfdir}/%name via 'sed', for instance).
* Please make use of the %{name} macro in %install
* Please use the -p switch of install extensively, to preserve timestamps.
* %setup -q -n %{name}-%{version}
is not necessary.
%setup -q
should be enough
* We certainly don't want
%define _unpackaged_files_terminate_build 0
* The new guidelines suggest that, In the first line, %define should be
replaced by %global
? Where does SOURCE1 come from? Why the name fedora.init ?
! You probably don't need
cp -p %SOURCE1 .
because you can use
install -pm 0755 %{SOURCE1} %{buildroot}/%{_initrddir}/%{name}
in the %install section.
* Also there are two rpmlints that deserve attention:
pyroman.noarch: W: service-default-enabled /etc/rc.d/init.d/pyroman
pyroman.noarch: W: incoherent-subsys /etc/rc.d/init.d/pyroman $prog
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 --- Comment #10 from Adam Huffman bl...@verdurin.com 2009-03-23 12:05:48 EDT --- That's very true. I've put up a new version with my first attempt at an initscript - comments welcome as there's probably something wrong with it. http://verdurin.fedorapeople.org/review/pyroman/pyroman-0.4.6-3.fc10.src.rpm http://verdurin.fedorapeople.org/review/pyroman/pyroman.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 --- Comment #9 from Jussi Lehtola jussi.leht...@iki.fi 2009-03-20 15:53:51 EDT --- ping, it's been more than a week :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 Adam Huffman bl...@verdurin.com changed: What|Removed |Added Flag|needinfo?(bl...@verdurin.co | |m) | --- Comment #8 from Adam Huffman bl...@verdurin.com 2009-01-25 17:33:21 EDT --- I've got an initscript for the package now but it needs more testing. Will upload a new version next week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(bl...@verdurin.co ||m) --- Comment #7 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-24 11:05:01 EDT --- Setting NEEDINFO. Adam, ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 Gratien D'haese gratien.dha...@it3.be changed: What|Removed |Added CC||gratien.dha...@it3.be --- Comment #6 from Gratien D'haese gratien.dha...@it3.be 2009-01-23 04:06:59 EDT --- what is the current status? Will you release a new version of the package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 --- Comment #5 from Adam Huffman [EMAIL PROTECTED] 2008-11-16 15:08:48 EDT --- Am working on another package which needs a partial rewrite - will get back to this one once that's done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 --- Comment #4 from Orcan 'oget' Ogetbil [EMAIL PROTECTED] 2008-11-13 16:08:26 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 --- Comment #3 from Orcan Ogetbil [EMAIL PROTECTED] 2008-10-09 23:38:33 EDT --- Thank you for the update. The package is in better shape now. Just figure out what to do with the rules files and the package will be good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463035 --- Comment #2 from Adam Huffman [EMAIL PROTECTED] 2008-10-08 19:37:59 EDT --- Thanks for having a look. I've addressed most of your comments, though not yet the problem with the rulesets. I need to think about how best to handle both the built-in rules and those the user creates. Probably I'll adapt what's in the Debian package, as noted in https://bugzilla.redhat.com/show_bug.cgi?id=454220#c36 New versions at: http://verdurin.fedorapeople.org/review/pyroman/pyroman.spec http://verdurin.fedorapeople.org/review/pyroman/pyroman-0.4.6-2.fc10.src.rpm Once I've a working fix for the rule handling, I'll upload a new version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463035] Review Request: pyroman - Very fast firewall configuration tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463035
Orcan Ogetbil [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #1 from Orcan Ogetbil [EMAIL PROTECTED] 2008-10-06 20:32:13 EDT
---
Hi, I just went through your package. It needs some work. Here are my notes:
-
The summary needs to be beefed up and more informative IMHO.
-
When I run the pyroman script I get the error:
No rule files found in directory './examples/base'!
I think you need to change the default_rules_path in the launching script (to
%{_sysconfdir}/%name via 'sed', for instance).
---
In the %files section, we prefer to use
%defattr(-, root, root, -)
Also
%attr(0644, root, root)
are redundant. Instead you should use
install -pm 644 pyroman/* $RPM_BUILD_ROOT/%{python_sitelib}/%{name}/
and
install -Dpm 644 doc/pyroman.8 $RPM_BUILD_ROOT/%{_mandir}/man8/pyroman.8
in the %install section. Also make sure you use the switch -p of the install
command to preserve the timestamps whenever it makes sense (usually for the
non-compiled files).
-
License is MIT, not GPL
-
BuildRequires: python-devel
is redundant. Package will build without it.
Requires: python
is not necessary either. rpmbuild will pick that up.
-
You can further replace
dir %{python_sitelib}/%{name}/
%{python_sitelib}/%{name}/*.py*
with
%{python_sitelib}/%{name}
to improve the spec file.
-
Make sure you make use of %{name} and %{version} macros in addition to the
predefined directory macros.
For instance, you use
install -D bin/pyroman $RPM_BUILD_ROOT/usr/sbin/pyroman
in one line but
%{_sbindir}/%{name}
on the other, which is inconsistent and not desired.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
