[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 David Lutterkort lut...@redhat.com changed: What|Removed |Added AssignedTo|lut...@redhat.com |nob...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 David Lutterkort lut...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE AssignedTo|nob...@fedoraproject.org|lut...@redhat.com --- Comment #8 from David Lutterkort lut...@redhat.com 2009-09-25 18:27:40 EDT --- Closed, since it's been done for a while -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 David Lutterkort [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review+ --- Comment #5 from David Lutterkort [EMAIL PROTECTED] 2008-10-15 15:21:23 EDT --- Looks good now APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi [EMAIL PROTECTED] 2008-10-15 17:53:27 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 Bryan Kearney [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Bryan Kearney [EMAIL PROTECTED] 2008-10-15 15:32:47 EDT --- New Package CVS Request === Package Name: ace Short Description: Appliance Configuration Engine Owners: bkearney Branches: F-9 F10 InitialCC: None -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 --- Comment #4 from Bryan Kearney [EMAIL PROTECTED] 2008-10-02 15:08:28 EDT --- Per a comment from Bill Nottingham, I have moved all ace-* modules into a subpackge. The chaneged srpm and spec file are below: Spec URL: http://bkearney.fedorapeople.org/ace.spec SRPM URL: http://bkearney.fedorapeople.org/ace-0.0.3-4.fc9.src.rpm rpmlint is clean builds in koji on f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=857555 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 --- Comment #3 from Bryan Kearney [EMAIL PROTECTED] 2008-09-24 09:25:13 EDT --- Thank you both for the comments. I have made the changes and uploaded the new files. Spec URL: http://bkearney.fedorapeople.org/ace.spec SRPM URL: http://bkearney.fedorapeople.org/ace-0.0.3-3.fc9.src.rpm rmlint clean builds clean in koji for f9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 David Lutterkort [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463226
--- Comment #1 from David Lutterkort [EMAIL PROTECTED] 2008-09-23 15:02:18
EDT ---
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - License files are installed as %doc
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
FIX - BuildRoot value (one of the recommended values)
Use one of the values listed here:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
OK - PreReq not used
FIX - Source md5sum matches upstream
tarball is not available upstream; since you are upstream, you should
publish a tarball for every release
FIX - No hardcoded pathnames
instead of binHome, use %{_bindir}
instead of initHome, use %{_initrddir}
instead of /usr/share in aceHome use %{_datadir}
would prefer macro 'rubySiteHome' is called 'ruby_sitelibdir' for conistency
OK - Package owns all the files it installs
OK - 'Requires' create needed unowned directories
OK - Package builds successfully on i386 and x86_64 (mock)
OK - BuildRequires sufficient
OK - File permissions set properly
FIX - Macro usage is consistent
use install -p or cp -pr instead of %{__cp} -R
OK - rpmlint is silent
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463226] Review Request: Appliance Configuration Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463226 --- Comment #2 from Bill Nottingham [EMAIL PROTECTED] 2008-09-23 16:17:17 EDT --- chckonfig usage is completely broken. Please see examples @ http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
