[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 Marcela Maslanova [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi [EMAIL PROTECTED] 2008-10-01 15:02:30 EDT --- cvs done. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 --- Comment #6 from Marcela Maslanova [EMAIL PROTECTED] 2008-09-29 05:01:10 EDT --- New Package CVS Request === Package Name: perl-Module-Math-Depends Short Description: convenience object for manipulating module dependencies Owners: mmaslano Branches: rawhide InitialCC: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #5 from Kevin Fenzi [EMAIL PROTECTED] 2008-09-28 15:17:14 EDT --- The Summary/Short Description here is weird... that says where this module came from, but nothing about what it does. Could you revise that so it makes more sense? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 --- Comment #3 from Marcela Maslanova [EMAIL PROTECTED] 2008-09-25 06:05:23 EDT --- http://mmaslano.fedorapeople.org/perl-Module-Math-Depends/perl-Module-Math-Depends.spec http://mmaslano.fedorapeople.org/perl-Module-Math-Depends/perl-Module-Math-Depends-0.02-2.fc9.src.rpm fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 Matej Cepl [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs+ |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 Marcela Maslanova [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 --- Comment #4 from Marcela Maslanova [EMAIL PROTECTED] 2008-09-25 06:07:59 EDT --- New Package CVS Request === Package Name: perl-Module-Math-Depends Short Description: module originaly created for Module::Inspector Owners: [EMAIL PROTECTED] Branches: rawhide InitialCC: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 Marcela Maslanova [EMAIL PROTECTED] changed: What|Removed |Added Blocks||463763 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 Matej Cepl [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463770 --- Comment #2 from Matej Cepl [EMAIL PROTECTED] 2008-09-24 15:55:31 EDT --- Created an attachment (id=317619) -- (https://bugzilla.redhat.com/attachment.cgi?id=317619) patch against the .spec file fixing the issues -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463770] Package review: perl-Module-Math-Depends
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463770
Matej Cepl [EMAIL PROTECTED] changed:
What|Removed |Added
Flag||fedora-cvs+
--- Comment #1 from Matej Cepl [EMAIL PROTECTED] 2008-09-24 15:54:39 EDT ---
- BAD: rpmlint must be run on every package. The output should be posted in the
review.
src.rpm:
[EMAIL PROTECTED] redhat]$ rpmlint -i
SRPMS/perl-Module-Math-Depends-0.02-1.fc9.src.rpm
perl-Module-Math-Depends.src: W: spelling-error-in-description seperately
separately
You made a misspelling in the Description. Please double-check.
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
+ MUST: The package is named according to the Package Naming Guidelines .
+ MUST: The spec file name matches the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming Guidelines
.
- BAD: The package meets the Packaging Guidelines .
* https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs
there is no email address in %changelog -- all required formats of the
changelog record include email address
+ MUST: The package is licensed with a Fedora approved license and meet the
Licensing Guidelines .
+ MUST: The License field in the package spec file matches the actual license.
+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
+ MUST: The spec file is written in American English.
+ MUST: The spec file for the package MUST be legible.
+ MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
35270e730764371ee9fb3be536744a32 Module-Math-Depends-0.02.tar.gz
+ MUST: The package successfully compiles and build into binary rpms on at
least one supported architecture.
Koji scratch build is
http://koji.fedoraproject.org/koji/taskinfo?taskID=842644
+ MUST: noarch, so it compiles everywhere.
+ MUST: All build dependencies are listed in BuildRequires.
+ MUST: The spec file MUST handle locales properly.
No locale support.
+ MUST: no libraries
+ MUST: not relocatable
+ MUST: A package owns all directories that it creates.
Follows perl guidelines.
+ MUST: A package must not contain any duplicate files in the %files listing.
+ MUST: Permissions on files must be set properly.
+ MUST: Each package have a %clean section.
+ MUST: Each package consistently use macros.
+ MUST: The package contains code, or permissable content.
+ MUST: No large documentation files, so no a -doc subpackage.
+ MUST: If a package includes something as %doc, it does not affect the runtime
of the application.
+ MUST: No header files.
+ MUST: No static libraries.
+ MUST: No pkgconfig(.pc) files.
+ MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
+ MUST: No devel packages.
+ MUST: No .la libtool archives.
+ MUST: Packages does not contain GUI applications.
+ MUST: Packages does not own files or directories owned by other packages.
+ MUST: Runs rm -rf $RPM_BUILD_ROOT in %install
+ MUST: All filenames in rpm packages are valid UTF-8.
+ SHOULD: Includes license text.
Attaching patch for the SPEC file -- when this is applied, APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
