[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #11 from Richard W.M. Jones rjo...@redhat.com 2008-12-21 06:32:07 EDT --- Thanks Peter and Kevin. Imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi ke...@tummy.com 2008-12-20 23:26:07 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||pbrobin...@gmail.com AssignedTo|nob...@fedoraproject.org|pbrobin...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467329
--- Comment #6 from Peter Robinson pbrobin...@gmail.com 2008-12-19 04:52:13
EDT ---
The same issue with the license
+ rpmlint output
rpmlint -i mingw32-termcap-1.3.1-4.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
- %doc includes license file
license file not included in rpm
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
ffe6f86e63a3a29fa53ac645faaabdfa termcap-1.3.1.tar.gz
+ package successfully builds on at least one architecture
tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
Optional:
+ if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 --- Comment #7 from Richard W.M. Jones rjo...@redhat.com 2008-12-19 05:27:08 EDT --- Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/termcap/mingw32-termcap.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-termcap-1.3.1-5.fc10.src.rpm * Fri Dec 19 2008 Richard W.M. Jones rjo...@redhat.com - 1.3.1-5 - Added license file to doc section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Peter Robinson pbrobin...@gmail.com 2008-12-19 05:38:18 EDT --- APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Richard W.M. Jones rjo...@redhat.com 2008-12-19 05:48:04 EDT --- New Package CVS Request === Package Name: mingw32-termcap Short Description: MinGW terminal feature database Owners: rjones berrange lfarkas Branches: EL-5 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 --- Comment #5 from Richard W.M. Jones [EMAIL PROTECTED] 2008-12-10 11:24:44 EDT --- Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/termcap/mingw32-termcap.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-termcap-1.3.1-4.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Bug 467329 depends on bug 454410, which changed state. Bug 454410 Summary: Review Request: mingw32-gcc - MinGW Windows cross-compiler (GCC) for C and C++ https://bugzilla.redhat.com/show_bug.cgi?id=454410 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Bruno Haible [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #3 from Bruno Haible [EMAIL PROTECTED] 2008-11-02 06:05:38 EDT --- All free Unices abandoned termcap in favour of ncurses between 1992 and 1995. Reason: tgetent() is inherently unsafe to use, it is designed to produce buffer overflows, because the caller of this function and the implementation of this function simply don't communicate about the size of the buffer. It'd best to ditch this package, and use ncurses instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 --- Comment #4 from Richard W.M. Jones [EMAIL PROTECTED] 2008-11-02 06:54:15 EDT --- Ncurses doesn't compile on Windows, although if you do manage to patch it and get a working ncurses, please post it because that would be a very important advance for us. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Richard W.M. Jones [EMAIL PROTECTED] changed: What|Removed |Added Blocks||467398 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 --- Comment #2 from Richard W.M. Jones [EMAIL PROTECTED] 2008-10-31 09:58:09 EDT --- Spec URL: http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=06642864def98e59c07661b91e0b58d0b1b25723;path=/termcap/ SRPM URL: http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-termcap-1.3.1-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Richard W.M. Jones [EMAIL PROTECTED] changed: What|Removed |Added Blocks||467399 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467329] Review Request: mingw32-termcap - MinGW terminal feature database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467329 Richard W.M. Jones [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Depends on||454410 Alias||mingw32-termcap --- Comment #1 from Richard W.M. Jones [EMAIL PROTECTED] 2008-10-16 16:54:35 EDT --- Note that there is no native version of this package (it was dropped in Fedora 9 era). However we need it because there is no termcap in the Win32 API. Also note the license really is GPL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
