[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Simon Schampijer si...@schampijer.de changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #21 from Simon Schampijer si...@schampijer.de  2009-03-06 
08:11:06 EDT ---
@Kevin - yup I only wanted to have a devel branch, thanks for the quick
handling 

The rpm built fine - so i am going to close this ticket.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #20 from Kevin Fenzi ke...@tummy.com  2009-03-05 15:47:03 EDT ---
I assume you only want a devel branch? 

cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Simon Schampijer si...@schampijer.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Comment #13 from Simon Schampijer si...@schampijer.de  2009-03-04 
06:40:18 EDT ---
SPEC URL: http://shell.sugarlabs.org/~erikos/sugar-read.spec
SRPM URL: http://shell.sugarlabs.org/~erikos/sugar-read-65-1.fc10.src.rpm

Built fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=1219708

Added evince and gnome-python-desktop to the spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642





--- Comment #14 from Peter Robinson pbrobin...@gmail.com  2009-03-04 07:12:48 
EDT ---
The gnome-python requirement will actually need to be the specific sub
components so it doesn't pull the whole gnome-python stack and its dependencies
which are massive. 

So the minimum would be gnome-python2-evince and the other components it uses.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642





--- Comment #15 from Simon Schampijer si...@schampijer.de  2009-03-04 
08:57:10 EDT ---
Thanks. Updated the spec to require gnome-python2-evince. I guess I do not need
to specifically list evince as requirement since this is dragged in by
gnome-python2-evince

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-review?




--- Comment #16 from Peter Robinson pbrobin...@gmail.com  2009-03-04 09:09:31 
EDT ---
Going to do the review now. Just a side note that each change should increment
the build and add Changelog entry.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #17 from Peter Robinson pbrobin...@gmail.com  2009-03-04 10:10:34 
EDT ---
APPROVED

+ rpmlint output

$ rpmlint -i /home/perobinson/rpmbuild/SRPMS/sugar-read-65-1.fc10.src.rpm
sugar-read.src: W: non-standard-group Sugar/Activities
The value of the Group tag in the package is not valid.  Valid groups are:
Amusements/Games, Amusements/Graphics, Applications/Archiving,
Applications/Communications, Applications/Databases,
Applications/Editors, Applications/Emulators, Applications/Engineering,
Applications/File, Applications/Internet, Applications/Multimedia,
Applications/Productivity, Applications/Publishing, Applications/System,
Applications/Text, Development/Debug, Development/Debuggers,
Development/Languages, Development/Libraries, Development/System,
Development/Tools, Documentation, System Environment/Base, System
Environment/Daemons, System Environment/Kernel, System
Environment/Libraries, System Environment/Shells, User
Interface/Desktops, User Interface/X, User Interface/X Hardware Support.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license

+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  3a7c7cc764e139691a7f57c16cd6433c  Read-65.tar.bz2
+ package successfully builds on at least one architecture
  tested using koji scratch build
+ BuildRequires list all build dependencies
+ %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642





--- Comment #19 from Simon Schampijer si...@schampijer.de  2009-03-04 
12:05:08 EDT ---
@peter: thanks very much for the review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Simon Schampijer si...@schampijer.de changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #18 from Simon Schampijer si...@schampijer.de  2009-03-04 
12:04:26 EDT ---
New Package CVS Request
===
Package Name: sugar-read
Short Description: A document reader for Sugar
Owners: erikos sdz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-03-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|pbrobin...@gmail.com




--- Comment #12 from Peter Robinson pbrobin...@gmail.com  2009-03-02 07:10:27 
EDT ---
Hi Fabian, have you had any luck with an updated srpm?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Simon Schampijer si...@schampijer.de changed:

   What|Removed |Added

 CC||si...@schampijer.de




--- Comment #8 from Simon Schampijer si...@schampijer.de  2009-02-13 04:04:15 
EDT ---
mbarnes rebuilt it a few days ago since it was broken - should be good to go
now. Anything that is missing spec wise now for getting this in?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642





--- Comment #9 from Simon Schampijer si...@schampijer.de  2009-02-13 04:09:49 
EDT ---
Latest 0.84 version for read is 63
http://download.sugarlabs.org/sources/sucrose/fructose/Read/Read-63.tar.bz2 

Building Read depending on the latest evince would only work for rawhide of
course.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642





--- Comment #10 from Fabian Affolter fab...@bernewireless.net  2009-02-13 
04:14:21 EDT ---
I will update the spec file and post a new SRPM.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642





--- Comment #11 from Peter Robinson pbrobin...@gmail.com  2009-02-13 07:01:52 
EDT ---
 Building Read depending on the latest evince would only work for rawhide of
 course.

Yes, but sugar-evince was never in the rest of Fedora mainline anyway so it
shouldn't cause any issues, except it will only be supported on F11 and later.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-02-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 CC||pbrobin...@gmail.com




--- Comment #6 from Peter Robinson pbrobin...@gmail.com  2009-02-06 11:29:06 
EDT ---
Looking at the spec file should there not be a Requires: evince and
gnome-python-desktop?

I believe there needs to be a gnome-python2-evince and I've also filed a bug to
have the evince libs split out into a sub package as I don't belive sugar-read
needs any of the evice gui but rather just the libraries and python binaries.
The bug is RHBZ 480729

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-02-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642





--- Comment #7 from Peter Robinson pbrobin...@gmail.com  2009-02-06 11:33:13 
EDT ---
gnome-python2-evince is in rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Tomeu Vizoso to...@sugarlabs.org changed:

   What|Removed |Added

 CC||to...@sugarlabs.org




--- Comment #5 from Tomeu Vizoso to...@sugarlabs.org  2009-02-04 10:19:45 EDT 
---
evince 2.25.90 and gnome-python-desktop 2.25.90 have been released and would be
enough to run sugar-read. sugar-evince is not needed any more as has been
completely upstreamed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2009-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

  Status Whiteboard||NotReady




--- Comment #3 from Jason Tibbitts ti...@math.uh.edu  2009-01-09 12:32:56 EDT 
---
What's the current status of this package? If it doesn't actually work then
there's not much point in reviewing it, so I'll mark it as not being ready for
review.  Please clear the whiteboard when the situation changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2008-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642





--- Comment #1 from Jeremy Katz [EMAIL PROTECTED]  2008-10-20 08:53:09 EDT ---
Does this activity work?  I was under the impression that evince changes are
required for sugar-read

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467642] Review Request: sugar-read - PDF reader for Sugar

2008-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467642


Peter Robinson [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 Blocks||462625




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review