[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||jussi.leht...@iki.fi Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||3.712-1.fc11 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #53 from Fedora Update System upda...@fedoraproject.org 2009-07-27 17:31:24 EDT --- verilator-3.712-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|3.712-1.fc11|3.712-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #52 from Fedora Update System upda...@fedoraproject.org 2009-07-27 17:28:46 EDT --- verilator-3.712-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #48 from Lane dir...@gmail.com 2009-07-26 18:03:40 EDT --- Chitlesh, When I build the EL-5 release of verilator using koji it fails with this message: DEBUG util.py:280: Executing command: /usr/bin/yum --installroot /var/lib/mock/dist-5E-epel-build-527553-80064/root/ resolvedep 'perl-SystemPerl-devel' 'flex' 'bison' 'perl' DEBUG util.py:256: No Package Found for perl-SystemPerl-devel Is SystemPerl not available for EL-5? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #49 from Chitlesh GOORAH chitl...@gmail.com 2009-07-26 18:10:08 EDT --- Give me a few days. I'm in holidays. I'll push it to EL-5 when I return. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #51 from Fedora Update System upda...@fedoraproject.org 2009-07-26 18:35:36 EDT --- verilator-3.712-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/verilator-3.712-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #50 from Fedora Update System upda...@fedoraproject.org 2009-07-26 18:35:30 EDT --- verilator-3.712-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/verilator-3.712-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #47 from Jason Tibbitts ti...@math.uh.edu 2009-07-23 12:36:25 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Lane dir...@gmail.com changed: What|Removed |Added Flag||fedora-cvs- --- Comment #46 from Lane dir...@gmail.com 2009-07-22 12:13:09 EDT --- New Package CVS Request === Package Name: verilator Short Description: A fast simulator of synthesizable Verilog HDL Owners: dirjud chitlesh Branches: F-10 F-11 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Lane dir...@gmail.com changed: What|Removed |Added Flag|fedora-cvs- |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #43 from Chitlesh GOORAH chitl...@gmail.com 2009-07-21 04:34:00 EDT --- Can you give me your Fedora FAS username please ? I will sponsor you. https://admin.fedoraproject.org/accounts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #44 from Lane dir...@gmail.com 2009-07-21 12:21:53 EDT --- username: dirjud I just applied to the packager group -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #45 from Chitlesh GOORAH chitl...@gmail.com 2009-07-21 12:29:06 EDT --- You are now sponsored. It might be that you will have to wait one or two hours before the services grant you your packager rights. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #42 from Lane dir...@gmail.com 2009-07-21 01:17:03 EDT --- The fedora_cvs flag is not editable for me. How do I make it editable? Perhaps I am not part of the fedorabugs group? Or perhaps I am misunderstanding the instructions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #41 from Chitlesh GOORAH chitl...@gmail.com 2009-07-14 17:24:53 EDT --- There is a new upstream release -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #37 from Chitlesh GOORAH chitl...@gmail.com 2009-07-10 22:38:41 EDT --- Ping ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #38 from Lane dir...@gmail.com 2009-07-10 23:13:06 EDT --- Who are you pinging? What are the next steps? Is the procedure documented somewhere? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #39 from Jason Tibbitts ti...@math.uh.edu 2009-07-10 23:19:56 EDT --- Since the package is approved, it is up to the submitter of the ticket to take the next step, that being a CVS request so the package can be imported, built and pushed out. The procedure is fully documented in http://fedoraproject.org/wiki/PackageMaintainers/Join Every new packager should read over that before submitting packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #40 from Chitlesh GOORAH chitl...@gmail.com 2009-07-10 23:21:18 EDT --- hehe to you Lane. No the process isn't over yet. You have to put verilator on fedora cvs, then build it on koji(fedora's build system) then finally push to mirrors. Currently you are here at Add_Package_to_CVS_and_Set_Owner https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_CVS_and_Set_Owner Can you please add me as one of the owners please ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #36 from Chitlesh GOORAH chitl...@gmail.com 2009-07-05 08:19:11
EDT ---
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matches the base package %{name}
- MUST: The package meets the Packaging Guidelines.
- MUST: The package is licensed (GPLv2) with an open-source compatible license
and meet other legal requirements as defined in the legal section of Packaging
Guidelines.
- MUST: The License field in the package spec file matches the actual license.
- MUST: the source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package is
included in %doc.
- MUST: The spec file must be written in American English.
- MUST: The spec file for the package is be legible.
- MUST: The sources used to build the package must matches the upstream source,
as provided in the spec URL.
- MUST: The package successfully compiles and builds into binary rpms on at
least i386.
- MUST: All build dependencies is listed in BuildRequires.
- MUST: The spec file handles locales properly.
- MUST: If the package does not contain shared library files located in the
dynamic linker's default paths
- MUST: the package is not designed to be relocatable
- MUST: the package owns all directories that it creates.
- MUST: the package does not contain any duplicate files in the %files listing.
- MUST: Permissions on files are set properly.
- MUST: The package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
- MUST: The package consistently uses macros, as described in the macros
section of Packaging Guidelines.
- MUST: The package contains code, or permissable content. This is described in
detail in the code vs. content section of Packaging Guidelines.
- MUST: There are no Large documentation files
- MUST: %doc does not affect the runtime of the application. To summarize: If
it is in %doc, the program must run properly if it is not present.
- MUST: There are no Header files or static libraries
- MUST: The package does not contain library files with a suffix
- MUST: Package does NOT contain any .la libtool archives
- MUST: Package containing GUI applications includes a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
- MUST: Package does not own files or directories already owned by other
packages.
SHOULD Items:
- SHOULD: The source package does include license text(s) as LICENSE
- SHOULD: mock builds succcessfully in i386.
- SHOULD: The reviewer tested that the package functions as described. A
package should not segfault instead of running, for example.
- SHOULD: No scriptlets were used, those scriptlets must be sane.
- SHOULD: No subpackages present.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Chitlesh GOORAH chitl...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Bug 468516 depends on bug 478759, which changed state. Bug 478759 Summary: Review Request: perl-SystemPerl - SystemPerl Perl module https://bugzilla.redhat.com/show_bug.cgi?id=478759 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #35 from Lane dir...@gmail.com 2009-06-28 10:48:13 EDT --- New files available that address the three issues in #34: Spec URL: http://brooks.nu/~lane/verilator.spec SRPM URL: http://brooks.nu/~lane/verilator-3.711-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #34 from Chitlesh GOORAH chitl...@gmail.com 2009-06-13 15:43:47
EDT ---
Lane, the package is ready. please update the package with respect to the
following minor details. Then I'll approve.
#1 add the Artistic file as %doc
#2 compiler fix from Wilson:
sed -i s|char\* rtnp;|const char\* rtnp;| src/V3PreProc.cpp
#3: rpmlint warning spurious-executable-perm
chmod 0644 %{buildroot}%{_mandir}/man1/%{name}.1.gz
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Chitlesh GOORAH chitl...@gmail.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #32 from Chitlesh GOORAH chitl...@gmail.com 2009-06-12 04:54:09 EDT --- The build is failing under F-11. You can use mock to verify it. http://fedoraproject.org/wiki/Projects/Mock g++ -O2 -g -march=i386 -mtune=i686 -I/usr/include -O2 -g -march=i386 -mtune=i686 -MMD -O2 -g -march=i386 -mtune=i686 -I. -I.. -I../../include -O2 -g -march=i386 -mtune=i686 -DYYDEBUG -O2 -g -march=i386 -mtune=i686 -O -DDEFENV_SYSTEMC=\\ -DDEFENV_SYSTEMC_ARCH=\\ -DDEFENV_SYSTEMPERL=\\ -DDEFENV_SYSTEMPERL_INCLUDE=\/usr/include/perl-SystemPerl\ -DDEFENV_VERILATOR_ROOT=\/usr/share/verilator\ -c ../V3Param.cpp g++ -O2 -g -march=i386 -mtune=i686 -I/usr/include -O2 -g -march=i386 -mtune=i686 -MMD -O2 -g -march=i386 -mtune=i686 -I. -I.. -I../../include -O2 -g -march=i386 -mtune=i686 -DYYDEBUG -O2 -g -march=i386 -mtune=i686 -ggdb -DVL_DEBUG -c ../V3PreProc.cpp ../V3PreProc.cpp: In member function ‘virtual std::string V3PreProcImp::getline()’: ../V3PreProc.cpp:995: error: invalid conversion from ‘const char*’ to ‘char*’ make[2]: *** [V3PreProc.o] Error 1 make[2]: Leaving directory `/home/chitlesh/rpmbuild/BUILD/verilator-3.710/src/obj_dbg' make[1]: *** [../verilator_bin_dbg] Error 2 make[1]: *** Waiting for unfinished jobs g++ -O2 -g -march=i386 -mtune=i686 -I/usr/include -O2 -g -march=i386 -mtune=i686 -MMD -O2 -g -march=i386 -mtune=i686 -I. -I.. -I../../include -O2 -g -march=i386 -mtune=i686 -DYYDEBUG -O2 -g -march=i386 -mtune=i686 -O -DDEFENV_SYSTEMC=\\ -DDEFENV_SYSTEMC_ARCH=\\ -DDEFENV_SYSTEMPERL=\\ -DDEFENV_SYSTEMPERL_INCLUDE=\/usr/include/perl-SystemPerl\ -DDEFENV_VERILATOR_ROOT=\/usr/share/verilator\ -c ../V3PreShell.cpp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #33 from wsny...@wsnyder.org 2009-06-12 09:53:47 EDT ---
Grr, every GCC version has slightly different things it complains about...
This will patch it, let me know if you want a new release instead. If there's
another bug, please try make -k so they'll all show up rather than one at a
time. Thanks
diff --git a/src/V3PreProc.cpp b/src/V3PreProc.cpp
index 84856dc..4f76ba8 100644
--- a/src/V3PreProc.cpp
+++ b/src/V3PreProc.cpp
@@ -990,7 +990,7 @@ int V3PreProcImp::getToken() {
string V3PreProcImp::getline() {
// Get a single line from the parse stream. Buffer unreturned text until
the newline.
if (isEof()) return ;
-char* rtnp;
+const char* rtnp;
bool gotEof = false;
while (NULL==(rtnp=strchr(m_lineChars.c_str(),'\n')) !gotEof) {
int tok = getToken();
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #31 from Lane dir...@gmail.com 2009-06-09 15:26:11 EDT --- I updated verilator to the latest 3.710 and also switched to using the SYSTEMPERL_INCLUDE env variable to be compatible with the systemperl installation location. Spec URL: http://brooks.nu/~lane/verilator.spec SRPM URL: http://brooks.nu/~lane/verilator-3.710-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #30 from Chitlesh GOORAH chitl...@gmail.com 2009-06-04 04:31:52 EDT --- ping Lane ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #29 from wsny...@wsnyder.org 2009-03-28 11:19:13 EDT --- FYI Verilator 3.702 allows you to set and compile SYSTEMPERL_INCLUDE into verilator so the src/ suffix hack (see the earlier comments here) isn't needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 wsny...@wsnyder.org changed: What|Removed |Added CC||wsny...@wsnyder.org --- Comment #28 from wsny...@wsnyder.org 2009-01-28 20:40:55 EDT --- Chitlesh notified me of this thread. The src/ prefix is because many users have multiple versions of SystemPerl installed (generally in a repository) and just point to the one they want. Lane has a the right solution for the present version, as makefiles etc also have the src/ path hardcoded. If there's a strong objection to the extra src/ in the path, I can add a new envvariable that will set the location. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #27 from Lane dir...@gmail.com 2009-01-10 17:37:49 EDT ---
(In reply to comment #26)
in file (of verilator) src/V3Options.cpp:
!V3Options::fileStatNormal(var+/src/systemperl.h)) {
if you remove /src, I believe it should pull systemperl.h from
perl-SystemPerl-devel. Can you check if please ?
This is not a sufficient solution. There are a additional files that verilator
pulls from system perl when you turn on tracing that occur during the
simulation build. I am not in favor of the approach you are proposing here for
the following reasons:
- Neither of us have enough background with the complete scope of verilator or
system-perl to know how far such a change would reach. I can see this causing
unforeseen bugs that reach into tools even beyond verilator. In addition to
trying to find all places that verilator references the src/ directory, people
likely have tools beyond verilator that use the systemperl files in the src/
directory (we have one, for example).
- This puts added burden of maintenance on us as the packagers. Everytime a
new release of verilator and system-perl come out we will have to verify our
patch(s) are still valid and verify that any additional functionality added in
the new releases is not broken. I prefer to stay as close to upstream as
possible as the upstream project is much broader than my limited use of it. I
use the tool for verilog simulation, but the tool is much broader than that. I
feel inadequate putting my stamp that a change such a seemingly benign change
is not problematic.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #25 from Lane dir...@gmail.com 2009-01-09 12:21:48 EDT --- New files available: Spec URL: http://brooks.nu/~lane/verilator.spec SRPM URL: http://brooks.nu/~lane/verilator-3.700-1.fc10.src.rpm Changes include: - Removal of duplicate file per Comment #23. verilator depends on the file /usr/share/verilator/bin/verilator_includer, so I removed the duplicate in /usr/bin. - Added dependency of perl-SystemPerl-devel for both building and installing. For verilator to work correctly with perl-SystemPerl-devel, however, you must make the change to the perl-SystemPerl-devel spec file as documented on my comment on Bug 478759 and put the src files in /usr/include/SystemPerl/src - Updated to newly released verilator 3.700 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #26 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-09
13:05:10 EDT ---
in file (of verilator) src/V3Options.cpp:
!V3Options::fileStatNormal(var+/src/systemperl.h)) {
if you remove /src, I believe it should pull systemperl.h from
perl-SystemPerl-devel. Can you check if please ?
in the 3.700 release notes, you are listed for:
- Add limited support for tristate inouts. Written by Lane Brooks. This allows
common pad ring and tristate-mux structures to be Verilated. See the
documentation for more information on supported constructs.
- Fix 'bad select range' warning missing some cases, bug43. [Lane Brooks]
good job Lane.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #22 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-04 06:16:28 EDT --- (In reply to comment #21) If you are packaging the one from Wilson Snyder, then I can remove these files. Yes, I'll package the ones from Wilson Snyder. I'm also trying to package everything from veripool for F-11. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #23 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-04
13:06:33 EDT ---
(In reply to comment #11)
#004: Are these useful ?
/usr/share/verilator/bin
/usr/share/verilator/bin/verilator_includer
Yes. As far as I know, verilator uses these.
/usr/share/verilator/bin
/usr/share/verilator/bin/verilator_includer
is a duplicate of
/usr/bin/verilator_includer
You will need to remove the duplicates as well
%{__rm} -rf %{buildroot}%{_datadir}%{name}/bin
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #24 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-04 13:07:39 EDT --- Use perl-SystemPerl as from now on: Bug 478759 - Review Request: perl-SystemPerl - SystemPerl Perl module -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Depends on||478759 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #19 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-03 18:35:56 EDT --- Lane, you have commented perl-verilog on #BuildRequires: perl-verilog, perl-systemc, systemc I'm packaging perl-Verilog https://bugzilla.redhat.com/show_bug.cgi?id=476386 I haven't yet looked at the details, do you think enabling perl-Verilog our verilator will provide more features ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #20 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-03 19:26:35 EDT --- #001: These should not be shipped /usr/share/verilator/include/verilated.mk.in -- duplicate with /usr/share/verilator/include/verilated.mk #002: do we need to ship these with this package ? usr/share/verilator/perl-systemc/src /usr/share/verilator/perl-systemc/src/SpCommon.h /usr/share/verilator/perl-systemc/src/SpTraceVcdC.cpp /usr/share/verilator/perl-systemc/src/SpTraceVcdC.h /usr/share/verilator/perl-systemc/src/systemperl.h Wouldn't it be wise to package perl-SystemPerl ? I have already started packaging perl-SystemPerl. Soon I'll post a package review for perl-SystemPerl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #21 from Lane dir...@gmail.com 2009-01-03 19:34:42 EDT --- (In reply to comment #20) #002: do we need to ship these with this package ? usr/share/verilator/perl-systemc/src /usr/share/verilator/perl-systemc/src/SpCommon.h /usr/share/verilator/perl-systemc/src/SpTraceVcdC.cpp /usr/share/verilator/perl-systemc/src/SpTraceVcdC.h /usr/share/verilator/perl-systemc/src/systemperl.h Wouldn't it be wise to package perl-SystemPerl ? I have already started packaging perl-SystemPerl. Soon I'll post a package review for perl-SystemPerl Are you packaging the system perl from Wilson Snyder at www.veripool.org? These files are included because they are get compiled into the verilator models whenever you want to do tracing to see your waveforms. If you are packaging the one from Wilson Snyder, then I can remove these files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #17 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-02 14:45:41 EDT --- Lane, at https://fedoraproject.org/wiki/Releases/11/Schedule is the schedule for F11. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #16 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-02 14:43:26 EDT --- The suggestion was to package the example files (i.e. the content of /usr/share/verilator/examples), which needed two steps - move the folder /usr/share/verilator/examples directly below $BUILDROOT - use the %doc directive to include the above mentioned folder -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #18 from Lane dir...@gmail.com 2009-01-02 15:23:18 EDT --- I updated the spec file to move the examples from the data directory to the doc directory. You can download the updates from: Spec URL: http://brooks.nu/~lane/verilator.spec SRPM URL: http://brooks.nu/~lane/verilator-3.681-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #11 from Lane dir...@gmail.com 2009-01-01 10:34:07 EDT --- #004: Are these useful ? /usr/share/verilator/bin /usr/share/verilator/bin/verilator_includer Yes. As far as I know, verilator uses these. #005: move BUIDROOT/usr/share/verilator/examples to examples/ then %doc examples/ I don't understand this comment. #006: Are these important: chitlesh(SPECS)[1]$rpm -ql verilator | grep -v examples | grep .cpp /usr/share/verilator/include/verilated.cpp /usr/share/verilator/perl-systemc/src/SpTraceVcdC.cpp Yes. These are included in all verilator simulation builds. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #12 from Lane dir...@gmail.com 2009-01-01 11:14:59 EDT --- Created an attachment (id=328036) -- (https://bugzilla.redhat.com/attachment.cgi?id=328036) simple verilator test case Attached is a simple verilator test case per Chitlesh's request. Here is how to run this: 1. untar the file and cd into the verilator_test_case directory. 2. Compile the simulation by running 'make'. This generates an executable called obj_dir/Vcounter. 3. Run the simulation: 'obj_dir/Vcounter' This will output the following to stdout: Hello World from counter! Time 0: count = 0x0 Time 2: count = 0x0 Time 4: count = 0x0 Time 6: count = 0x1 Time 8: count = 0x2 Time 10: count = 0x3 Time 12: count = 0x4 Time 14: count = 0x5 Time 16: count = 0x6 Time 18: count = 0x7 Time 20: count = 0x8 Time 22: count = 0x9 Time 24: count = 0xa SUMMARY OF TEST CASE: This test case implements a counter in the verilog file counter.v. The C++ file tb.cpp implements the testbench that provides the input, including the clock. This example does not turn on any tracing. See the verilator documentation on how to enable tracing to generate a VCD file for viewing with gtkwaves. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #13 from Lane dir...@gmail.com 2009-01-01 11:19:13 EDT --- I have an updated spec and src file you can download from: Spec URL: http://brooks.nu/~lane/verilator.spec SRPM URL: http://brooks.nu/~lane/verilator-3.681-3.fc10.src.rpm I incorporated Chitlesh's feedback from Comments #7 and #9 except for #004 from Comment #7 as I do not understand this comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #15 from Lane dir...@gmail.com 2009-01-01 11:26:33 EDT --- This is a URL correction of Comment #13 I have an updated spec and src file you can download from: Spec URL: http://brooks.nu/~lane/verilator.spec SRPM URL: http://brooks.nu/~lane/verilator-3.681-1.fc10.src.rpm I incorporated Chitlesh's feedback from Comment #7 and Comment #9 except for item #004 from Comment #7 as I do not understand this suggestion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #14 from Lane dir...@gmail.com 2009-01-01 11:25:42 EDT --- Chitlesh, I would like to get verilator into Fedora 11 if it is not already too late. Can you give me a summary of the milestones and dates that are required to accomplish that? This will help me as I am still extremely swamped with a tapeout. With the milestone list I can make the necessary time to get this done. Lane -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #9 from Chitlesh GOORAH [EMAIL PROTECTED] 2008-12-06 05:36:20
EDT ---
#001: Summary:Verilator is a fast simulator for synthesizable Verilog
Summary should not include the %{name}
Instead it should be A fast synthesizable Verilog simulator
#002: For rpmfusion, I'm packaging systemc, however the libsystemc-devel is
simply systemc.
#003: Verilator 3.681 has been released .
Lane are you still interested with verilator ?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #10 from Lane [EMAIL PROTECTED] 2008-12-06 05:48:30 EDT --- I am swamped right now with a tape out. I will try to get some time over the next two weeks to incorporate your comments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #8 from Chitlesh GOORAH [EMAIL PROTECTED] 2008-12-04 18:30:56 EDT --- Ping ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #7 from Chitlesh GOORAH [EMAIL PROTECTED] 2008-11-19 17:03:44
EDT ---
#001 You can replace
%setup -q -n %{name}-%{version} by
%setup -q
#002 add %{?_smp_mflags}
SYSTEMPERL=%{_datadir}/verilator/perl-systemc %{__make} %{?_smp_mflags}
#003: use fedora optflags:
add the following after configure
%{__sed} -i s|CPPFLAGSNOWALL +=|CPPFLAGSNOWALL +=%{optflags}| \
{src,test_c,test_regress,test_sc,test_sp,test_verilated}/Makefile_obj
#004: Are these useful ?
/usr/share/verilator/bin
/usr/share/verilator/bin/verilator_includer
#005: move BUIDROOT/usr/share/verilator/examples to examples/
then %doc examples/
#006: Are these important:
chitlesh(SPECS)[1]$rpm -ql verilator | grep -v examples | grep .cpp
/usr/share/verilator/include/verilated.cpp
/usr/share/verilator/perl-systemc/src/SpTraceVcdC.cpp
#007 can you give me quick case study of how to use verilator ? It might be
helpful for those who don't know, but want to do the review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 David Woodhouse [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #6 from David Woodhouse [EMAIL PROTECTED] 2008-11-02 05:11:57 EDT --- I thought that it was considered good practice to bump the release for changes made during review, so unless you submit a perfect package in the first place it was quite _common_ for the first package to have a release other than -1? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #4 from Chitlesh GOORAH [EMAIL PROTECTED] 2008-10-26 06:27:40 EDT --- True, but since it's his first package for fedora, I prefer that he adopts some good practices :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #5 from Lane [EMAIL PROTECTED] 2008-10-26 11:14:00 EDT --- I have incorporated Chitlesh's feedbackc into an updated spec file and have a new release 3 available for download from: http://www.brooks.nu/~lane/verilator.spec http://www.brooks.nu/~lane/verilator-3.680-3.fc10.src.rpm The previous release was 2 but was not documented in the changelog. I added the correct changelog entry to document releases 1, 2, and now 3. We have been using these releases at my work, thus I do not want to reset to 1 or it will cause problems for our users. I have built and tested this new release 3 on our project regression test suite at work on F10 rawhide, F8, and Centos 5.2. Lane -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Itamar Reis Peixoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Alias||verilator -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Lane [EMAIL PROTECTED] changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Chitlesh GOORAH [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #1 from Chitlesh GOORAH [EMAIL PROTECTED] 2008-10-25 12:00:08 EDT --- I will do the review and sponsoring :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #2 from Chitlesh GOORAH [EMAIL PROTECTED] 2008-10-25 12:36:18
EDT ---
#001: Release:2%{?dist}
This requires that first
- first, for the version 3.680, this is the first src.rpm, thus your Release
should be 1 and not 2.
. Release:1%{?dist}
- second, every changelog entry should entail the version-release tag
Here is how your changelog should be:
* Thu Oct 16 2008 Lane Brooks lane [AT] brooks DOT nu - 3.680-1
- Initial package based on SUSE packages from Guenter Dannoritzer
dannoritzer{%}web{*}de
For more info : https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs
You have noticed that I have set your email address to: lane [AT] brooks DOT
nu. This is to limit unwanted spam to your email address.
#002: Licensing:
With Fedora's strict packaging policies, all spec files should entail the exact
license and its version.
In your case it will be:
License:GPLv2
For more info: https://fedoraproject.org/wiki/Licensing
#003: Replace tabs with spaces
Line 6 in your spec file : Group: Applications/Engineering
#004: This line should be removed, as your name is already listed in the
changelogs
Packager: Lane Brooks [EMAIL PROTECTED]
#005: Referencing the SourceX:
All the SourceX: tag should have their complete urls:
For more info: https://fedoraproject.org/wiki/Packaging/SourceURL
#006: Remove Autoreqprov:On
#007: Build requires Exceptions
In accordance to
https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions,
you can safely remove the following buildrequires:
BuildRequires: gcc, gcc-c++
#008: Add a -q to the following:
%setup -n %{name}-%{version}
#009: Use macros as much as you can in your spec file:
/usr/share/ -- %{_datadir}
./configure -- %configure
/usr -- %{_prefix}
cp - %{__cp}
rm - %{__rm}
for more info: https://fedoraproject.org/wiki/Packaging/RPMMacros
#010: Keep timestamps
use -p with %{__cp} such as %{__cp} -pr
Please take some time reading the fedora packaging guidelines again and update
the actual spec file.
Everytime you update and publish a new spec file, don't forget to increment the
Release tag and update the changelog.
Once you have updated the above issues, I will dig in-depth about verilator's
compilation.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #3 from manuel wolfshant [EMAIL PROTECTED] 2008-10-25 22:00:53 EDT --- Actually, generally speaking, there is no rule saying that the first release submitted in Fedora must be 1. 2 is just fine. One might have done/used some previous testing specs before the one submitted. Or it might be a new version of a rpm already in use from another source. I am looking forward to see this package in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
