[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2009-03-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 CC||oget.fed...@gmail.com
   Flag||needinfo?(gr...@redhat.com)




--- Comment #8 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-15 
23:49:33 EDT ---
I believe that this package should be noarch and the .pc file should go to
/usr/share/pkgconfig .

The files %{_datadir}/lv2 that are in the main package are actually devel
files. They are templates to write lv2 plugins and are not needed during
runtime. So only a devel package should be generated from the SRPM.

Also, I can't find the F-10 build.

Additionally, there is a new upstream version. I'm going to ask pkgdb access to
fix these issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2009-03-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

   Flag|needinfo?(gr...@redhat.com) |




--- Comment #9 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-03-16 
00:12:54 EDT ---
I opened a new bug to address the above issues.

Ref: bug 490398

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913





--- Comment #7 from Anthony Green gr...@redhat.com  2008-12-22 16:28:32 EDT 
---
Closed - thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913


Anthony Green gr...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-12-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-cvs? |fedora-cvs+




--- Comment #6 from Kevin Fenzi ke...@tummy.com  2008-12-20 22:51:31 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-12-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913





--- Comment #5 from Anthony Green gr...@redhat.com  2008-12-19 17:50:34 EDT 
---
New Package CVS Request
===
Package Name: lv2core
Short Description: Audio Plugin Standard
Owners: green
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-12-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913


Anthony Green gr...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-12-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

 Blocks||470914




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-12-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913


Michael Schwendt bugs.mich...@gmx.net changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|bugs.mich...@gmx.net
   Flag||fedora-review+




--- Comment #4 from Michael Schwendt bugs.mich...@gmx.net  2008-12-17 
07:40:57 EDT ---
In bug 232465 comment 2 I pointed out that the package is dual-licenced: API
header is LGPLv2+, data file is MIT.

 = License: LGPLv2+ and MIT

Authors's COPYING file says BSD-style, but the licence text matches this:
http://opensource.org/licenses/mit-license.php


It is not clear to me why neither the LV2 bundledir ( %{_libdir}/lv2 ) nor the
bundle name ( lv2core.lv2 ) are defined anywhere in the lv2.h file. That means
applications would need to define it themselves. Hopefully they get it right
and agree on a standard path.


Home page lists a rev3 (2008-11-08) with a comment in the ChangeLog that says
unstable. Can't find any such classification of rev2.


 %files
 %doc AUTHORS COPYING README
 %defattr(-,root,root,-)

I suggest moving the %defattr one line up.
Actually rpmlint reports this, too.


 Summary:An Audio Plugin Standard

I would drop the An . ;)


Starting the %description with the following sentence from the home page would
be an improvement:

LV2 is a standard for plugins and matching host applications, mainly targeted
at audio processing and generation.



With those changes, which can be applied in pkg cvs, it's fine packaging-wise: 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-11-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913





--- Comment #1 from Jason Tibbitts [EMAIL PROTECTED]  2008-11-10 17:08:31 EDT 
---
*** Bug 232465 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-11-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913





--- Comment #2 from Jason Tibbitts [EMAIL PROTECTED]  2008-11-10 17:15:06 EDT 
---
I note that this still includes a .pc file and is still arch-specific.  I know
the old ticket was closed but there are still open questions there and it would
be really nice if you could address them.  Comment #14 from Peter Jones,
specifically.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470913] Review Request: lv2core - An Audio Plugin Standard

2008-11-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470913





--- Comment #3 from Anthony Green [EMAIL PROTECTED]  2008-11-10 17:27:32 EDT 
---
We should include the .pc file because packages depending on this package, like
slv2, expect to find one (to test the version, I think) and there's no need to
deviate from upstream.

I've added the 
  %define debug_package %{nil}
you suggested.

Spec URL: http://people.redhat.com/green/Fedora/lv2core.spec
SRPM URL: http://people.redhat.com/green/Fedora/lv2core-2.0-2.fc10.src.rpm

Thanks,

AG

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review