[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473348
--- Comment #6 from Gabriel Somlo so...@cmu.edu 2009-06-23 15:36:21 EDT ---
also not an official review (yet) :)
Installing your drraw-selinux subpackage didn't actually make any difference
for me (stock up-to-date f10 install, selinux set to enforcing).
The error logged to syslog advised me to run 'sealert -l something', which
in turn recommended that I run 'chcon -t bin_t /usr/share/drraw/drraw.cgi',
which fixed the issue (again, independently of whether the -selinux subpackage
was installed or not).
Digging through the selinux packaging wiki link from comment #1, I ended up at
http://www.redhat.com/archives/fedora-selinux-list/2006-April/msg00115.html
which seems to suggest that in your case a subpackage is unnecessary, and all
you really need is:
%post
chcon -t bin_t %{_datadir}/%{name}/drraw.cgi
and no need to worry about %postun at all. chcon is part of coreutils, so no
need to drag in policycoreutils (probably no need for a -selinux subpackage at
all).
Once your package gets accepted, file bug against selinux-policy and request
that your package be handled (again, as per the wiki page in comment #1)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #5 from Xavier Bachelot xav...@bachelot.org 2009-04-03 06:32:27 EDT --- New version, add a Group: tag to -selinux subpackage. http://www.bachelot.org/fedora/SPECS/drraw.spec http://www.bachelot.org/fedora/SRPMS/drraw-2.2-0.5.b2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #4 from Xavier Bachelot xav...@bachelot.org 2009-03-03 08:44:12 EDT --- New version, drraw 2.2 beta 2 : http://www.bachelot.org/fedora/SPECS/drraw.spec http://www.bachelot.org/fedora/SRPMS/drraw-2.2-0.4.b2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #3 from Xavier Bachelot xav...@bachelot.org 2009-01-26 11:55:55 EDT --- Updated spec and srpm : http://www.bachelot.org/fedora/SPECS/drraw.spec http://www.bachelot.org/fedora/SRPMS/drraw-2.2-0.2.b1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #2 from Xavier Bachelot xav...@bachelot.org 2009-01-12 10:04:38 EDT --- (In reply to comment #1) This is not an official review. 1. When applying patch #2, patch returns: patch unexpectedly ends in middle of line I've removed this patch and replaced it with a patch that update to latest trunk. There's only a handful of changes since the last beta. While this doesn't abort the build, the patch file should be fixed to not generate this error. 2. This would fail to run with SELinux activated. You should fix the context of the CGI script, per http://fedoraproject.org/wiki/PackagingDrafts/SELinux. Creating a drraw-selinux subpackage would probably be ideal in this case. I'm not SELinux proficient, but I'll try to take care of that. Thanks for the pointer. In your opinion, does such a requirement block the review or can we save that for later ? 3. Patch #2 appears to be a bug fix. If you have filed a bug with the upstream source, you should reference this in your spec file; if not, you should file one and reference it. See http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment There's no bug tracker for this project. This was reported on their mailing list by a colleague of mine, as well as some patch for new features. Actually, even the svn repository is not public, but after a few mails with upstream, I now have read-only access. I'll post new spec and srpms when the selinux issue is addressed. Thanks for the pre-review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Chris St. Pierre stpie...@nebrwesleyan.edu changed: What|Removed |Added CC||stpie...@nebrwesleyan.edu --- Comment #1 from Chris St. Pierre stpie...@nebrwesleyan.edu 2008-12-23 00:18:25 EDT --- This is not an official review. 1. When applying patch #2, patch returns: patch unexpectedly ends in middle of line While this doesn't abort the build, the patch file should be fixed to not generate this error. 2. This would fail to run with SELinux activated. You should fix the context of the CGI script, per http://fedoraproject.org/wiki/PackagingDrafts/SELinux. Creating a drraw-selinux subpackage would probably be ideal in this case. 3. Patch #2 appears to be a bug fix. If you have filed a bug with the upstream source, you should reference this in your spec file; if not, you should file one and reference it. See http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
