[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 Chris Weyl cw...@alumni.drew.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #12 from Chris Weyl cw...@alumni.drew.edu 2009-01-14 18:17:15 EDT --- Thanks for the review! :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473723
manuel wolfshant wo...@nobugconsulting.ro changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-13
07:01:58 EDT ---
Well, what I cannot grok is why including tests which do not pass.
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64
[x] Rpmlint output:
source RPM: empty
binary RPM:empty
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
SHA1SUM of package: f8e11b8416b276fbe359c7b16f6fab07021f4f55
Eval-Context-0.07.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot}.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: devel/x86_64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: koji scratch build
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[+] make test passes
= with some tests skipped
*** APPROVED ***
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 Chris Weyl cw...@alumni.drew.edu changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 --- Comment #10 from Chris Weyl cw...@alumni.drew.edu 2009-01-13 11:40:40 EDT --- New Package CVS Request === Package Name: perl-Eval-Context Short Description: Evaluate perl code in context wrapper Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi ke...@tummy.com 2009-01-13 16:15:06 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 --- Comment #8 from Chris Weyl cw...@alumni.drew.edu 2009-01-12 13:44:10 EDT --- That's not picky at all :) The failing test is one using Test::Perl::Critic -- it tests _how_ you code, not if the code works or not, so it's OK to exclude along the lines of Test::Kwalitee, Test::Pod::Coverage, etc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 --- Comment #7 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-12 00:21:42 EDT --- I'll probably sound picky, but I'd say https://fedoraproject.org/wiki/Packaging/Perl#When_to_.2Anot.2A_test applies here. In other words, the test should be made to pass, not deleted. I am wrong here? Does it fall under Tests which do not test package functionality should still be invoked, but their exclusion not be considered a blocker ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 --- Comment #5 from Chris Weyl cw...@alumni.drew.edu 2009-01-11 02:25:12 EDT --- Spec URL: http://fedorapeople.org/~cweyl/review/perl-Eval-Context.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Eval-Context-0.07-2.fc10.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1044661 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 --- Comment #6 from Chris Weyl cw...@alumni.drew.edu 2009-01-11 02:33:19 EDT --- Err, make that: http://koji.fedoraproject.org/koji/taskinfo?taskID=1044663 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Attachment #328515|0 |1 is obsolete|| --- Comment #4 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-09 20:48:42 EDT --- Created an attachment (id=328609) -- (https://bugzilla.redhat.com/attachment.cgi?id=328609) failed build log Make test fails: t/003_perl_critic... # Failed test 'Test::Perl::Critic for blib/lib/Eval/Context.pm' # at /usr/lib/perl5/vendor_perl/5.10.0/Test/Perl/Critic.pm line 99. # See attachment for full error log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro Bug 473723 depends on bug 473718, which changed state. Bug 473718 Summary: Review Request: perl-Directory-Scratch-Structured - Creates temporary files and directories from a structured description https://bugzilla.redhat.com/show_bug.cgi?id=473718 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED --- Comment #2 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-08 23:02:01 EDT --- Created an attachment (id=328515) -- (https://bugzilla.redhat.com/attachment.cgi?id=328515) make test dies in pain, at least Term/Size.pm seems to be required but missing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 --- Comment #3 from Chris Weyl cw...@alumni.drew.edu 2009-01-09 00:00:11 EDT --- Hrm. This appears to be perl-Data-TreeDumper's fault for not having Term::Size as a requires (it's not automagically being picked up). Updating and rebuilding there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473723] Review Request: perl-Eval-Context - Evaluate perl code in context wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473723 manuel wolfshant [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: |Review Request: |perl-Eval-Context - Evalute |perl-Eval-Context - |perl code in context wraper |Evaluate perl code in ||context wrapper -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
