[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2009-01-14 21:58:47 EDT --- chipmunk-4.1.0-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 Jon Ciesla l...@jcomserv.net changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #18 from Jon Ciesla l...@jcomserv.net 2009-01-12 13:57:48 EDT --- I got it to build, but it's the ugly mv in %install method. Bleah. Imported and build in rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2009-01-12 14:05:14 EDT --- chipmunk-4.1.0-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/chipmunk-4.1.0-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #20 from Conrad Meyer kon...@tylerc.org 2009-01-12 14:48:28 EDT --- Any chance you want to work with the maintainer of xmoto to get xmoto 0.5 to use the system chipmunk? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #21 from Conrad Meyer kon...@tylerc.org 2009-01-12 14:52:29 EDT --- Just kidding, it appears you are the xmoto maintainer. Good job :D. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #22 from Jon Ciesla l...@jcomserv.net 2009-01-12 14:57:36 EDT --- Had a reply half typed to #20 when I saw #21. . .:) I've made a few attempts, but it looks like a lot of paths might reply on the presence of the bundled version. I'm in conversation with upstream about it. They have no problem using the system version, it's not not in any distros. I let them know Fedora has it now, so we'll see what develops. If I get it working before then, I will of course patch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #23 from Conrad Meyer kon...@tylerc.org 2009-01-12 15:10:40 EDT --- I think there is a packaging guideline that is something along the lines of: MUST not use private copy of system libraries. So please do work this out with upstream, or failing that hack up a patch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #24 from Jon Ciesla l...@jcomserv.net 2009-01-12 15:18:45 EDT --- I think it's actually a SHOULD, but I feel pretty strongly about it and have done quite a bit with several of my PHP packages to that end. The sooner the better. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #14 from Jon Ciesla l...@jcomserv.net 2009-01-08 08:41:24 EDT --- SRPM URL: http://zanoni.jcomserv.net/fedora/chipmunk/chipmunk-4.1.0-4.fc10.src.rpm SPEC URL: http://zanoni.jcomserv.net/fedora/chipmunk/chipmunk.spec How does this work? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #16 from Conrad Meyer kon...@tylerc.org 2009-01-08 12:33:44 EDT --- Or rather, it expands to that on lib64 arches. But you get the idea. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474149
--- Comment #15 from Conrad Meyer kon...@tylerc.org 2009-01-08 12:32:51 EDT
---
(In reply to comment #14)
%if %{?_lib} == lib64
%{cmake} -DLIB_SUFFIX=64
%else
%{cmake}
%endif
%{cmake} already expands to something like this:
CFLAGS=${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic} ; export
CFLAGS ;
CXXFLAGS=${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic} ; export
CXXFLAGS ;
FFLAGS=${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic} ; export
FFLAGS ;
/usr/bin/cmake \
-DCMAKE_INSTALL_PREFIX:PATH=/usr \
-DCMAKE_INSTALL_LIBDIR:PATH=/usr/lib64 \
-DINCLUDE_INSTALL_DIR:PATH=/usr/include \
-DLIB_INSTALL_DIR:PATH=/usr/lib64 \
-DSYSCONF_INSTALL_DIR:PATH=/etc \
-DSHARE_INSTALL_PREFIX:PATH=/usr/share \
%if lib64 == lib64
-DLIB_SUFFIX=64 \
%endif
-DBUILD_SHARED_LIBS:BOOL=ON
So I think what is passed to cmake is not the problem. As a hack solution you
could move stuff from /usr/lib to %{_libdir} in %install, or else fix the
CMakeLists.txt files.
But this is already approved and you will have trouble building in koji until
this is fixed anyways, so no need to check back in with me unless you want help
:).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #17 from Kevin Fenzi ke...@tummy.com 2009-01-09 00:54:23 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #4 from Jon Ciesla l...@jcomserv.net 2009-01-07 11:04:22 EDT --- SRPM URL: http://zanoni.jcomserv.net/fedora/chipmunk/chipmunk-4.1.0-2.fc10.src.rpm SPEC URL: http://zanoni.jcomserv.net/fedora/chipmunk/chipmunk.spec Fixed it, but now it complains that the ruby lib is unstripped. I don't see anything in the ruby packaging guidelines that would help. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #6 from Conrad Meyer kon...@tylerc.org 2009-01-07 15:10:53 EDT --- Oh, and line 72, you might want to replace .so.4 with .so.* so that your spec doesn't need to be updated when the SONAME gets bumped upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474149
--- Comment #5 from Conrad Meyer kon...@tylerc.org 2009-01-07 15:09:49 EDT
---
Some more comments:
- Should this be System Environment/Libraries (and not Development/Libraries)?
- Line 46 of the spec has a tab instead of spaces.
- Line 61 should be %{cmake} . (sets everything automatically).
- Line 72, the mode should be 755 not 644. Rpm only strips 755 files when
looking for debuginfo, this is why you are getting the warnings about
unstripped binaries.
- Line 88, you should use %{_libdir} instead of /usr/lib
- Line 93, this should be %{_includedir}/chipmunk not
%{_includedir}/chipmunk/*.h (the latter leaves an unowned directory).
- Line 87, should be ...*.so.* (as opposed to ...*.so*). This is because
un-suffixed .so files belong in the -devel package.
- Add %{_libdir}/*.so to %files devel.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #7 from Jon Ciesla l...@jcomserv.net 2009-01-07 15:48:34 EDT --- SRPM URL: http://zanoni.jcomserv.net/fedora/chipmunk/chipmunk-4.1.0-3.fc10.src.rpm SPEC URL: http://zanoni.jcomserv.net/fedora/chipmunk/chipmunk.spec Addressed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Conrad Meyer kon...@tylerc.org 2009-01-07 15:55:45 EDT --- Looks good to me. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474149
--- Comment #9 from Conrad Meyer kon...@tylerc.org 2009-01-07 16:00:54 EDT
---
Um, oops, this doesn't build in mock yet:
447 Installed (but unpackaged) file(s) found:
448/usr/lib/libchipmunk.a
449/usr/lib/libchipmunk.so
450/usr/lib/libchipmunk.so.4
It seems that your package is somehow installing libraries to /usr/lib instead
of %{_libdir}; please fix this before importing it to CVS. Thanks.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 Jon Ciesla l...@jcomserv.net changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Comment #10 from Jon Ciesla l...@jcomserv.net 2009-01-07 16:02:51 EDT --- Excellent, thanks! New Package CVS Request === Package Name: chipmunk Short Description: A rigid body physics library Owners: limb Branches: F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #11 from Jon Ciesla l...@jcomserv.net 2009-01-07 16:10:50 EDT --- Will do, good catch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #12 from Jon Ciesla l...@jcomserv.net 2009-01-07 16:30:16 EDT --- Weird, my mock build works. Macros seem ok, I'll see what happened after import. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474149
--- Comment #13 from Conrad Meyer kon...@tylerc.org 2009-01-07 18:35:27 EDT
---
(In reply to comment #12)
Weird, my mock build works. Macros seem ok, I'll see what happened after
import.
I'm on x86_64. %{_libdir} != /usr/lib here, which is why rpmbuild (on x86_64)
catches it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #2 from Jon Ciesla l...@jcomserv.net 2009-01-02 08:38:43 EDT --- The comment about *.so applies to *.so.*. I'm actually not sure how to correct the debuginfo issue, which I was hoping to find someone to assist with. I see strip mentioned a few places in the source tree, but my cmake-fu is insufficient to finding the most clueful way to remove it. What's the question? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #3 from Conrad Meyer kon...@tylerc.org 2009-01-02 08:47:04 EDT --- (In reply to comment #2) The comment about *.so applies to *.so.*. (This was my question.) I'm actually not sure how to correct the debuginfo issue, which I was hoping to find someone to assist with. I see strip mentioned a few places in the source tree, but my cmake-fu is insufficient to finding the most clueful way to remove it. Probably easiest just to remove strip wherever it's mentioned (my cmake-fu is no better than yours). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|kon...@tylerc.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 474149] Review Request: chipmunk - A rigid body physics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #1 from Conrad Meyer kon...@tylerc.org 2009-01-01 18:45:31 EDT --- Created an attachment (id=328048) -- (https://bugzilla.redhat.com/attachment.cgi?id=328048) Review. Attached is my initial review. Please fix the problems indicated by rpmlint; also, I have a question. Otherwise looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
