[Bug 478429] Review Request: tinc - A virtual private network daemon

2010-01-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429


Felix Kaechele fe...@fetzig.org changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #14 from Felix Kaechele fe...@fetzig.org  2010-01-05 08:03:34 EDT 
---
[+] source files match upstream: sha256sum
add18b68710a08dd1d209f177154f9d8c7614031050abf16139dd9c3fc56be84 
tinc-1.0.11.tar.gz
add18b68710a08dd1d209f177154f9d8c7614031050abf16139dd9c3fc56be84 
../SOURCES/tinc-1.0.11.tar.gz
[+] package meets naming and versioning guidelines.
[+] spec is properly named, cleanly written, and uses macros consistently.
[+] dist tag is present.
[+] build root is correct.
[+] license field matches the actual license.
[+] license is open source-compatible.
[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] compiler flags are appropriate.
[+] %clean is present. 
[+] package builds in mock.
[+] package installs properly.
[+] debuginfo package looks complete.
[+] rpmlint is silent.
[+] final provides and requires are sane
[NA] %check is present and all tests pass:
[+] no shared libraries are added to the regular linker search paths.
[+] owns the directories it creates. 
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[NA] scriptlets match those on ScriptletSnippets page.
[+] code, not content.
[+] documentation is small, so no -docs subpackage is necessary.
[+] %docs are not necessary for the proper functioning of the package.
[+] no headers.
[+] no pkgconfig files.
[+] no libtool .la droppings.
[N/A] desktop files valid and installed properly.

APPROVED!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-12-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429





--- Comment #13 from Fabian Affolter fab...@bernewireless.net  2009-12-21 
06:36:37 EDT ---
Sorry for my delay.

Here are the updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/tinc.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/tinc-1.0.11-1.fc12.src.rpm

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1882856

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-12-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429





--- Comment #12 from Felix Kaechele fe...@fetzig.org  2009-12-10 22:13:38 EDT 
---
Is there still something happening here? I'm working through my Bugzilla review
queue right now. If you're not interested in this anymore I'd like to close
this for now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-10-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429





--- Comment #11 from Christoph Wickert cwick...@fedoraproject.org  2009-10-19 
13:48:10 EDT ---
BTW: tinc 1.0.10 is out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-10-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429


Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

 CC||cwick...@fedoraproject.org




--- Comment #10 from Christoph Wickert cwick...@fedoraproject.org  2009-10-17 
17:49:00 EDT ---
Quiting from 

If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.

This means you'll need to file a bug against tinc (e. g. tinc wont build on
ppc) once the package is in bugzilla, let *that* bug block bug 179260 and add
its # to the spec. If you use this review to block the tracker the bug will be
closed when tinc is in the repos and not when the problem is really solved.

Removing the blocker on bug 179260 now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-10-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429


Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

 Blocks|179260(FE-ExcludeArch-ppc)  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-07-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429





--- Comment #9 from Fabian Affolter fab...@bernewireless.net  2009-07-30 
03:51:30 EDT ---
Thanks for your patience.  I guess that I will pick this up again soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-07-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429


Juha Tuomala t...@iki.fi changed:

   What|Removed |Added

URL||http://www.tinc-vpn.org/
 CC||t...@iki.fi
  Alias||tinc




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-06-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429





--- Comment #8 from Felix Kaechele fe...@fetzig.org  2009-06-21 07:20:10 EDT 
---
Ping.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-04-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429





--- Comment #6 from Fabian Affolter fab...@bernewireless.net  2009-04-19 
12:00:53 EDT ---
Thanks Felix for the patch.  Are you able to do a scratch build on koji?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-04-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429





--- Comment #7 from Felix Kaechele fe...@fetzig.org  2009-04-19 12:23:31 EDT 
---
There you go:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1308030

However I changed the patch to already include the changes autoreconf -f -i
generates. Because autoreconf depends on much more than just autoconf. As it
would add a lot of additional BuildReqs I chose to patch the whole thing.
Unfortunately the patch is 1.6M in size. So it would probably be the best to
upstream it if possible (although I think that the problem might be Fedora
specific).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-04-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429





--- Comment #5 from Felix Kaechele fe...@fetzig.org  2009-04-17 16:01:30 EDT 
---
Created an attachment (id=340081)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=340081)
m4 macro patch for tinc ppc

tinc builds for me with this patch on ppc.
However you will need to BuildReq autoconf then and run autoreconf -f -i in
%prep.
You should probably upstream this if possible. AFAIK SHA1_Init also indicates
that openssl can be used with SHA1 stuff.

You may test yourself. If you don't have a ppc testmachine check
https://fedoraproject.org/wiki/Test_Machine_Resources_For_Package_Maintainers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-04-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429


Felix Kaechele fe...@fetzig.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||fe...@fetzig.org
 AssignedTo|nob...@fedoraproject.org|fe...@fetzig.org
   Flag||fedora-review?




--- Comment #4 from Felix Kaechele fe...@fetzig.org  2009-04-10 16:47:12 EDT 
---
Let's see what we can do here :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-03-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

 Blocks||179260(FE-ExcludeArch-ppc)




--- Comment #3 from Fabian Affolter fab...@bernewireless.net  2009-03-06 
16:55:36 EDT ---
It's not a temporary issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-01-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429





--- Comment #2 from Fabian Affolter fab...@bernewireless.net  2009-01-10 
17:23:36 EDT ---
First I though that this is only a temporary problem but it seams not.  I'm
trying to figure out if it's a bug in the openssl package or one in tinc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478429] Review Request: tinc - A virtual private network daemon

2009-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478429


Till Maas opensou...@till.name changed:

   What|Removed |Added

 CC||opensou...@till.name




--- Comment #1 from Till Maas opensou...@till.name  2009-01-02 16:30:44 EDT 
---
(In reply to comment #0)

 This package fails at the moment on ppc.
 - configure: error: OpenSSL libraries not found.

Is this a bug in the OpenSSL package? What is the plan to fix this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review