[Bug 478565] Review Request: gupnp-igd - Library to handle UPnP IGD port mapping

2009-01-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478565


Brian Pepple  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #5 from Brian Pepple   2009-01-20 19:14:30 EDT 
---
Built for rawhide.  Denis, thanks again for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478565] Review Request: gupnp-igd - Library to handle UPnP IGD port mapping

2009-01-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478565


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #4 from Kevin Fenzi   2009-01-19 17:58:44 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478565] Review Request: gupnp-igd - Library to handle UPnP IGD port mapping

2009-01-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478565


Brian Pepple  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #3 from Brian Pepple   2009-01-18 17:55:25 EDT 
---
New Package CVS Request
===
Package Name: gupnp-igd
Short Description: Library to handle UPnP IGD port mapping
Owners: bpepple
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478565] Review Request: gupnp-igd - Library to handle UPnP IGD port mapping

2009-01-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478565





--- Comment #2 from Brian Pepple   2009-01-18 17:53:14 EDT 
---
(In reply to comment #1)
> Warning:
>  on Fedora branches <= 10, the devel package will Require gupnp-devel

Yeah, I'm not planning on adding this to any branches <= 10.  Thanks for the
review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478565] Review Request: gupnp-igd - Library to handle UPnP IGD port mapping

2009-01-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478565


Denis Leroy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||de...@poolshark.org
 AssignedTo|nob...@fedoraproject.org|de...@poolshark.org
   Flag||fedora-review+




--- Comment #1 from Denis Leroy   2009-01-18 16:54:06 EDT 
---
* Package name OK
* Source md5sum correct
* License is LGPLv2+
* Package works (able to compile tests and examples)
* Buidls, BR and R are OK
* %files section OK

* rpmlint

  - mixed-use of-spaces-and-tabs : can be ignored
  - unused-direct-shlib-dependency : could use the --as-needed sed trick, but
not a blocker


Warning:
 on Fedora branches <= 10, the devel package will Require gupnp-devel

Package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review