[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-01-21 16:28:26 EDT --- mingw32-dlfcn-0-0.3.r11.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Blocks||467416 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-01-17 06:54:01 EDT --- mingw32-dlfcn-0-0.3.r11.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-dlfcn-0-0.3.r11.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Adel Gadllah adel.gadl...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Adel Gadllah adel.gadl...@gmail.com 2009-01-16 05:54:01 EDT --- REVIEW: [+] = OK [-] = NOT OK [1] = SEE COMMENTS [?] = WTF? === [+] source files match upstream: sha1: 0b691107a23554d927987d4ddfca6e84dfd85313 [+] package meets naming and versioning guidelines. [+] specfile is properly named, is cleanly written and uses macros consistently. [+] dist tag is present. [+] build root is correct. [+] license field matches the actual license. [+] license is open source-compatible. LGPLv2+ [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [+] compiler flags are appropriate. [+] %clean is present. [+] package builds in koji. http://koji.fedoraproject.org/koji/taskinfo?taskID=1058151 [+] package installs properly. [1] rpmlint is silent. [+] final provides and requires are sane [+] no shared libraries are added to the regular linker search paths. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [+] no scriptlets present. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [2] no headers. [+] no pkgconfig files. [+] no libtool .la droppings. COMMENTS 1: not silent. mingw32-dlfcn.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libdl.dll.a mingw32-dlfcn.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/dlfcn.h mingw32-dlfcn.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libdl.dll.a mingw32-dlfcn.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 Those are fine thought (package used for cross compiling) 2: header is present, but its fine (cross compile package) Package looks good = APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Richard W.M. Jones rjo...@redhat.com 2009-01-16 06:36:04 EDT --- New Package CVS Request === Package Name: mingw32-dlfcn Short Description: Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror) Owners: rjones berrange lfarkas Branches: EL-5 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Blocks||467396 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|adel.gadl...@gmail.com Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi ke...@tummy.com 2009-01-16 22:22:14 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 --- Comment #7 from Richard W.M. Jones rjo...@redhat.com 2009-01-14 05:48:36 EDT --- dos2unix issue raised with FPC: https://www.redhat.com/archives/fedora-packaging/2009-January/msg00066.html Here's an updated package which reverts the dos2unix change and should fix everything else: Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/dlfcn/mingw32-dlfcn.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-dlfcn-0-0.3.r11.fc10.src.rpm * Wed Jan 14 2009 Richard W.M. Jones rjo...@redhat.com - 0-0.3.r11 - Use Version 0 (https://www.redhat.com/archives/fedora-packaging/2009-January/msg00064.html) - Revert use of dos2unix for now (https://www.redhat.com/archives/fedora-packaging/2009-January/msg00066.html) - Use _smp_mflags. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Summary|Review Request: dlfcn - |Review Request: |mingw32-dlfcn |mingw32-dlfcn - Implements ||a wrapper for dlfcn (dlopen ||dlclose dlsym dlerror) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478640
--- Comment #6 from Adel Gadllah adel.gadl...@gmail.com 2009-01-14 02:25:43
EDT ---
(In reply to comment #5)
(In reply to comment #4)
Fix it with sed in the %prep section: %{__sed} -i 's/\r//' src/somefile --
DONT use dos2unix, that can cause build fail on FC3.
Well you should stick to the guidelines even if FC3 is long dead.
I'm missing the context here. Was the above in reply to something?
Yeah forgot to quote the context:
- Use dos2unix and keep the timestamps.
dos2unix shouldn't be used, use sed instead. (see above quote from the
guidelines)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
