[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-08-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659


Jason Landstrom jjlandst...@gmail.com changed:

   What|Removed |Added

 CC||jjlandst...@gmail.com




--- Comment #7 from Jason Landstrom jjlandst...@gmail.com  2009-08-13 
13:51:13 EDT ---
I'm a newbie running Fedora 11 trying to run xfce4-screenshooter.  Everything
works great except when I select a region with copy to clipboard I am unable to
paste it into OpenOffice Impress like I can with gnome screenshot.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-08-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659





--- Comment #8 from Kevin Fenzi ke...@tummy.com  2009-08-13 14:15:27 EDT ---
This closed review is not the place for bugs. ;) 

Please file a new bug on the xfce4-screenshooter package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-08-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659





--- Comment #9 from Christoph Wickert christoph.wick...@googlemail.com  
2009-08-13 15:16:17 EDT ---
Filed as bug 517408.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-01-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659





--- Comment #6 from Fedora Update System upda...@fedoraproject.org  
2009-01-14 22:01:45 EDT ---
xfce4-screenshooter-1.4.90.0-1.fc10 has been pushed to the Fedora 10 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #4 from Kevin Fenzi ke...@tummy.com  2009-01-04 15:29:56 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659





--- Comment #5 from Fedora Update System upda...@fedoraproject.org  
2009-01-04 18:40:39 EDT ---
xfce4-screenshooter-1.4.90.0-1.fc10 has been submitted as an update for Fedora
10.
http://admin.fedoraproject.org/updates/xfce4-screenshooter-1.4.90.0-1.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659


Christoph Wickert fed...@christoph-wickert.de changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|ke...@tummy.com
Summary|Review Request: |Review Request:
   |xfce4-screensooter -|xfce4-screenshooter -
   |Screenshot utility for the  |Screenshot utility for the
   |Xfce desktop|Xfce desktop
   Flag||fedora-review?




--- Comment #1 from Kevin Fenzi ke...@tummy.com  2009-01-02 18:46:53 EDT ---
I'll review this. Look for a full review later tonight or this weekend.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #2 from Kevin Fenzi ke...@tummy.com  2009-01-03 01:04:17 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
1bcd5d2e7428c7ced039be87dfa30d74  xfce4-screenshooter-1.4.90.0.tar.gz
1bcd5d2e7428c7ced039be87dfa30d74  xfce4-screenshooter-1.4.90.0.tar.gz.orig
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
See below - No rpmlint output. 
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should have subpackages require base package with fully versioned depend. 
OK - Should have dist tag
OK - Should package latest version

Issues: 

1. rpmlint says: 
xfce4-screenshooter-plugin.x86_64: W: no-documentation

which can be ignored. 

2. I see you have
--add-only-show-in=XFCE
in the desktop file. Is that really intended?
Doesn't that lessen the need for splitting out the plugin, if 
it's only going to be used in Xfce anyhow? On the other hand, other 
DE's have their own screenshot applications, so perhaps thats adding too much 
clutter. In any case, up to you. 

Neither of these are blockers, so this package is 
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

2009-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659


Christoph Wickert fed...@christoph-wickert.de changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #3 from Christoph Wickert fed...@christoph-wickert.de  2009-01-03 
01:36:02 EDT ---
Regarding the OnlyShowIn: Both Gnome and KDE already have Screenshot Utilities,
so I'm maybe better of using NotShowIn=GNOME;KDE;

New Package CVS Request
===
Package Name: xfce4-screenshooter
Short Description: Screenshot utility for the Xfce desktop
Owners: cwickert
Branches: F-10
InitialCC:

(I don't think that renaming package in F-9 makes sense.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review