[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #12 from Peter Robinson pbrobin...@gmail.com 2009-02-03 15:07:30 EDT --- Closing. In rawhide and build for F-9 and F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 --- Comment #7 from Peter Robinson pbrobin...@gmail.com 2009-02-02 04:27:03 EDT --- I've got a response from the celt maintainer here: http://lists.xiph.org/pipermail/celt-dev/2009-February/63.html He's confirmed the license on all the files is BSD and will update them in the repo. Is there anything else outstanding for this review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 --- Comment #9 from Peter Robinson pbrobin...@gmail.com 2009-02-02 05:14:34 EDT --- Thanks Richard, Will update both of those before commit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Peter Robinson pbrobin...@gmail.com 2009-02-02 05:18:50 EDT --- New Package CVS Request === Package Name: celt Short Description: An audio codec for use in low-delay speech and audio communication Owners: pbrobinson xiphmont Branches: F-10 F-9 EL-4 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Richard W.M. Jones rjo...@redhat.com 2009-02-02 05:07:23 EDT --- OK, this is APPROVED. Before committing can you make two changes to the spec file: (1) Put README into %doc in the -devel subpackage. (2) Put a comment in the spec file with the link in comment 7. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi ke...@tummy.com 2009-02-02 23:26:25 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 --- Comment #5 from Peter Robinson pbrobin...@gmail.com 2009-01-20 03:58:10 EDT --- I've queried upstream about the license on the files. Can someone provide me a list of know files? I've had a quick look but not had enough time to look at all files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 --- Comment #6 from Richard W.M. Jones rjo...@redhat.com 2009-01-20 04:10:53 EDT --- Look at the files libcelt/*[ch] and query the ones which don't have license information in them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 Ray Strode rstr...@redhat.com changed: What|Removed |Added CC||rstr...@redhat.com --- Comment #4 from Ray Strode rstr...@redhat.com 2009-01-19 14:58:23 EDT --- Any updates on this, Peter? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added CC||lemen...@gmail.com Blocks||479750 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 Ray Strode rstr...@redhat.com changed: What|Removed |Added CC||cmont...@redhat.com --- Comment #3 from Ray Strode rstr...@redhat.com 2009-01-13 12:54:59 EDT --- *** Bug 479750 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478941 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||rjo...@redhat.com AssignedTo|nob...@fedoraproject.org|rjo...@redhat.com Flag||fedora-review? --- Comment #1 from Richard W.M. Jones rjo...@redhat.com 2009-01-12 04:49:22 EDT --- Taking for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478941] Review Request: celt - An audio codec for use in low-delay speech and audio communication
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478941
--- Comment #2 from Richard W.M. Jones rjo...@redhat.com 2009-01-12 14:11:33
EDT ---
- rpmlint output
celt-devel.x86_64: W: no-documentation
Just move (or duplicate) the README and TODO files into the
-devel subpackage.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
? license matches the actual package license
There's a number of source files (both *.c and *.h) that
don't contain explicit license information. Are we sure
about the origin of these files?
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
dd7cda953e4df448083b69af9afc15e1 401008
+ package successfully builds on at least one architecture
x86_64
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
http://koji.fedoraproject.org/koji/taskinfo?taskID=1047518
n/a %find_lang instead of %{_datadir}/locale/*
+ binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
+ header files should be in -devel
n/a static libraries should be in -static
+ packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
+ libfoo.so must go in -devel
+ -devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
Optional:
? if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock
http://koji.fedoraproject.org/koji/taskinfo?taskID=1047518
+ the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
+ scriptlets should be sane
+ pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
--
So there's that %doc thing to fix, and can you query upstream
about the libcelt/*.[ch] files which don't have license information
to find out who wrote them and/or where they came from.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
