[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #7 from Jason Tibbitts ti...@math.uh.edu  2009-11-19 13:02:18 EDT 
---
This is confusing; are you just asking for an EL-5 branch?  If so, in the
future please make a package change request according to
https://fedoraproject.org/wiki/CVS_admin_requests#Package_Change_Requests_for_existing_packages

I've created an EL-5 branch but made no other changes; if that's not what was
desired, please explain what you needed and set the fedora-cvs flag back to
'?'.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669


Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE




--- Comment #8 from Marcela Mašláňová mmasl...@redhat.com  2009-11-20 
02:39:57 EDT ---
(In reply to comment #7)
 This is confusing; are you just asking for an EL-5 branch?  If so, in the
 future please make a package change request according to
 https://fedoraproject.org/wiki/CVS_admin_requests#Package_Change_Requests_for_existing_packages
 
 I've created an EL-5 branch but made no other changes; if that's not what was
 desired, please explain what you needed and set the fedora-cvs flag back to
 '?'.  
I'm sorry I'll be using the correct request. Thank you for your changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669


Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

   Keywords||Reopened
 Status|CLOSED  |ASSIGNED
 Resolution|NEXTRELEASE |
   Flag|fedora-cvs+ |fedora-cvs?




--- Comment #6 from Marcela Mašláňová mmasl...@redhat.com  2009-11-18 
02:51:13 EDT ---
New Package CVS Request
===
Package Name: perl-File-pushd
Short Description: Change directory temporarily for a limited scope
Owners: mmaslano
Branches: EPEL-5
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-01-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669





--- Comment #4 from Marcela Maslanova mmasl...@redhat.com  2009-01-13 
03:16:55 EDT ---
I'm sorry, there's typo.

New Package CVS Request
===
Package Name: perl-File-pushd
Short Description: Change directory temporarily for a limited scope
Owners: mmaslano
Branches: F-10 devel
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-01-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Kevin Fenzi ke...@tummy.com  2009-01-13 15:41:16 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-01-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-01-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

 Blocks||479667




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-01-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-01-12 23:52:41 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1048549
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
c0d63d05db01a6da3aebd7cd6f93e520  File-pushd-1.00.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=37,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.19 cusr  0.05
csys =  0.26 CPU)

+ Package perl-File-pushd-1.00-1.fc11=
  Provides: perl(File::pushd) = 1.00
  Requires: perl = 0:5.004 perl(Carp) perl(Cwd) perl(Exporter)
perl(File::Path) perl(File::Spec) perl(File::Temp) perl(overload) perl(strict)


Suggestions:
1) Remove BuildRequires:  perl = 0:5.004 from spec.
2) remove Requires:   perl(Test::More) = 0.45 Not needed.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-01-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #2 from Marcela Maslanova mmasl...@redhat.com  2009-01-13 
01:25:30 EDT ---
Thank you for a quick review. The useless requirements will be removed before
pushing package into Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479669] Review Request: perl-File-pushd - Change directory temporarily for a limited scope

2009-01-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479669





--- Comment #3 from Marcela Maslanova mmasl...@redhat.com  2009-01-13 
01:26:41 EDT ---
New Package CVS Request
===
Package Name: perl-File-pushd
Short Description: Change directory temporarily for a limited scope
Owners: mmaslano
Branches: F-10 devel
InitialCC: perl-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review