[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480373 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480373 Adam Miller maxamill...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX --- Comment #10 from Adam Miller maxamill...@gmail.com 2009-02-23 18:16:45 EDT --- The project I was packaging this up for has been shut down. Closing Review Request, thank you for your time during the review. Very sorry for consuming unnecessary amounts of time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480373 --- Comment #9 from Adam Miller maxamill...@gmail.com 2009-02-18 15:44:54 EDT --- Very sorry, I have gotten a little bogged down with work, school, and trying to wrap up some other fedora related business. I will reference the guidelines and post back as soon as I am able. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480373 --- Comment #8 from Ian Weller ianwel...@gmail.com 2009-02-15 14:56:21 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480373
--- Comment #6 from Adam Miller maxamill...@gmail.com 2009-01-28 09:26:18
EDT ---
Spec URL: http://maxamillion.fedorapeople.org/cilk.spec
SRPM URL: http://maxamillion.fedorapeople.org/cilk-5.4.6-3.src.rpm
Added the %check, fixed the CFLAGS, also added the %{?_smp_mflags}
rpmlint still throws warning about devel-file-in-non-devel-package but i'm not
entirely sure that's a valid warning as the libs are specific to the app.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480373 --- Comment #7 from Ian Weller ianwel...@gmail.com 2009-01-28 09:52:29 EDT --- rpmlint still throws warning about devel-file-in-non-devel-package because you need a -devel subpackage for those files. See the packaging guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480373
--- Comment #5 from Ian Weller ianwel...@gmail.com 2009-01-25 00:44:56 EDT
---
- you need to add a %check section because make check is available
- please add %{?_smp_mflags} to the end of make
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480373 --- Comment #4 from Ian Weller ianwel...@gmail.com 2009-01-25 00:43:45 EDT --- - %dir isn't necessary in %files. you can just list the directory and it will automatically add all the files under it too (so get rid of the two lines under the %dir lines while you're at it) - rpmlint is very loud: cilk.src:23: W: configure-without-libdir-spec cilk.src:51: W: macro-in-%changelog optflags cilk.src: W: summary-ended-with-dot Language for multithreaded parallel programming. cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.a cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.g.p.a cilk.i386: W: devel-file-in-non-devel-package /usr/lib/cilk/libcilkrt0gp.a cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.p.so cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/gcc-builtin.h cilk.i386: W: devel-file-in-non-devel-package /usr/lib/cilk/libcilkrt0g.a cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.g.a cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.so cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk-sysdep.h cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.g.so cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk-conf.h cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk-cilk2c.h cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk-lib.h cilk.i386: W: devel-file-in-non-devel-package /usr/lib/cilk/libcilkrt0.a cilk.i386: W: devel-file-in-non-devel-package /usr/lib/cilk/libcilkrt0p.a cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.g.p.so cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk-cilk2c-pre.h cilk.i386: W: devel-file-in-non-devel-package /usr/lib/libcilk.p.a cilk.i386: W: devel-file-in-non-devel-package /usr/include/cilk/cilk.h cilk.i386: W: summary-ended-with-dot Language for multithreaded parallel programming. cilk.i386: W: shared-lib-calls-exit /usr/lib/libcilk.g.so.0.0.0 e...@glibc_2.0 cilk.i386: W: shared-lib-calls-exit /usr/lib/libcilk.p.so.0.0.0 e...@glibc_2.0 cilk.i386: W: shared-lib-calls-exit /usr/lib/libcilk.g.p.so.0.0.0 e...@glibc_2.0 cilk.i386: W: shared-lib-calls-exit /usr/lib/libcilk.so.0.0.0 e...@glibc_2.0 3 packages and 0 specfiles checked; 0 errors, 27 warnings. - why did you replace %configure? - you can use %configure CFLAGS=%(echo %optflags | sed -e 's/-pipe//' | sed -e 's/--param=ssp-buffer-size=4//') instead of getting rid of the compiler flags altogether. This keeps cilkclocal happy and keeps most of the compiler flags. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480373 --- Comment #3 from Adam Miller maxamill...@gmail.com 2009-01-20 00:21:56 EDT --- Spec URL: http://maxamillion.fedorapeople.org/cilk.spec SRPM URL: http://maxamillion.fedorapeople.org/cilk-5.4.6-2.src.rpm Fixed the license field and prematurely filed the request without running in mock, the %optflags are slapped into %configure and the '-pipe' is what is causing the failure in the package build. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480373 Ian Weller ianwel...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ianwel...@gmail.com AssignedTo|nob...@fedoraproject.org|ianwel...@gmail.com --- Comment #1 from Ian Weller ianwel...@gmail.com 2009-01-16 22:11:23 EDT --- I'll review this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480373 Ian Weller ianwel...@gmail.com changed: What|Removed |Added Flag||fedora-review? --- Comment #2 from Ian Weller ianwel...@gmail.com 2009-01-16 22:26:45 EDT --- Things I see right now: License field in spec matches: Fail -- The license is GPLv2+: license text in main.c and other files reads or an other version Package compiles and builds on at least one arch: Fail -- See these Koji logs. http://koji.fedoraproject.org/koji/getfile?taskID=1060419name=build.log What is this? -pipe -- near end of log. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
