[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #12 from Lubomir Rintel lkund...@v3.sk 2009-03-10 18:26:17 EDT --- too late :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 --- Comment #7 from Felix Kaechele fe...@fetzig.org 2009-01-21 03:54:29 EDT --- I didn't meant to sound harsh. If you felt offended by the way I wrote my comment I hereby apologize for that. For reference here is the Guideline on desktop files: https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage It says: For new packages, do not apply a vendor tag to desktop files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 --- Comment #8 from Šimon Lukašík luka...@atlas.cz 2009-01-21 04:06:42 EDT --- https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage Imho it has changed during this review. I saw old vendor tag here few hours ago. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 --- Comment #10 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-21 04:20:59 EDT --- (In reply to comment #9) It was just wiki package was not updated. wiki page was (not updated) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 --- Comment #9 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-21 04:18:27 EDT --- Actually this desktop-file-install usage change (i.e. that for new packages --vendor=fedora is removed) took place in last October: http://www.redhat.com/archives/fedora-devel-list/2008-October/msg02273.html http://fedoraproject.org/wiki/Packaging/Minutes/20081021 It was just wiki package was not updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 --- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-21 04:40:33 EDT --- So please remove --vendor=fedora from desktop-file-install. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 Šimon Lukašík luka...@atlas.cz changed: What|Removed |Added CC||luka...@atlas.cz AssignedTo|nob...@fedoraproject.org|luka...@atlas.cz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 Šimon Lukašík luka...@atlas.cz changed: What|Removed |Added Flag||fedora-review+ --- Comment #1 from Šimon Lukašík luka...@atlas.cz 2009-01-20 12:02:42 EDT --- Simple and neat package to me. Rpmlint is silent, mock build ok. Package meets all *MUST* items. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 Felix Kaechele fe...@fetzig.org changed: What|Removed |Added CC||fe...@fetzig.org --- Comment #2 from Felix Kaechele fe...@fetzig.org 2009-01-20 14:06:23 EDT --- -1 from my side here. - Does not yield the guidelines for icon cache as stated here: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache - desktop-file-install must not use a vendor. See https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor Reviews should definitely be made more thorough and conscientious. It would be great if you also checked the SHOULD items. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Lubomir Rintel lkund...@v3.sk 2009-01-20 14:25:24 EDT --- (In reply to comment #2) -1 from my side here. - Does not yield the guidelines for icon cache as stated here: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache As far as I understand, these are just best practices, not part of guidelines. Guidelines just read If scriptlets are used, those scriptlets must be sane.. When it comes to my scriptlet, it is functionally equivalent and only difference is harmless error output in case gtk-update-icon-cache. Given it is an aesthetic annoyance, I'll use the other version when importing the package, but this is definitely not a reason for blocking the review. Moreover, the first form is already used in packages, and referred to in wiki: http://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets/iconcache - desktop-file-install must not use a vendor. See https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor Wrong again. This is not a guideline. Actually, the guideline says the opposite: If upstream uses vendor_id, leave it intact, otherwise use fedora asvendor_id. See: https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage Reviews should definitely be made more thorough and conscientious. It would be great if you also checked the SHOULD items. I'd be very thankful if you refrained from being harsh to other contributors at least until you study the packaging guidelines. Thanks! (In reply to comment #1) Simple and neat package to me. Rpmlint is silent, mock build ok. Package meets all *MUST* items. APPROVED. Diky za review! New Package CVS Request === Package Name: tunneler Short Description: Clone of legendary Tunneler game Owners: lkundrak Branches: EL-5 F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-01-20 16:04:58 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 Simon Wesp cassmod...@fedoraproject.org changed: What|Removed |Added CC||cassmod...@fedoraproject.or ||g --- Comment #5 from Simon Wesp cassmod...@fedoraproject.org 2009-01-20 16:19:50 EDT --- no F-9 ??? Lubomir, please add F-9 to active branches for this package... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480771] Review Request: tunneler - Clone of legendary Tunneler game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480771 --- Comment #6 from Lubomir Rintel lkund...@v3.sk 2009-01-20 16:27:02 EDT --- New Package CVS Request === Package Name: tunneler Short Description: Clone of legendary Tunneler game Branches: EL-5 F-10 Owners: lkundrak Branches: F-9 Owners: cassmodiah -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
