[Bug 481040] Review Request: skyeye - integrated simulation environment for typical Embedded Computer Systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481040 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG --- Comment #7 from manuel wolfshant wo...@nobugconsulting.ro 2009-04-15 14:40:21 EDT --- The project we were using this tool for has ended, so my interest for this packaged kind of vanished. And since no one seems interested in doing a review, I am retiring this review request. Thanks Chitlesh and Aanjhan for the support. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481040] Review Request: skyeye - integrated simulation environment for typical Embedded Computer Systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481040 Chitlesh GOORAH chitl...@gmail.com changed: What|Removed |Added CC||aanj...@tuxmaniac.com --- Comment #5 from Chitlesh GOORAH chitl...@gmail.com 2009-02-25 13:21:44 EDT --- Aanjhaan, could you please have a look at this package and see if you can improve it. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481040] Review Request: skyeye - integrated simulation environment for typical Embedded Computer Systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481040 --- Comment #6 from Aanjhan Ranganathan aanj...@tuxmaniac.com 2009-02-25 18:52:01 EDT --- Firstly, I updated the SPEC and SRPM for the latest upstream release which was done 4 days back. Will look into the warnings now. But in the meanwhile request a review of the update. http://tuxmaniac.fedorapeople.org/SPECS/skyeye.spec http://tuxmaniac.fedorapeople.org/skyeye-1.2.7-1.rc1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481040] Review Request: skyeye - integrated simulation environment for typical Embedded Computer Systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481040 --- Comment #4 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-31 20:11:43 EDT --- (In reply to comment #2) * Source code quality: Building on FC10 exposes an exciting amount of not-so-harmless warnings. Some of them definitely are worth going after and be fixed. Hello Ralf, can you help to improve those warnings please? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481040] Review Request: skyeye - integrated simulation environment for typical Embedded Computer Systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481040 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #2 from Ralf Corsepius rc040...@freenet.de 2009-01-24 02:57:35 EDT --- Some remarks on your spec: * BuildRequires: BuildRequires:openssh, binutils I don't understand why you BR: openssh. BR: binutils definitely is redundant. Could it be, you intend to BR: binutils-devel to pull in libiberty? BuildRequires:glib-devel, xorg-x11-proto-devel BR: glib-devel is very likely wrong (glib-devel is a glib1 package). You likely intend to pull in glib2-devel, which already is implicitly pulled in by BR: gtk2-devel BR: xorg-x11-proto-devel I don't see any need to BR: this. [You seem to be building on fc7. This could explain some of your BR's above, because IIRC, several of the packages you reference have seem some significant packaging cleanups since then.] * Source code quality: Building on FC10 exposes an exciting amount of not-so-harmless warnings. Some of them definitely are worth going after and be fixed. [I have never used skeeye myself, but co-workers, I occasionally work with are using it - AFAICT, they never managed to get skeeye working on x86_64. I can ask them on next occasion ;)] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481040] Review Request: skyeye - integrated simulation environment for typical Embedded Computer Systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481040 --- Comment #3 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-24 06:56:09 EDT --- Thanks for the sharp eye and suggestions, Ralf. BuildRequires: openssh, binutils I don't understand why you BR: openssh. Because I trusted upstream (http://skyeye.wiki.sourceforge.net/UM8 ) BR: binutils definitely is redundant. Could it be, you intend to BR: binutils-devel to pull in libiberty? Indeed. Fixed. For whoever looks at the build log: configure lies. -lbfd and -liberty are used later on, despite %configure saying they were not found. BR: glib-devel is very likely wrong (glib-devel is a glib1 package). You likely intend to pull in glib2-devel, which already is implicitly pulled in by BR: gtk2-devel You are correct. Fixed BR: xorg-x11-proto-devel I don't see any need to BR: this. More cruft from upstream (You may need to check following packages are exsiting ...x11-dev) [You seem to be building on fc7.] Nope, I am building only in mock for EL-4,5 and rawhide. It just happens that my workstation (hence rpmbuild -bs) is F7. After approval the package should land in EL-5 ( that's where my major interest is ) and F=10. Other versions only if I receive word that it's functional and someone volunteers for maintainance. * Source code quality: Building on FC10 exposes an exciting amount of not-so-harmless warnings. Some of them definitely are worth going after and be fixed. I feel like I need to expose a bit of collateral background here: some of my colleagues needed to use skyeye on Centos-5 and needed it fast. So I figured that rather a configure/make/... mantra I'd rather package it (quickly). Using it did not reveal anything major (at least no one cried so far) so I figured that maybe including it in fedora would not be a bad idea. Chitlesh provided the small patch which allows compilation in Fedora and volunteered for co-maintainership so here I was with the bz. As of fixing: I will gladly pass upstream any fix that we (we as in Fedora community) come up with. However my programming skills are rusty (I've given up this sport a long time ago) and I do not feel like being able to give birth to fixes [ for skyeye ] myself (unless they are very obvious) Spec URL: http://wolfy.fedorapeople.org/skyeye/skyeye.spec SRPM URL: http://wolfy.fedorapeople.org/skyeye/skyeye-1.2.6-4.rc1.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481040] Review Request: skyeye - integrated simulation environment for typical Embedded Computer Systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481040 --- Comment #1 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-23 10:04:50 EDT --- New version, with cosmetic fixes ( removal of redundant or duplicate BRs ): Spec URL: http://wolfy.fedorapeople.org/skyeye/skyeye.spec SRPM URL: http://wolfy.fedorapeople.org/skyeye/skyeye-1.2.6-3.rc1.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481040] Review Request: skyeye - integrated simulation environment for typical Embedded Computer Systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481040 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added URL||http://www.skyeye.org/index ||.shtml CC||cgoo...@yahoo.com.au -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
