[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|needinfo?(ianburr...@gmail. | |com)| --- Comment #15 from Lubomir Rintel lkund...@v3.sk 2009-03-30 16:17:02 EDT --- Confirmed with upstream, clarified in the package. Fixed on PowerPC. I'm a bit worried about the package, since Ian doesn't respond (hope he's doing well), but let's assume perl-sig in watchbugzilla is enough to ensure the package is being cared about. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484323
Robert Scheck redhat-bugzi...@linuxnetz.de changed:
What|Removed |Added
CC||redhat-bugzi...@linuxnetz.d
||e
--- Comment #13 from Robert Scheck redhat-bugzi...@linuxnetz.de 2009-03-29
07:40:06 EDT ---
What's the issue with licensing? As per comment #7 our Fedora Legal seems to
be already fine. Which other issues are there now?
Currently, the packages are failing on ppc and ppc64 (endian things?), maybe
we can just ExcludeArch (or even fix) them?
Anyway I'm suggesting the upgrade to 0.164 as well as adding two missing build
requirements for %check section.
Index: perl-KinoSearch.spec
===
RCS file: /cvs/pkgs/rpms/perl-KinoSearch/devel/perl-KinoSearch.spec,v
retrieving revision 1.4
diff -u -r1.4 perl-KinoSearch.spec
--- perl-KinoSearch.spec26 Feb 2009 20:33:09 - 1.4
+++ perl-KinoSearch.spec29 Mar 2009 11:36:30 -
@@ -1,6 +1,6 @@
Name: perl-KinoSearch
-Version:0.163
-Release:4%{?dist}
+Version:0.164
+Release:1%{?dist}
Summary:Search engine library
License:GPL+ or Artistic
Group: Development/Libraries
@@ -13,6 +13,8 @@
BuildRequires: perl(Lingua::Stem::Snowball) = 0.94
BuildRequires: perl(Lingua::StopWords) = 0.02
BuildRequires: perl(Module::Build)
+BuildRequires: perl(Test::Pod::Coverage) = 1.04
+BuildRequires: perl(Test::Pod) = 1.14
Requires: perl(Compress::Zlib)
Requires: perl(Lingua::Stem::Snowball) = 0.94
Requires: perl(Lingua::StopWords) = 0.02
+ ./Build test
t/000-load.t .. ok
t/001-build_invindexes.t .. ok
t/002-kinosearch.t ok
t/010-verify_args.t ... ok
t/011-class.t . ok
t/012-priority_queue.t ok
t/013-bit_vector.t ok
t/015-sort_external.t . ok
# Failed test 'signed byte'
# at t/101-simple_template_io.t line 21.
# Structures begin differing at:
# $got-[0] = '128'
# $expected-[0] = '-128'
# Looks like you failed 1 test of 13.
t/101-simple_template_io.t
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/13 subtests
t/102-strings_template_io.t ... ok
# Failed test 'b2'
# at t/103-repeats_template_io.t line 20.
# Structures begin differing at:
# $got-[0] = '128'
# $expected-[0] = '-128'
# Failed test 'b131'
# at t/103-repeats_template_io.t line 20.
# Structures begin differing at:
# $got-[0] = '128'
# $expected-[0] = '-128'
# Failed test 'b149'
# at t/103-repeats_template_io.t line 20.
# Structures begin differing at:
# $got-[0] = '128'
# $expected-[0] = '-128'
# Failed test 'b256'
# at t/103-repeats_template_io.t line 20.
# Structures begin differing at:
# $got-[0] = '128'
# $expected-[0] = '-128'
# Looks like you failed 4 tests of 18.
t/103-repeats_template_io.t ...
Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/18 subtests
t/104-parse_template_io.t . ok
t/105-invindex.t .. ok
Lockfile looks dead - removing at
/builddir/build/BUILD/KinoSearch-0.164/blib/lib/KinoSearch/Store/FSLock.pm line
40.
t/106-locking.t ... ok
t/150-polyanalyzer.t .. ok
t/152-token_batch.t ... ok
t/153-lc_normalizer.t . ok
t/154-tokenizer.t . ok
t/155-stopalizer.t ok
t/201-field_infos.t ... ok
t/202-term.t .. ok
t/203-compound_file_reader.t .. ok
t/204-fields_reader.t . ok
t/205-seg_reader.t ok
t/206-seg_infos.t . ok
t/207-seg_term_enum.t . ok
t/208-terminfo.t .. ok
t/209-term_infos_reader.t . ok
t/210-deldocs.t ... ok
t/211-seg_term_docs.t . ok
t/212-multi_term_docs.t ... ok
t/213-segment_merging.t ... ok
t/214-spec_field.t ok
t/302-many_fields.t ... ok
t/303-highlighter.t ... ok
t/501-termquery.t . ok
t/502-phrasequery.t ... ok
t/503-booleanquery.t .. ok
t/504-similarity.t ok
t/505-hit_queue.t . ok
t/506-hit_collector.t . ok
t/507-query_filter.t .. ok
t/508-hits.t .. ok
t/509-multi_searcher.t ok
t/510-remote_search.t . ok
t/601-queryparser.t ... ok
t/602-boosts.t ok
t/603-query_boosts.t .. ok
t/604-simple_search.t . ok
t/701-uscon.t . ok
t/999-remove_invindexes.t . ok
t/pod-coverage.t .. skipped: Only run during development
t/pod.t ... ok
Test Summary
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 --- Comment #14 from Kevin Fenzi ke...@tummy.com 2009-03-29 13:16:17 EDT --- What's the issue with licensing? As per comment #7 our Fedora Legal seems to be already fine. Which other issues are there now? See comment #5 item 2. The License in the spec is currently GPL+ or Artistic, this MUST be confirmed with upstream before we know ASL doesn't matter here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 --- Comment #12 from Lubomir Rintel lkund...@v3.sk 2009-03-22 17:04:02 EDT --- I've sent a mail upstream myself today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Bug 484323 depends on bug 484321, which changed state. Bug 484321 Summary: Review Request: perl-Lingua-StopWords - Stop words for several languages https://bugzilla.redhat.com/show_bug.cgi?id=484321 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 --- Comment #10 from Lubomir Rintel lkund...@v3.sk 2009-02-26 21:18:58 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Flag||needinfo?(ianburr...@gmail. ||com) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added CC||ke...@tummy.com --- Comment #11 from Kevin Fenzi ke...@tummy.com 2009-02-27 11:18:53 EDT --- Ian: Can we please make sure the license is right before doing builds? Did you query upstream about the ASL issue? what was the reply? Please don't build until this is all figured out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 --- Comment #9 from Lubomir Rintel lkund...@v3.sk 2009-02-19 10:48:46 EDT --- Ian: I see you've attempted the builds, but still haven't clarified the situation with the License. Your build failed on ppc, please don't trigger any more builds until the problem with license is resolved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 | --- Comment #7 from Tom spot Callaway tcall...@redhat.com 2009-02-12 13:25:30 EDT --- I'm fine with Lubomir's assessment in Comment #5. Lifting FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Kevin Fenzi ke...@tummy.com 2009-02-13 01:42:44 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Ian Burrell ianburr...@gmail.com 2009-02-11 19:55:19 EDT --- New Package CVS Request === Package Name: perl-KinoSearch Short Description: Search engine library Owners: iburrell Branches: F-9 F-10 EL-5 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-02-09 09:58:30 EDT --- Hah, I just need this todaym Ian, I owe you a beer. Taking it for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Blocks||182235 --- Comment #2 from Lubomir Rintel lkund...@v3.sk 2009-02-09 10:23:38 EDT --- 0.) This is redundant: Requires: perl(Compress::Zlib) It gets added by the auroreq generator. 1.) rpmlint: perl-KinoSearch.i386: E: zero-length /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/KinoSearch/KinoSearch.bs 2.) License: I'm worried about this, and am blocking the review until it is solved. The perldoc reads: Terms of usage for Apache Lucene, from which portions of KinoSearch are derived, are spelled out in the Apache License: see the file ApacheLicense2.0.txt. While the original code is licensed GPL+ or Artistic. If my understanding of things is correct, we can't choose GPL since it does not permit redistribution when linked with ASL code and we can't choose Artistic either, since it's incompatible with Fedora. I think a clarification and eventually and addition of exception to allow linking with ASL from upstream would be good here. IANAL, I might be completely wrong. Adding spot to CC, he may provide valuable advice. In other respects, the package is perfect: - SPEC file clean and legible - Builds in mock, obeys compiler flags - rpmlint is mostly quiet (see 1.) - requires/provides (mostly, see 0.) sane - ASL license 2.0 text included (heh...) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Chris Weyl cw...@alumni.drew.edu changed: What|Removed |Added CC||cw...@alumni.drew.edu --- Comment #3 from Chris Weyl cw...@alumni.drew.edu 2009-02-09 16:14:35 EDT --- w.r.t. license, my take is: Original bits are under GPL+ or Artistic (perl), derived bits under the ASL2.0; the Fedora list of good license indicates that ASL2.0 is compatible with the terms of the GPLv3, so we should redistribute the entire thing under GPLv3+ (since GPL+ - GPLv3+ w/o problem). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 --- Comment #4 from Ian Burrell ianburr...@gmail.com 2009-02-09 17:25:44 EDT --- I am pretty sure that none of the code is under ASL 2.0. The Perl code is derived from Lucene (which is in Java) but it is a rewrite (and not even a straight port like Plucene). The ASL 2.0 in section 4 allows derivative works to have separate copyright as long as the conditions are met. Including the ASL license and the notice in the docs is one of the conditions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Lubomir Rintel lkund...@v3.sk 2009-02-10 02:02:35 EDT --- (In reply to comment #3) w.r.t. license, my take is: Original bits are under GPL+ or Artistic (perl), derived bits under the ASL2.0; the Fedora list of good license indicates that ASL2.0 is compatible with the terms of the GPLv3, so we should redistribute the entire thing under GPLv3+ (since GPL+ - GPLv3+ w/o problem). Mostly right. Yes. I don't know why I thought ASL2.0 is incompatible with all GPL versions. I was even looking at the compatibility matrix and did not notice that. One small correction would be that the resulting license is GPLv3 not GPLv3+, since we can't tell whether ASL is compatible with license that doesn't even exist. Much thanks for pointing this out Chris, I've obviously not have figured that myself and it clarifies things a lot. (In reply to comment #4) I am pretty sure that none of the code is under ASL 2.0. The Perl code is derived from Lucene (which is in Java) but it is a rewrite (and not even a straight port like Plucene). The ASL 2.0 in section 4 allows derivative works to have separate copyright as long as the conditions are met. Including the ASL license and the notice in the docs is one of the conditions. I've really looked at the code yesterday and haven't found anything copied from lucene, so my feelings are that the ASL license is here just in case. So my recommendations here are either of 1.) Set the License to GPLv3 and comment appropriately 2.) Ensure (check with upstream) there's no ASL code, remove the ASL license file and leave License set to GPL+ or Artistic (recommended, but don't do that w/o contacting upstream) This can't block a review: APPROVED Please address the points 0.) and 1.) of comment #2 upon import. (I'll check! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Depends on||484321 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484323] Review Request: perl-KinoSearch - Search engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484323 Ian Burrell ianburr...@gmail.com changed: What|Removed |Added Depends on||484320 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
