[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 Simon Wesp cassmod...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #16 from Simon Wesp cassmod...@fedoraproject.org 2009-02-22 12:23:33 EDT --- Included in F-10 devel and epel-5 i forgot to close the bug via bodhi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 --- Comment #12 from Simon Wesp cassmod...@fedoraproject.org 2009-02-16 15:46:12 EDT --- mh, replace autoreconf with autoconf for a better koji-compatibility Spec URL: http://cassmodiah.fedorapeople.org/hosts3d-0.97/hosts3d.spec SRPM URL: http://cassmodiah.fedorapeople.org/hosts3d-0.97/hosts3d-0.97-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #13 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-16 15:54:19 EDT --- Good: + Koji build works fine. *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 Simon Wesp cassmod...@fedoraproject.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Simon Wesp cassmod...@fedoraproject.org 2009-02-16 15:58:04 EDT --- thank you Jochen. New Package CVS Request === Package Name: hosts3d Short Description: 3D real-time network visualiser Owners: cassmodiah Branches: F-10 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #15 from Kevin Fenzi ke...@tummy.com 2009-02-16 16:16:09 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 --- Comment #9 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-15 14:50:03 EDT --- An additional change: It may be nice, if you can add the autoreconf command before the %configure statemant. The task of the autoreconf command is to make sure, that the configure.in file may be generated on the base of the configure.ac file, which will be patched by my suggested patch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 --- Comment #10 from Simon Wesp cassmod...@fedoraproject.org 2009-02-15 15:28:16 EDT --- Spec URL: http://cassmodiah.fedorapeople.org/hosts3d-0.97/hosts3d.spec SRPM URL: http://cassmodiah.fedorapeople.org/hosts3d-0.97/hosts3d-0.97-2.fc10.src.rpm done! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 --- Comment #11 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-15 15:44:51 EDT --- Good: + autoconf was added as an BR. + autoreconf was called before %configure + Local build works fine + Local install works fine + Local uninstall works fine + Start of the application works without a crash Bad: - Build fails on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1128556 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 --- Comment #8 from Simon Wesp cassmod...@fedoraproject.org 2009-02-13 05:56:24 EDT --- Thank you, i emailed this patch to upstream. I'm in a good contact with him :-) I will continue today and i hope we finished it soon. Thank you -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484931
--- Comment #5 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-12
11:38:17 EDT ---
Good:
+ Base name of the SPEC file metches with package name.
+ Package name fullfill the naming guidelines
+ Package contains current release of the application
+ Could download sources from upstream
+ Packaged souces metches with upstream one.
(md5sum: 260c55fe010520cbe894c97b224f996b)
+ Package contains valid license tag
+ License tag contains GPLv2+ as an valid OSS license
+ License on the license tag fit with copyright note of
the included source files
+ Package contains verbatin copy of the license text
+ Proper use of the %{?dist] tag
+ Proper defintion of the Buildroot
+ Buildroot will been cleaned on the beginning of %clean and %install
+ Consistently rpm macro usage
+ Package use parallel build
+ Local build works fine.
+ Koji build works fine.
+ Rpmlint is quite on source rpm
+ Rpmlint is quite on binary rpm
+ Rpmlint is quite on debuginfo package
+ Files hat proper files permissions
+ %files stanza has no duplicated entries
+ All packaged files are owned by the package
+ %doc stanza is small, so we need no deparate subpackage
+ package contains desktop entry file.
+ Proper %changelog
Bad:
- Please change Provides of the main package and the subpackage as
discussed in comment #3
- Package doesn't honor $RPM_OPT_FLAGS
- Please remove the -p switch on make install
- Debuginfo package contains no sources
Question:
* Does the sampler subpackage not requires the main subpackage?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 --- Comment #7 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-12 13:51:01 EDT --- Created an attachment (id=331729) -- (https://bugzilla.redhat.com/attachment.cgi?id=331729) Suggested SPEC file with include proposal Patch This SPEC file use a patch attached to this review request to patch the configure script. this is required, because the configure script overwrites the CXXFLAGS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484931
--- Comment #6 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-12
13:48:14 EDT ---
Created an attachment (id=331728)
-- (https://bugzilla.redhat.com/attachment.cgi?id=331728)
Patch to get honor %{optflags}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484931
Jussi Lehtola jussi.leht...@iki.fi changed:
What|Removed |Added
CC||jussi.leht...@iki.fi
--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi 2009-02-11 03:06:42
EDT ---
Now the package
Provides:homestead = 0.95-1
Obsoletes: homestead 0.95-1
but the current version in F10 is homestead-0.95-1, which won't be obsoleted.
Change this to
Provides:homestead = %{version}-%{release}
Obsoletes: homestead %{version}-%{release}
or just remove the versioning from Provides Obsoletes?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484931
Jochen Schmitt joc...@herr-schmitt.de changed:
What|Removed |Added
CC||joc...@herr-schmitt.de
--- Comment #2 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-11
16:20:17 EDT ---
I think, you should wrote
Provides:homestead = %{version}-%{release}
Obsoletes: homestead 0.95-1
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484931
--- Comment #3 from Simon Wesp cassmod...@fedoraproject.org 2009-02-11
16:29:30 EDT ---
-
Provides:homestead = %{version}-%{release}
Obsoletes: homestead 0.95-1
-
Perhaps THIS way?! This looks correct and make sense (to me)!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484931 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|joc...@herr-schmitt.de --- Comment #4 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-11 16:41:20 EDT --- Review will be done tomorrow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
