[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485496 --- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-02-18 12:13:52 EDT --- Please rebuild this package also on F-10 branch, and for F-10 submit a request to push the rebuilt package into repository on bodhi: https://admin.fedoraproject.org/updates/ When it is done, please close this bug as NEXTRELEASE. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485496 Dodji Seketeli do...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485496 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-02-16 16:35:03 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485496 --- Comment #3 from Dodji Seketeli do...@redhat.com 2009-02-15 10:26:55 EDT --- I forgot to say that a new srpm and spec are available at: SRPM: http://people.redhat.com/~dseketel/rpms/geglmm/geglmm-0.0.22-2.fc10.src.rpm SPEC: http://people.redhat.com/~dseketel/rpms/geglmm/geglmm.spec-0.0.22-2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485496
--- Comment #2 from Dodji Seketeli do...@redhat.com 2009-02-15 10:23:02 EDT
---
{?dist} macro:
https://fedoraproject.org/wiki/Packaging/DistTag
Done.
- Source0 must be given with full URL:
https://fedoraproject.org/wiki/Packaging/SourceURL
Done.
- gegl-devel Requires babl-devel, so BuildRequires: babl-devel
is redundant.
I Removed babl-devel.
- Usually the dependencies between binary rpms rebuilt from
a srpm must be EVR (not just version) specific.
https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package
Done.
- This srpm won't build on dist-f11:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1126647
Ah. It builds on f10 that's why I didn't notice that. I will now use mock.
So I did a patch to fix this issue. The patch has been submitted upstream.
While at it, I produced another patchlet to kill some warnings. That patch has
been submitted upstream as well.
- We recommend %defattr(-,root,root,-)
Done.
- Please consider to add the following files
AUTHORS
COPYING
COPYING.LESSER
to main package and
ChangeLog
to -devel package.
Done.
Thanks for the quick review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485496
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Depends on|177841 |
Flag|fedora-review? |fedora-review+
--- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-02-15
11:11:22 EDT ---
Okay.
- I recommend to use %{version} in Source0
ref:
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D
If you want to change, please fix this when importing into
Fedora CVS.
---
This package (geglmm) is APPROVED by mtasaka
---
Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from Install the Client Tools (Koji).
Now I am sponsoring you.
If you want to import this package into Fedora 9/10, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).
If you have questions, please ask me.
Removing NEEDSPONSOR.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485496 Dodji Seketeli do...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485496 --- Comment #5 from Dodji Seketeli do...@redhat.com 2009-02-15 12:21:56 EDT --- Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485496 --- Comment #6 from Dodji Seketeli do...@redhat.com 2009-02-15 12:23:16 EDT --- New Package CVS Request === Package Name: geglmm Short Description: A graphic processing library, C++ bindings Owners: dodji Branches: F-10 InitialCC: dodji -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485496
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
Flag||fedora-review?
--- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-02-14
12:33:40 EDT ---
(In reply to comment #0)
It's spitting an only-non-binary-in-usr-lib error, and I think it's because of
the things that are being install in %{_libdir}, like the m4 files, the
pkgconfig files and the configuration header files.
+ rpmlint won't complain for pkgconfig file as only-non-binary-in-usr-lib,
however for m4 files and header file rpmlint currently complains.
For this package this rpmlint can be ignored.
Then:
Some random notes:
- Please consider to use %{?dist} macro:
https://fedoraproject.org/wiki/Packaging/DistTag
- Source0 must be given with full URL:
https://fedoraproject.org/wiki/Packaging/SourceURL
- gegl-devel Requires babl-devel, so BuildRequires: babl-devel
is redundant.
- Usually the dependencies between binary rpms rebuilt from
a srpm must be EVR (not just version) specific.
https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package
- This srpm won't build on dist-f11:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1126647
- We recommend %defattr(-,root,root,-)
- Please consider to add the following files
AUTHORS
COPYING
COPYING.LESSER
to main package and
ChangeLog
to -devel package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485496] Review request of geglmm - the C++ Binding to the GEGL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485496 Dodji Seketeli do...@redhat.com changed: What|Removed |Added Depends on||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
