[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||6.12.2-3.fc9 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2009-03-09 18:43:23 EDT --- dc3dd-6.12.2-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-03-09 18:57:10 EDT --- dc3dd-6.12.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|6.12.2-3.fc9|6.12.2-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-03-06 10:21:42 EDT --- dc3dd-6.12.2-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/dc3dd-6.12.2-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-03-06 10:21:37 EDT --- dc3dd-6.12.2-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/dc3dd-6.12.2-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 --- Comment #4 from Adam Miller maxamill...@gmail.com 2009-03-05 12:20:40 EDT --- Spec URL: http://maxamillion.fedorapeople.org/dc3dd.spec SRPM URL: http://maxamillion.fedorapeople.org/dc3dd-6.12.2-3.src.rpm I applied the cleanup and I inspected the source of a number of the files in the build-aux directory and they appear to just be a cludge of python scripts that provide work arounds for different build environments and/or compilers that don't support certain things. Thank you again for your comments, looking forward to further review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-05 13:17:07 EDT --- So, those files are irrelevant. Then I think everything is fine now. You're welcome This package (dc3dd) is APPROVED by oget -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 Adam Miller maxamill...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Adam Miller maxamill...@gmail.com 2009-03-05 13:40:11 EDT --- New Package CVS Request === Package Name: dc3dd Short Description: Patched version of GNU dd for use in computer forensics Owners: maxamillion Branches: F-9 F-10 EL-4 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-03-05 15:24:18 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487052 --- Comment #2 from Adam Miller maxamill...@gmail.com 2009-03-03 09:48:19 EDT --- Spec URL: http://maxamillion.fedorapeople.org/dc3dd.spec SRPM URL: http://maxamillion.fedorapeople.org/dc3dd-6.12.2-2.src.rpm I've cleaned up everything listed above. I fixed the licensing, removed the .gmo binaries, fixed source0 (sorry for that one, I based this spec off another spec of mine and mixed that up), added the doc items you listed, and fixed EOF encoding for the current and two added files to the package. Thank you very much for your feedback and I look forward to further review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=487052
--- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-03
21:31:22 EDT ---
Thanks for the update.
* To clean up the SPEC file you can use a for-loop like:
for file in README Sample_Commands.txt Options_Reference.txt; do
sed 's|\r||' $file $file.tmp
touch -r $file $file.tmp
mv -f $file.tmp $file
done
* You probably missed this question I asked:
? What is the directory build-aux and the executable files in the root of the
source tree for?
The reason I asked was: If these files run tests to check whether the
application is compiled properly, you will need to make a %check section and
run these tests.
On the other hand, if these scripts are useful for people who want to
use/develop dc3dd, you might want to put them in %{_datadir}/%{name} or inside
%doc.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487052] Review Request: dc3dd - Patched version of GNU dd for use in computer forensics
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=487052
Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||oget.fed...@gmail.com
AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
Flag||fedora-review?
--- Comment #1 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-01
02:23:09 EDT ---
I had a look at this package. Here are my notes:
! Not a blocker but a suggestion: The recommended buildroot values are given in
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
* Source0 is wrong.
* rpmlint says:
dc3dd.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/dc3dd-6.12.2/README
You can probably correct this with
sed 's|\r||' README README.tmp
touch -r README README.tmp
mv -f README.tmp README
in %prep.
* Please remove the binary .gmo files in %prep.
* It looks like the files NEWS, Options_Reference.txt, Sample_Commands.txt
should go to %doc.
* Each package must consistently use macros. Please make use of the %{name}
macro.
* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.
* The file lib/getdate.c is GPLv2+. That makes the license GPLv2+ and GPLv3+.
? What is the directory build-aux and the executable files in the root of the
source tree for?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
