[Bug 487665] Review Request: pmut - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: pmut - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: soud -  |Review Request: pmut -
   |power management udev tools |power management udev tools
   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Marcela Maslanova mmasl...@redhat.com  2009-02-27 
08:49:35 EDT ---
Everything ok. Also the source is matching 531917bbd9c1c48e81799457f90f6c7e
The source should be changed after release into:
https://fedorahosted.org/releases/something/soud-something.tgz

ACCEPTED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: pmut - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665





--- Comment #2 from Petr Lautrbach plaut...@redhat.com  2009-02-27 08:13:35 
EDT ---
project renamed:

Spec URL: http://plautrba.fedorapeople.org/soud/soud.spec
SRPM URL: http://plautrba.fedorapeople.org/soud/soud-0.1.2-3.fc10.src.rpm
Description: 

Soud is set of tools and services for automated starting or stopping services
related to hardware, using udev to detect event on hardware and DeviceKit to
examine hw devices in udev subsystems.

It's part of https://fedoraproject.org/wiki/Features/PowerManagement

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: pmut - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665





--- Comment #1 from Marcela Maslanova mmasl...@redhat.com  2009-02-27 
06:43:58 EDT ---
? Rpmlint must be run on every package.
pmut.noarch: W: incoherent-version-in-changelog 0.1.2-1 ['0.1.2-2.fc10',
'0.1.2-2']

? The package must be named according to the Package Naming Guidelines.
This name can collide with
http://bioinformatics.oxfordjournals.org/cgi/content/abstract/21/14/3176 or
libraries for genetic algorithm http://gtps.math.cmu.edu/htmldoc-etps/pmut.html

OK The spec file name must match the base package %{name}.
OK The package must meet the Packaging Guidelines.
OK The package must be licensed with a Fedora approved license.
OK The License field in the package spec file must match the actual license.
OK If (and only if) the source package includes the text of the license(s) in
its own file.
OK The spec file must be written in American English ;-)
OK The spec file for the package MUST be legible.
? The sources used to build the package must match the upstream source.
The source must be located on f.e. project page.
OK The package MUST successfully compile.
OK Correct BuildRequires.
OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.
OK Shared library files (not just symlinks) must call ldconfig in %post and
%postun.
OK Relocatable package must state this fact in the request for review.
OK A package must own all directories that it creates.
OK A package must not contain any duplicate files in the %files listing.
OK Permissions on files must be set properly.
OK Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK Each package must consistently use macros.
OK The package must contain code, or permissable content.
OK Large documentation files must go in a -doc subpackage.
OK If a package includes something as %doc, it must not affect the runtime of
the application.
OK Header files must be in a -devel package.
OK Static libraries must be in a -static package.
OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so
(without suffix) must go in -devel.
OK In the vast majority of cases, devel packages must require the base package.
OK Packages must NOT contain any .la libtool archives.
OK Packages containing GUI applications must include a %{name}.desktop file.
OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).

The require line is too long, please create at least two instead. %doc can be
on one line ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review