[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 --- Comment #7 from Björn Persson bj...@xn--rombobjrn-67a.se 2009-11-12 20:21:38 EDT --- Now that PargmARC is in I've made a scratch build of Mine Detector. It worked without errors on i586, x86_64, ppc and ppc64: http://koji.fedoraproject.org/koji/taskinfo?taskID=1804288 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 --- Comment #6 from Björn Persson bj...@xn--rombobjrn-67a.se 2009-11-10 18:10:57 EDT --- Fixed to link libgnat and libgcc dynamically: http://www.rombobjörn.se/packages/mine_detector.spec http://www.rombobjörn.se/packages/mine_detector-6.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 Bug 509160 depends on bug 509159, which changed state. Bug 509159 Summary: Review Request: PragmARC – a component library for Ada https://bugzilla.redhat.com/show_bug.cgi?id=509159 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added CC||lemen...@gmail.com Blocks|177841(FE-NEEDSPONSOR) | --- Comment #5 from Peter Lemenkov lemen...@gmail.com 2009-09-27 13:00:45 EDT --- unblocking FE-NEEDSPONSOR - I just sponsored Björn Persson. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 --- Comment #4 from Björn Persson bj...@xn--rombobjrn-67a.se 2009-08-07 19:57:59 EDT --- Updated to version 6.0, and updated the URLs because the PragmAda site moved: http://www.rombobjörn.se/packages/mine_detector.spec http://www.rombobjörn.se/packages/mine_detector-6.0-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 --- Comment #3 from Björn Persson bj...@xn--rombobjrn-67a.se 2009-07-23 17:18:12 EDT --- Apparently the buildroot tag is still required for bureaucratic reasons, so I added one. http://www.rombobjörn.se/packages/mine_detector.spec http://www.rombobjörn.se/packages/mine_detector-5.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 Björn Persson bj...@xn--rombobjrn-67a.se changed: What|Removed |Added Alias||mine_detector -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 --- Comment #2 from Björn Persson bj...@xn--rombobjrn-67a.se 2009-07-18 16:32:59 EDT --- About the underscore, the naming guidelines also say that packages where the upstream name naturally contains an underscore are excluded from this. I figured that mine_detector would fall in this category, although I'm not sure how to tell a natural underscore from an unnatural one. The underscore is there in the names of both the source package and the final executable file, so I chose this name to comply with the rule that the name should match the upstream tarball or project name from which this software came. The underscore isn't important to me though. I can replace it with a hyphen if an experienced reviewer thinks I should. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=509160
Andrew McNabb amcn...@mcnabbs.org changed:
What|Removed |Added
CC||amcn...@mcnabbs.org
--- Comment #1 from Andrew McNabb amcn...@mcnabbs.org 2009-07-15 21:17:20
EDT ---
Björn, I'm not a sponsored package reviewer, but I have a few thoughts.
1) As you noted, rpmlint gave an error about the buildroot. I would recommend
adding something like BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n). I don't know
anything about the line being ignored, but even if the line just makes it
happy, it's can't hurt.
2) The package is called mine_detector, but the packaging guidelines prohibits
using underscores. Consider using a hyphen instead. See
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators
3) It's great that you have a description in two languages.
4) The package lists PragmARC-devel as a build dependency, but there does not
seem to be any package with that name in Fedora 11. As a result, I was unable
to build a binary package.
You mentioned that PragmARC-devel is part of a separate request, but I think
you should really work towards getting that one accepted before submitting new
requests that depend on it. Good luck.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 Björn Persson bj...@xn--rombobjrn-67a.se changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||509159 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
