[Bug 510584] Review Request: openssl-ibmca - A dynamic OpenSSL engine for IBMCA

2009-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510584


Dan Horák d...@danny.cz changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #7 from Dan Horák d...@danny.cz  2009-07-14 01:59:02 EDT ---
imported and built

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 510584] Review Request: openssl-ibmca - A dynamic OpenSSL engine for IBMCA

2009-07-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510584





--- Comment #2 from Jason Tibbitts ti...@math.uh.edu  2009-07-11 12:13:38 EDT 
---
I cannot seem to make any text-mode browser download the rpms from that koji
link so that I can look at them.  They always fail due to certificate issues. 
Do you have a trick for doing that, or could you fix the certificate issues?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 510584] Review Request: openssl-ibmca - A dynamic OpenSSL engine for IBMCA

2009-07-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510584





--- Comment #3 from Dan Horák d...@danny.cz  2009-07-11 12:32:41 EDT ---
Can you try http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=83198
(s/https/http/)? The downloads work for me from elinks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 510584] Review Request: openssl-ibmca - A dynamic OpenSSL engine for IBMCA

2009-07-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510584


Dan Horák d...@danny.cz changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #5 from Dan Horák d...@danny.cz  2009-07-11 13:59:23 EDT ---
Thanks for the review.

New Package CVS Request
===
Package Name: openssl-ibmca
Short Description: A dynamic OpenSSL engine for IBMCA
Owners: sharkcz
Branches: F-11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 510584] Review Request: openssl-ibmca - A dynamic OpenSSL engine for IBMCA

2009-07-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510584


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu
   Flag||fedora-review+




--- Comment #4 from Jason Tibbitts ti...@math.uh.edu  2009-07-11 13:21:54 EDT 
---
Yes, that works.  Can't believe I didn't think of it myself.

rpmlint is silent and according to the build logs this builds fine.

* source files match upstream.  sha256sum:  
   5a2ee2084cbf2355a4d081a89ea3cd7debd6224affab89239b2bae105bea6275
   openssl-ibmca-1.0.0.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.  
* description is OK.  
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in koji.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   libibmca.so()(64bit) 
   openssl-ibmca = 1.0.0-1.fc11 
   openssl-ibmca(s390-64) = 1.0.0-1.fc11
=
   libcrypto.so.8()(64bit)
   openssl = 0.9.8

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 510584] Review Request: openssl-ibmca - A dynamic OpenSSL engine for IBMCA

2009-07-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510584


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #6 from Jason Tibbitts ti...@math.uh.edu  2009-07-11 14:30:53 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review