[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 Fabian Affolter changed: What|Removed |Added CC||rootoutc...@hushmail.com --- Comment #14 from Fabian Affolter 2009-12-21 12:03:58 EDT --- *** Bug 546138 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 Rahul Sundaram changed: What|Removed |Added CC||sunda...@redhat.com --- Comment #13 from Rahul Sundaram 2009-10-04 14:14:36 EDT --- That bug report seems to be resolved with an updated policy. If it is not working for anyone yet, they should add comments to the bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 leigh scott changed: What|Removed |Added CC||leigh123li...@googlemail.co ||m --- Comment #12 from leigh scott 2009-10-04 08:26:20 EDT --- (In reply to comment #9) > NetworkManager works fine here, no complainants except that it requires a lot > of Gnome stuff. This is why I was looking for alternatives for my upcoming > LXDE > spin. I know many LXDE users use it, so I gave it a try. > > First I was very disappointed, because I could not get it to work with > WPA/WPA2 > encryption. Others confirmed that there were issues and they had to connect > several times until it worked. But since 1.5.8 it seems these problems have > been solved. I'm using 1.5.9 now for a nearly three weeks and it has always > worked flawlessly. The only issue is that it does not work with SELinux > currently. > > I'm going to review this package when Rangeen gives us an updated spec. I > really like to see this in Fedora ASAP, but first we need to fix > selinux-policy-targeted. There is a bugreport for the selinux issue. https://bugzilla.redhat.com/show_bug.cgi?id=481511 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 --- Comment #11 from Rangeen Basu Roy Chowdhury 2009-08-09 02:00:25 EDT --- > > I'm going to review this package when Rangeen gives us an updated spec. I > really like to see this in Fedora ASAP, but first we need to fix > selinux-policy-targeted. Please take up the this package as I am not able to dedicate enough time towards packaging and Fedora in general ( Little busy with my job). You can put me as a co maintainer. If you want I can also review the package at some point of time. By the way, if this package can wait for some time then I will take up the task after some time, once I have sufficient time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 --- Comment #10 from Paulo Roma Cavalcanti 2009-07-30 22:21:19 EDT --- wicd is working just fine for me with WPA. I just had to enter my password a single time, and it reconnects without my intervention. It seems it will be a very strong concurrent to NetworkManager. The only thing is that it brings the tray icon even without a running copy of wicd. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 --- Comment #9 from Christoph Wickert 2009-07-30 11:17:58 EDT --- NetworkManager works fine here, no complainants except that it requires a lot of Gnome stuff. This is why I was looking for alternatives for my upcoming LXDE spin. I know many LXDE users use it, so I gave it a try. First I was very disappointed, because I could not get it to work with WPA/WPA2 encryption. Others confirmed that there were issues and they had to connect several times until it worked. But since 1.5.8 it seems these problems have been solved. I'm using 1.5.9 now for a nearly three weeks and it has always worked flawlessly. The only issue is that it does not work with SELinux currently. I'm going to review this package when Rangeen gives us an updated spec. I really like to see this in Fedora ASAP, but first we need to fix selinux-policy-targeted. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 --- Comment #8 from Paulo Roma Cavalcanti 2009-07-30 11:00:49 EDT --- (In reply to comment #7) > (In reply to comment #6) > > > > and you should exclude any useless egg-info. > > Why is it useless? Are you familiar with > https://fedoraproject.org/wiki/Packaging/Python/Eggs > > > %{python_sitelib}/%{name} > > %exclude %{python_sitelib}/*.egg-info > > Please don't use excludes, as the break rpm's size calculation. > > Thanks for the explanation. Have you tested wicd? I am having a lot of disconnections/password re-entering when using NetworkManager on one of my netbooks. Do you think wicd can help in this case (I saw some posts stating that)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 --- Comment #7 from Christoph Wickert 2009-07-30 10:36:45 EDT --- (In reply to comment #6) > python-setuptools is version 0.6c9 on F10. Therefore, you should not use a > versioned > > BuildRequires: python-setuptools-devel >= 2.4 You are correct. I thought python-setuptools was built as a subpackage of python, but it's not. I wanted to require python >= 2.4 > Also you do not need %dir for claiming ownership, What %dir statement are you referring to? The first one is used to prevent accidentally packaging unwanted files in %{wicddir} and %{wicddir}/backends. We just want python files there. If you just use %{wicddir}, you wont realize if you accidentally include other files due to a bad setup.py or a bad tarball. The other %dir statements in %{_sharedstatedir} are not really needed from a technical POV, but from a human one. Other packagers should be able to see that these dirs are empty from a glance at the spec. > and you should exclude any useless egg-info. Why is it useless? Are you familiar with https://fedoraproject.org/wiki/Packaging/Python/Eggs > %{python_sitelib}/%{name} > %exclude %{python_sitelib}/*.egg-info Please don't use excludes, as the break rpm's size calculation. > and why did you comment the noarch? The package itself is noarch, but it cannot be packaged noarch as it puts the pm-utils script into %{_libdir}. I suggest to package them as a arch'ed subpackage so the main wicd package can be noarch. I also suggest to package the GUI and the TUI separately. It would be cool to have a wireless config tool without X and it would allow users of the GUI to install wicd without python-urwid. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 --- Comment #6 from Paulo Roma Cavalcanti 2009-07-30 10:11:02 EDT --- (In reply to comment #5) > Created an attachment (id=355670) --> (https://bugzilla.redhat.com/attachment.cgi?id=355670) [details] > my wicd.spec > > I packaged wicd last weekend, just before I found this review. Attaching my > spec, take what you need from it. python-setuptools is version 0.6c9 on F10. Therefore, you should not use a versioned BuildRequires: python-setuptools-devel >= 2.4 Also you do not need %dir for claiming ownership, and you should exclude any useless egg-info. This is enough, I guess. %{wicddir} %{_datadir}/applications/wicd.desktop %{_datadir}/icons/hicolor/*/apps/wicd-*.* %{_datadir}/pixmaps/wicd %{_datadir}/wicd %{_mandir}/man*/wicd*.gz %{_sharedstatedir}/wicd # For noarch packages: sitelib %{python_sitelib}/%{name} %exclude %{python_sitelib}/*.egg-info and why did you comment the noarch? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 --- Comment #3 from Christoph Wickert 2009-07-30 09:10:45 EDT --- The hardcoded /usr/lib/ is only used, when you don't pass %{_libdir} as an option: %{__python} setup.py configure --distro=redhat \ --lib=%{wicddir} \ --share=%{_datadir}/%{name} \ --etc=%{_sysconfdir}/%{name} \ --bin=%{_bindir} \ --sbin=%{_sbindir} \ --mandir=%{_mandir} \ --varlib=%{_sharedstatedir}/wicd \ --pmutils=%{_libdir}/pm-utils/sleep.d \ --resume=%{_sysconfdir}/acpi/resume.d \ --suspend=%{_sysconfdir}/acpi/suspend.d \ --docdir=%{_docdir}/%{name}-%{version} \ --no-install-kde \ --no-install-docs ... and everything is fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 Christoph Wickert changed: What|Removed |Added Attachment #355670|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 --- Comment #5 from Christoph Wickert 2009-07-30 09:13:09 EDT --- Created an attachment (id=355670) --> (https://bugzilla.redhat.com/attachment.cgi?id=355670) my wicd.spec I packaged wicd last weekend, just before I found this review. Attaching my spec, take what you need from it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 --- Comment #4 from Christoph Wickert 2009-07-30 09:11:34 EDT --- Sorry, I forgot to mention, that I defined %{wicddir} as %global wicddir %{_prefix}/lib/%{name} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 Paulo Roma Cavalcanti changed: What|Removed |Added CC||pro...@gmail.com --- Comment #2 from Paulo Roma Cavalcanti 2009-07-30 09:05:19 EDT --- It does not build on x86_64. /usr/lib is hardcoded in setup.py. Therefore, %{_libdir} will install in the wrong place. You can use sed -i -e 's|/usr/lib|%{_libdir}|g' setup.py to make it install in /usr/lib64, but I do not understand why the source want to install python scripts there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 Rangeen Basu Roy Chowdhury changed: What|Removed |Added Depends on||510097 --- Comment #1 from Rangeen Basu Roy Chowdhury 2009-07-14 08:10:22 EDT --- Modified spec file urlhttp://sherry151.fedorapeople.org/wicd/wicd.spec Modified srpm url:http://sherry151.fedorapeople.org/wicd/wicd-1.6.2-3.fc10.src.rpm I wanted to preserve the original files and so changed the urls to point to new files Successful koji scratch builds: F-10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1472887 F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1472992 F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1472994 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review