[Bug 517720] Review Request: perl-BZ-Client - A client for the Bugzilla web services API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517720 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-09-06 16:47:49 EDT --- perl-BZ-Client-1.02-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517720] Review Request: perl-BZ-Client - A client for the Bugzilla web services API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517720 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||1.02-1.fc11 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517720] Review Request: perl-BZ-Client - A client for the Bugzilla web services API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517720 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2009-08-27 18:53:38 EDT --- perl-BZ-Client-1.02-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-BZ-Client'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9060 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517720] Review Request: perl-BZ-Client - A client for the Bugzilla web services API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517720 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-08-26 18:24:49 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517720] Review Request: perl-BZ-Client - A client for the Bugzilla web services API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517720 --- Comment #4 from Fedora Update System upda...@fedoraproject.org 2009-08-26 19:11:28 EDT --- perl-BZ-Client-1.02-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-BZ-Client-1.02-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517720] Review Request: perl-BZ-Client - A client for the Bugzilla web services API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517720 Stepan Kasal ska...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ska...@redhat.com AssignedTo|nob...@fedoraproject.org|ska...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517720] Review Request: perl-BZ-Client - A client for the Bugzilla web services API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517720
Stepan Kasal ska...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Stepan Kasal ska...@redhat.com 2009-08-25 08:38:58 EDT
---
Review:
+ package builds in koji
Build =http://koji.fedoraproject.org/koji/taskinfo?taskID=1631969
FAIL rpmlint is silent for SRPM and for RPM.
- summary ends with dot; please delete it
- OTOH, the %description sentence should end with a dot
+ source file matches upstream url
+ package meets naming and packaging guidelines
+ specfile is properly named, is cleanly written
+ Spec file is written in American English
+ Spec file is legible
+ dist tag is present
+ build root is correct
+ license is open source-compatible
FAIL License text is included in package
- please add LICENSE to %doc
+ %doc is present.
FAIL BuildRequires are proper
- please add perl(HTTP::Cookies)
+ %clean is present
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does own the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test succeeded
+ provides and requires OK
+ Not a GUI application
A suggestion:
in %files, you might replace
%{perl_vendorlib}/*
by the more specific
%{perl_vendorlib}/BZ
Please make the four small changes under the three FAILs above and consider my
suggestion.
With these nits fixed, the package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517720] Review Request: perl-BZ-Client - A client for the Bugzilla web services API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517720
Emmanuel Seyman emmanuel.sey...@club-internet.fr changed:
What|Removed |Added
Flag||fedora-cvs?
--- Comment #2 from Emmanuel Seyman emmanuel.sey...@club-internet.fr
2009-08-25 09:19:35 EDT ---
(In reply to comment #1)
FAIL rpmlint is silent for SRPM and for RPM.
- summary ends with dot; please delete it
- OTOH, the %description sentence should end with a dot
Done.
FAIL License text is included in package
- please add LICENSE to %doc
Done.
FAIL BuildRequires are proper
- please add perl(HTTP::Cookies)
Done.
A suggestion:
in %files, you might replace
%{perl_vendorlib}/*
by the more specific
%{perl_vendorlib}/BZ
Done.
Thanks for the review. Asking for CVS.
New Package CVS Request
===
Package Name: perl-BZ-Client
Short Description: A client for the Bugzilla web services API
Owners: eseyman
Branches: F-10 F-11
InitialCC: perl-sig
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
