[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 Enrico Scholz enrico.sch...@informatik.tu-chemnitz.de changed: What|Removed |Added CC||enrico.sch...@informatik.tu ||-chemnitz.de --- Comment #4 from Enrico Scholz enrico.sch...@informatik.tu-chemnitz.de 2010-01-01 08:48:49 EDT --- It would be nice when the modules and database backends are packaged in separate subpackages; e.g. the current monolithic package requires all the gtk, postgresql, mysql, qt... stuff. People might want to run a GNUnet server in a dmz where gtk + qt are not wanted and where only one database backend is needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 --- Comment #5 from Christoph Maser c...@financial.com 2010-01-01 08:56:50 EDT --- While you are at it there is 0.8.1 available now, maybe that makes some of the patches unnecessary already. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 --- Comment #6 from Enrico Scholz enrico.sch...@informatik.tu-chemnitz.de 2010-01-01 09:13:03 EDT --- fwiw, the dialog, postgresql and qt4 location patches can be alternatively solved by %prep ... mkdir -p _dialog _postgresql/include ln -s %_includedir/dialog _dialog/include ln -s %_includedir_postgresql/include/postgresql %build ... # put qt4 stuff into $PATH p=`pkg-config --variable=bindir Qt` PATH=$p:/usr/bin:/bin %configure ... \ --with-dialog=`pwd`/_dialog \ --with-postgres=`pwd`/_postgresql \ The hardcoded 'lib' can and should be solved as in patch4 (the whole dynamic stuff in GNUNET_get_installation_path() is very flaky and not needed for Fedora). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 --- Comment #7 from Enrico Scholz enrico.sch...@informatik.tu-chemnitz.de 2010-01-01 09:55:02 EDT --- You might want to hack in '-Wl,--as-needed' LDFLAGS, e.g. by --- %configure ... \ LDFLAGS='-Wl,--as-needed' sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool --- Generated binaries/libraries add too much dependencies else; e.g. 'ld -u -r' shows unused libraries like WARN: /usr/bin/gnunetd: linked against unused libraries /lib64/libz.so.1 /usr/lib64/libextractor.so.1 /usr/lib64/libadns.so.1 /lib64/libgcrypt.so.11 /lib64/libgpg-error.so.0 /usr/lib64/libgmp.so.3 /usr/lib64/libltdl.so.7 /lib64/libm.so.6 /lib64/libpthread.so.0 /lib64/libdl.so.2 See http://people.redhat.com/drepper/dsohowto.pdf, 3.9 Inter-Object File Relations for more information. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 --- Comment #3 from Alexander Kahl ak...@imttechnologies.com 2009-12-31 07:34:58 EDT --- Ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 --- Comment #2 from Alexander Kahl ak...@imttechnologies.com 2009-11-20 05:43:52 EDT --- Spec URL: http://akahl.fedorapeople.org/GNUnet/GNUnet.spec SRPM URL: http://akahl.fedorapeople.org/GNUnet/GNUnet-0.8.0c-1.fc12.src.rpm A first check after a mock build yields: GNUnet.src: W: strange-permission gnunetd.init 0755 Can be solved by setting that file to chmod 644 and installing it with install -m 755 instead of using cp. Hmm odd. Done. GNUnet.x86_64: W: log-files-without-logrotate /var/log/gnunetd Done. Also added Requires: logrotate. GNUnet.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/gnunetd This is a false positive and even contradicts with the guidelines: Each Fedora SysV-style initscript which needs to start by default in any runlevel must include this line in the LSB Header (if the # Default-Start: line is present, then there must also be a # Default-Stop: line.). If the service does not start by default in any runlevel, this line should be omitted. (https://fedoraproject.org/wiki/Packaging:SysVInitScript#.23_Default-Stop:_line) There is no Default-Start contrary to what rpmlint utters and there should never be for GNUnet: (Default-Start:) Only services which are really required for a vital system should define runlevels here. (https://fedoraproject.org/wiki/Packaging:SysVInitScript#.23_Default-Start:_line) GNUnet.x86_64: W: incoherent-subsys /etc/rc.d/init.d/gnunetd $prog rpmlint is just too stupid to interpolate sh variables - if you replace all instances of $prog with its value (gnunetd), the warning vanishes. The line in question should be: lockfile=/var/lock/subsys/$prog Really want me to change that? I also get a flood of GNUnet.x86_64: W: unused-direct-shlib-dependency when running rpmlint on the installed packages. Please check this as well. Looks like all dload'able plugins are linked against the same set of so:s; definitely an issue for upstream. Shall I report to upstream first to have this fixed? Should be an issue of splitting up some Makefile.am:s. Furthermore please add comments to the patches as to where they come from and if they have been brought to upstream's notice at some point (bugzilla etc.). All patches written by myself; patch0: GNUnet build assumes postgres includes use the postgresql prefix which is not true for Fedora. patch1: GNUnet build assumes Qt4's moc and uic preprocessing tools to be available under that name but for Fedora it's moc-qt4 and uic-qt4. patch2: GNUnet build assumes dialog's headers to be in $prefix/include but for Fedora it uses a prefix with the same name (dialog). patch3: This fixes really a GNUnet bug naming cpp defines wrong when using dialog, for cdialog the bug is not present but cdialog is not available for Fedora. patch4: This one is also a real bug where GNUnet's plugin path is always assumed to be $prefix/lib/GNUnet despite $plugindir being used in other places correctly which is expanded to the arch-dependent lib dir at build time. For patches 0-2 we have to find out whether Fedora uses file locations and names from the vanilla build of postgres, Qt4 and dialog; in this case, upstream most probably uses Debian-specific locations and names (seems to be their primary development distro) so it'd be their issue. In any other case, the problem is ours and subject of further investigation with the corresponding packages' maintainers. The problem addressed by patch4 *could* be caused by Debian-specific behavior of GNUnet, do you know whether Debian uses /usr/lib for plugins independent from installed architecture? Patch3 is obviously an issue for upstream. Shall we fix the upstream-related stuff before proceeding any further? I can report everything after investigation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 Felix Kaechele fe...@fetzig.org changed: What|Removed |Added CC||fe...@fetzig.org AssignedTo|nob...@fedoraproject.org|fe...@fetzig.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 Felix Kaechele fe...@fetzig.org changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Felix Kaechele fe...@fetzig.org 2009-11-18 05:51:01 EDT --- A first check after a mock build yields: GNUnet.src: W: strange-permission gnunetd.init 0755 Can be solved by setting that file to chmod 644 and installing it with install -m 755 instead of using cp. GNUnet.x86_64: W: non-standard-uid /var/run/gnunetd gnunet GNUnet.x86_64: W: non-standard-gid /var/run/gnunetd gnunet GNUnet.x86_64: W: non-standard-uid /var/log/gnunetd gnunet GNUnet.x86_64: W: non-standard-gid /var/log/gnunetd gnunet Can be ignored GNUnet.x86_64: W: log-files-without-logrotate /var/log/gnunetd GNUnet.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/gnunetd GNUnet.x86_64: W: incoherent-subsys /etc/rc.d/init.d/gnunetd $prog Please fix. I also get a flood of GNUnet.x86_64: W: unused-direct-shlib-dependency when running rpmlint on the installed packages. Please check this as well. Furthermore please add comments to the patches as to where they come from and if they have been brought to upstream's notice at some point (bugzilla etc.). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 Alexander Kahl ak...@imttechnologies.com changed: What|Removed |Added Blocks||528333 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 528332] Review Request: GNUnet - Secure peer-to-peer networking framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528332 Alexander Kahl ak...@imttechnologies.com changed: What|Removed |Added Blocks||528379 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
