[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531773 Luya Tshimbalanga changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE --- Comment #9 from Luya Tshimbalanga 2009-12-17 17:29:48 EDT --- Closing this report because synfig is available on repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531773 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Jason Tibbitts 2009-11-13 14:34:16 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531773 Lubomir Rintel changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Lubomir Rintel 2009-11-13 03:21:38 EDT --- Thanks a lot for review Luya! (In reply to comment #5) > It was gcc-c++ package that was not installed although it should with the use > of yum-builddep command with src package (might be a bug but it is another > story). That might be a valid point. You could probably try opening a ticket against yum-utils. (In reply to comment #6) > BTW, once you have created cvs. Make sure to update to latest upstream version > (0.62). Surely, I'll do. New Package CVS Request === Package Name: synfig Short Description: Vector-based 2D animation rendering backend Owners: lkundrak Branches: F-11 F-12 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531773 --- Comment #6 from Luya Tshimbalanga 2009-11-12 21:47:25 EDT --- BTW, once you have created cvs. Make sure to update to latest upstream version (0.62). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531773
Luya Tshimbalanga changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Luya Tshimbalanga 2009-11-12
21:45:50 EDT ---
(In reply to comment #4)
> Thanks for the review:
>
> (In reply to comment #3)
> > - $ rpmlint rpmbuild/SRPMS/synfig-0.61.09-4.fc11.src.rpm synfig.src: W:
> > mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 64)
>
> Fixed. (This tiny change being the only one, I did not bump a release number.)
> > - Missing %{name}.desktop file because synfig is a GuI application
>
> It's not, please read the description. synfigstudio is, see bug #479527
Ok. I am also talikg synfigstudio for review as well.
> > checking how to run the C++ preprocessor... /lib/cpp
> > configure: error: in `/home/luya/rpmbuild/BUILD/synfig-0.61.09':
> > configure: error: C++ preprocessor "/lib/cpp" fails sanity check
> > See `config.log' for more details.
> > error: Bad exit status from /var/tmp/rpm-tmp.WcYKNa (%build)
>
> That's probably you don't have the build group installed [1] (presumably the
> cpp package). Either install it, or use mock to do the build.
>
It was gcc-c++ package that was not installed although it should with the use
of yum-builddep command with src package (might be a bug but it is another
story).
Back to the review:
+ $ rpmlint Downloads/synfig-0.61.09-4.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ md5sum rpmbuild/SOURCES/synfig-0.61.09.tar.gz
Downloads/synfig-0.61.09.tar.gz
0330521fe46b9e8a39df7081ec64c5d5 rpmbuild/SOURCES/synfig-0.61.09.tar.gz
0330521fe46b9e8a39df7081ec64c5d5 Downloads/synfig-0.61.09.tar.gz
+ sha512sum rpmbuild/SOURCES/synfig-0.61.09.tar.gz
Downloads/synfig-0.61.09.tar.gz
799c076a2ba8d00b02273ee191421ffb2379081107b1d5e101db010bb0c347ea75e89ba17891fe367f0fe2d7bb979e7660317240afb402fe11147c268c0592ea
rpmbuild/SOURCES/synfig-0.61.09.tar.gz
799c076a2ba8d00b02273ee191421ffb2379081107b1d5e101db010bb0c347ea75e89ba17891fe367f0fe2d7bb979e7660317240afb402fe11147c268c0592ea
Downloads/synfig-0.61.09.tar.gz
+ Source package succesfully built on all architecture using Koji and also
built locally
In conclusion, the package fully complies with packaging guideline.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531773
--- Comment #4 from Lubomir Rintel 2009-11-12 18:24:16 EDT ---
Thanks for the review:
(In reply to comment #3)
> - $ rpmlint rpmbuild/SRPMS/synfig-0.61.09-4.fc11.src.rpm synfig.src: W:
> mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 64)
Fixed. (This tiny change being the only one, I did not bump a release number.)
> - Missing %{name}.desktop file because synfig is a GuI application
It's not, please read the description. synfigstudio is, see bug #479527
> checking how to run the C++ preprocessor... /lib/cpp
> configure: error: in `/home/luya/rpmbuild/BUILD/synfig-0.61.09':
> configure: error: C++ preprocessor "/lib/cpp" fails sanity check
> See `config.log' for more details.
> error: Bad exit status from /var/tmp/rpm-tmp.WcYKNa (%build)
That's probably you don't have the build group installed [1] (presumably the
cpp package). Either install it, or use mock to do the build.
[1] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
New package:
SPEC: http://v3.sk/~lkundrak/SPECS/synfig.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/synfig-0.61.09-4.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531773
Luya Tshimbalanga changed:
What|Removed |Added
CC||l...@fedoraproject.org
AssignedTo|nob...@fedoraproject.org|l...@fedoraproject.org
Flag||fedora-review?
--- Comment #3 from Luya Tshimbalanga 2009-11-12
17:10:51 EDT ---
- $ rpmlint rpmbuild/SRPMS/synfig-0.61.09-4.fc11.src.rpm synfig.src: W:
mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 64)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
+ Package complies to Package Naming guideline
+ Spec file name matches the base package %{name}, synfig in this case, in the
format %{name}.spec
+ Package meets the Packaging guideline with the removal of rpath listed in
spec file
+ License filed in package spec match the factual license which is GPLv2+
+ Text of licnse included in %doc
+ Spec file is legible and written in American English
+ Succesfully build in all architectures
http://koji.fedoraproject.org/koji/taskinfo?taskID=1776478
+ Locale handled using %find_lang
+ %post and %postun called
+ No bundle copies of system libraries.
+ All created directories are owned by the package
+ Permission on files is properly set
+ Header files are in -devel package
+ No .la libtool archived
- Missing %{name}.desktop file because synfig is a GuI application
+ All filename in rpm package are valid UTF-8
I am unable to match md5sum because sourceforge seems to be down. Please
correct those comments listed in "-" line. Also I had trouble to locally
rebuild package with this result:
checking how to run the C++ preprocessor... /lib/cpp
configure: error: in `/home/luya/rpmbuild/BUILD/synfig-0.61.09':
configure: error: C++ preprocessor "/lib/cpp" fails sanity check
See `config.log' for more details.
error: Bad exit status from /var/tmp/rpm-tmp.WcYKNa (%build)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531773 --- Comment #2 from Lubomir Rintel 2009-10-29 10:26:25 EDT --- "kouzi skrec bild" http://koji.fedoraproject.org/koji/taskinfo?taskID=1776478 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531773 Jussi Lehtola changed: What|Removed |Added CC||m...@mwiriadi.id.au --- Comment #1 from Jussi Lehtola 2009-10-29 09:32:04 EDT --- *** Bug 428568 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531773] Review Request: synfig - Vector-based 2D animation rendering backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531773 Lubomir Rintel changed: What|Removed |Added Blocks||479527 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
