[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0.13-2.fc12 |0.13-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2009-12-01 13:28:32 EDT --- perl-Net-CIDR-0.13-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2009-11-20 00:13:22 EDT --- perl-Net-CIDR-0.13-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2009-11-20 00:14:01 EDT --- perl-Net-CIDR-0.13-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0.13-2.fc11 |0.13-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||0.13-2.fc11 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2009-11-20 00:33:51 EDT --- perl-Net-CIDR-0.13-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0.13-2.fc10 |0.13-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-11-18 17:57:25 EDT --- perl-Net-CIDR-0.13-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-CIDR'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0842 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-11-11 06:21:12 EDT --- perl-Net-CIDR-0.13-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Net-CIDR-0.13-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-11-11 06:21:37 EDT --- perl-Net-CIDR-0.13-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Net-CIDR-0.13-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2009-11-11 06:20:45 EDT --- perl-Net-CIDR-0.13-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Net-CIDR-0.13-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2009-11-11 06:22:16 EDT --- perl-Net-CIDR-0.13-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-Net-CIDR-0.13-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-11-11 12:22:04 EDT --- perl-Net-CIDR-0.13-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-CIDR'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0842 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-11-11 19:54:18 EDT --- perl-Net-CIDR-0.13-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-CIDR'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-11412 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2009-11-11 19:56:37 EDT --- perl-Net-CIDR-0.13-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-CIDR'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11423 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2009-11-11 19:58:21 EDT --- perl-Net-CIDR-0.13-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-CIDR'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-11429 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2009-11-10 22:51:05 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 Paul Howarth p...@city-fan.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||p...@city-fan.org AssignedTo|nob...@fedoraproject.org|p...@city-fan.org Flag||fedora-review? --- Comment #1 from Paul Howarth p...@city-fan.org 2009-11-09 05:28:22 EDT --- Looks OK at first glance except License: should be GPL+ or Artistic. Full review to follow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533721
--- Comment #2 from Paul Howarth p...@city-fan.org 2009-11-09 07:44:34 EDT
---
perl-Net-CIDR review:
rpmlint output:
perl-Net-CIDR.noarch: W: invalid-license Distributable, see COPYING
perl-Net-CIDR.src: W: invalid-license Distributable, see COPYING
These needs fixing, by changing the license tag to GPL+ or Artistic
- package and spec file naming OK
- package meets guidelines
- package is licensed same as perl but license tag needs fixing to reflect
this
- no upstream license text to include, though the COPYING file refers to
the licenses under which the software is licensed, and this file is
included
- spec file written in English and is legible
- source matches upstream
- package builds OK in mock for Rawhide x86_64
- buildreqs OK
- no locale data, shared or static libs, or devel files to worry about
- package not relocatable
- no duplicate files or directory ownership issues
- %defattr(...) present and correct
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- not a GUI app - no desktop file needed
- buildroot cleaned correctly at the start of %install
- filenames all ASCII
- no scriptlets or subpackages
Notes:
* License should be GPL+ or Artistic
* No point including Net-CIDR.spec as %doc
* Why use wildcards for single items in %files list:
%{perl_vendorlib}/* could be %{perl_vendorlib}/Net/
%{_mandir}/man3/* could be %{_mandir}/man3/Net::CIDR.3pm*
This is just a style issue really but IMHO the more explicit entries are
more readable and informative
Only the license issue is a blocker here. Fix that and I'll approve.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 --- Comment #3 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-11-09 08:20:19 EDT --- Spec URL: http://kwizart.fedorapeople.org/review/perl-Net-CIDR.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Net-CIDR-0.13-2.fc11.src.rpm Description: Manipulate IPv4/IPv6 netblocks in CIDR notation Changelog: - Fix License tag - Remove Net-CIDR.spec from %%doc - List files more explicitely -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 Paul Howarth p...@city-fan.org changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Paul Howarth p...@city-fan.org 2009-11-09 08:58:49 EDT --- rpmlint now clean. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 533721] Review Request: perl-Net-CIDR - Manipulate IPv4/IPv6 netblocks in CIDR notation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533721 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-11-09 09:11:44 EDT --- New Package CVS Request === Package Name: perl-Net-CIDR Short Description: Manipulate IPv4/IPv6 netblocks in CIDR notation Owners: kwizart Branches: F-12 F-11 F-10 EL-5 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
