[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 Mat Booth changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #6 from Mat Booth 2009-11-24 05:07:22 EDT --- Built successfully for Rawhide, closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi 2009-11-23 21:08:23 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 Mat Booth changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Mat Booth 2009-11-22 09:17:31 EDT --- Thanks for the speedy feedback and swift review, Lubomir. New Package CVS Request === Package Name: eclipse-mdt-uml2 Short Description: Implementation of the UML2 OMG metamodel for Eclipse Owners: mbooth Branches: F-12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 Lubomir Rintel changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Lubomir Rintel 2009-11-22 08:33:18 EDT --- (In reply to comment #2) ... > This generally goes for all plugins from the Eclipse project. Okay, sounds fair enough. Thank you. > Ok, I will reformat the description, that's no problem. Thanks. This itself definitely wouldn't be a problem. As it, along with the source tarballs which were sufficiently explained, was the only complain in some of your other reviews, I'm going to approve them as well. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 --- Comment #2 from Mat Booth 2009-11-22 08:25:32 EDT --- (In reply to comment #1) > A few objections: > > 1.) Why do you check stuff out from CVS? There seem to be a source/sdk bundle > available at the downloads page: > http://www.eclipse.org/modeling/mdt/downloads/?project=uml2 Because although the SDK distribution does contain the source plugins, they don't contain enough information in order to build it. The source plugins are there to aid development of plugins that use the plugins in this package (so you can do source level debugging and what have you). Checking out from source control directly gives us everything we need, indeed this is how we'd build the source plugins in the first place. This generally goes for all plugins from the Eclipse project. > > 2.) Please don't pretty-format the Description. It does not always look well > in > package management front-ends. Ok, I will reformat the description, that's no problem. Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-uml2.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-uml2-3.0.1-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 Lubomir Rintel changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 --- Comment #1 from Lubomir Rintel 2009-11-21 13:53:00 EDT --- Good work, Mat. * Package name and version are in accordance with packaging guidelines * SPEC file clean, legible and well-commented * License tag correct, license packaged as %doc * Builds fine in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=1821764 * RPMLint happy (a couple of false positives about spelling errors in fc13) * Filelist okay * Provides/Require list ok A few objections: 1.) Why do you check stuff out from CVS? There seem to be a source/sdk bundle available at the downloads page: http://www.eclipse.org/modeling/mdt/downloads/?project=uml2 2.) Please don't pretty-format the Description. It does not always look well in package management front-ends. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 Lubomir Rintel changed: What|Removed |Added CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 Mat Booth changed: What|Removed |Added Blocks||536684 Depends on|536684 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536683 Mat Booth changed: What|Removed |Added Depends on||536684 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
