[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2010-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360


Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Marcela Mašláňová mmasl...@redhat.com  2010-01-04 
03:19:53 EDT ---
New Package CVS Request
===
Package Name: perl-CPAN-Inject
Short Description: Base class for injecting distributions into CPAN sources
Owners: mmaslano
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2010-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Kevin Fenzi ke...@tummy.com  2010-01-04 15:23:13 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2010-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360


Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2009-12-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Parag AN(पराग) panem...@gmail.com  2009-12-29 00:35:19 
EDT ---
It is really confusing here as srpm download link is not working
Anyway I just looked into fedorapeople page and got new updated srpm.

Review:
+ package builds in mock (rawhide i686).
koji Build =http://koji.fedoraproject.org/koji/taskinfo?taskID=1894218
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
41ff95c0c8dd1852645a8a3a063b039960a11141  CPAN-Inject-0.11.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=4, Tests=24,  4 wallclock secs ( 0.06 usr  0.01 sys +  0.64 cusr  0.06
csys =  0.77 CPU)
+ Package  perl-CPAN-Inject-0.11-2.fc13.noarch=
Provides: perl(CPAN::Inject) = 0.11
Requires: /usr/bin/perl perl = 0:5.005 perl(CPAN::Checksums)
perl(CPAN::Inject) perl(File::Basename) perl(File::Copy) perl(File::Path)
perl(File::Spec) perl(File::chmod) perl(File::stat) perl(Params::Util)
perl(strict) perl(vars)

+ Not a GUI application

Suggestions:
1) Please remove unnecessary Requires: from spec file.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2009-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360





--- Comment #2 from Marcela Mašláňová mmasl...@redhat.com  2009-12-22 
09:49:04 EDT ---
Fixed:
http://mmaslano.fedorapeople.org/review/perl-CPAN-Inject-0.11-2.fc12.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=1886066

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2009-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360





--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-12-09 01:18:19 
EDT ---
looks make test failed. see
http://koji.fedoraproject.org/koji/taskinfo?taskID=1863802

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2009-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360


Bug 538360 depends on bug 538361, which changed state.

Bug 538361 Summary: Review Request: perl-CPAN-Checksums - Write a CHECKSUMS 
file for a directory as on CPAN
https://bugzilla.redhat.com/show_bug.cgi?id=538361

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2009-11-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360


Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Depends on||538361




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2009-11-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360


Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Blocks||538363




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538360] Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources

2009-11-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538360


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review