[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2010-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #16 from Jaroslav Reznik jrez...@redhat.com  2010-01-04 06:33:40 
EDT ---
Thanks Rex!
Sorry for delay - so what about F12? Do we really need it? F13 should be our
target, for interested people it can be in kde repo for F12...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2010-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346


Jaroslav Reznik jrez...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #17 from Jaroslav Reznik jrez...@redhat.com  2010-01-04 10:57:11 
EDT ---
New Package CVS Request
===
Package Name: polkit-kde
Short Description: PolicyKit integration for KDE Desktop
Owners: jreznik rnovacek ltinkl than rdieter kkofler
Branches: F-12
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2010-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #18 from Kevin Fenzi ke...@tummy.com  2010-01-04 15:13:18 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #14 from Rex Dieter rdie...@math.unl.edu  2009-12-23 14:26:01 EDT 
---
I'll take a look,

Not a blocker, looks like we have an upstream release/tarball, woo,
ftp://ftp.kde.org/pub/kde/stable/apps/KDE4.x/admin/polkit-kde-1-0.95.1.tar.bz2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346


Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #15 from Rex Dieter rdie...@math.unl.edu  2009-12-23 14:43:39 EDT 
---
Simple spec.

$ rpmlint *.rpm */*.rpm
polkit-kde.src:24: W: unversioned-explicit-provides
PolicyKit-authentication-agent
polkit-kde.x86_64: W: obsolete-not-provided PolicyKit-kde
polkit-kde.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/polkit-kde-authentication-agent-1.desktop
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

License: OK

Source: OK (better, when using verifiable upstream tarball)

macros: OK

Obsoletess/Provides: OK


I see now issues or blockers, looks good,

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #11 from Jaroslav Reznik jrez...@redhat.com  2009-12-11 04:49:02 
EDT ---
Hi Kevin,
sorry for delay. I'm still not sure how to handle obsoletes - in
kdebase-workspace these are versioned. Rex, could you please look at your SPEC
which version I should set? Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #12 from Kevin Kofler ke...@tigcc.ticalc.org  2009-12-11 04:58:10 
EDT ---
I guess Obsoletes: PolicyKit-kde  4.5 should be safe. (We're not going to
provide 4.5 for F11, so there shouldn't be a PK-0.9-based PolicyKit-kde higher
than 4.4.x.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #13 from Jaroslav Reznik jrez...@redhat.com  2009-12-11 07:31:21 
EDT ---
Desktop file added + obsoletes.

http://rezza.hofyland.cz/fedora/packages/polkit-kde/polkit-kde-0.95-0.2.20091125svn.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-12-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #9 from Kevin Kofler ke...@tigcc.ticalc.org  2009-12-09 18:45:21 
EDT ---
Ping? What happened to this review request? Jaroslav, can you please add that
Obsoletes line and that autostart .desktop file (either with OnlyShowIn=KDE; or
in the KDE-specific /usr/share/autostart, of course) so we can continue?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-12-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #10 from Kevin Kofler ke...@tigcc.ticalc.org  2009-12-09 18:46:28 
EDT ---
(I can take care of adjusting kdebase-workspace and polkit-gnome once this is
in.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-12-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #8 from Kevin Kofler ke...@tigcc.ticalc.org  2009-12-03 08:26:25 
EDT ---
Yes, just copy the Obsoletes line from kdebase-workspace.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-11-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #7 from Jaroslav Reznik jrez...@redhat.com  2009-11-30 10:28:30 
EDT ---
(In reply to comment #3)
 #1 issue in this package: this needs a .desktop file so it actually get
 started!  

Ops, you're right! How should obsoletes look then? As in kdebase-workspace
there's %{version}-%{release} part - is it OK just to match current
kdebase-workspace version/release?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #1 from Jaroslav Reznik jrez...@redhat.com  2009-11-25 10:55:58 
EDT ---
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1830517

RPMLINT
polkit-kde.spec:23: W: unversioned-explicit-provides
PolicyKit-authentication-agent

Comment: polkit-gnome does not specify version neither

What about obsoletes? PolicyKit-kde?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #3 from Kevin Kofler ke...@tigcc.ticalc.org  2009-11-25 11:01:29 
EDT ---
#1 issue in this package: this needs a .desktop file so it actually get
started!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346


Kevin Kofler ke...@tigcc.ticalc.org changed:

   What|Removed |Added

 CC||ke...@tigcc.ticalc.org




--- Comment #2 from Kevin Kofler ke...@tigcc.ticalc.org  2009-11-25 11:00:45 
EDT ---
To answer your question:
1. Obsoletes: PolicyKit-kde should be moved here from kdebase-workspace.
2. kdebase-workspace should get Requires: polkit-kde instead of
PolicyKit-authentication-agent as only polkit-kde will run in KDE.
3. polkit-gnome needs to be switched back to being disabled in KDE (as it
originally was).
These 3 changes need to happen at the same time to prevent chaos.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346


Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu




--- Comment #4 from Rex Dieter rdie...@math.unl.edu  2009-11-25 11:06:50 EDT 
---
+1 to what Kevin said, though 2/3 is arguably for f13 only (can provide as
tech-preview/whatever to those who really want it in f12, but they'll need to
manage the integration by hand, similar to how nm-applet/knetworkmanager is in
f12).

I'll try to take a closer look here soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #5 from Kevin Kofler ke...@tigcc.ticalc.org  2009-11-25 11:16:44 
EDT ---
Doing 1. without 2. and 3. is not a good idea, it will lead to polkit-kde
getting dragged in on upgrades from F11, but not new installs. These changes
are all dependent on each other and on 4. adding a .desktop file as per comment
#3. Doing parts of it doesn't make sense.

In fact I'd argue that shipping this package without doing 4. makes no sense at
all and that 4. is a recipe for chaos without 3., which requires 1. and 2. to
fix the upgrade path.

So shipping this package for F12 is only going to work properly if we do all 4
changes from comment #2 and comment #3. And I don't see why we wouldn't do
that. There are no worries about user data as all the data/configuration is in
the polkit backend. It should be a drop-in replacement.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541346] Review Request: polkit-kde - PolicyKit integration for KDE Desktop

2009-11-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541346





--- Comment #6 from Rex Dieter rdie...@math.unl.edu  2009-11-25 11:25:56 EDT 
---
Ah, good point.  Maybe it is best an all-or-nothing proposition then.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review