[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 --- Comment #12 from David Nalley da...@gnsa.us 2009-12-22 10:32:36 EDT --- Closing this ticket as this has been pushed to stable -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 David Nalley da...@gnsa.us changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 Eric Christensen e...@christensenplace.us changed: What|Removed |Added CC||e...@christensenplace.us Blocks||508817 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi ke...@tummy.com 2009-12-14 12:25:21 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Remi Collet fed...@famillecollet.com 2009-12-12 04:37:30 EDT --- All is ok now. * APPROVED * -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 David Nalley da...@gnsa.us changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from David Nalley da...@gnsa.us 2009-12-12 14:12:36 EDT --- New Package CVS Request === Package Name: php-pear-Spreadsheet-Excel-Writer Short Description: Package for generating excel spreadsheets Owners: ke4qqq Branches: F-11 F-12 EL-5 InitialCC: Thanks Remi!! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 Remi Collet fed...@famillecollet.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com Flag||fedora-review? Bug 542028 depends on bug 542500, which changed state. Bug 542500 Summary: Review Request: php-pear-OLE - Package for reading and writing OLE containers https://bugzilla.redhat.com/show_bug.cgi?id=542500 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||ERRATA Status|ASSIGNED|CLOSED --- Comment #7 from Remi Collet fed...@famillecollet.com 2009-12-11 15:51:12 EDT --- REVIEW: + rpmlint is ok php-pear-Spreadsheet-Excel-Writer.src: I: checking php-pear-Spreadsheet-Excel-Writer.noarch: I: checking php-pear-Spreadsheet-Excel-Writer.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines + License ok : LGPLv2+ + License is upstream (LGPL) + spec in english and legible + no license file in sources is provided + sources match the upstream sources 15691145ca8ac71ccd501a38892ee64a Spreadsheet_Excel_Writer-0.9.2.tgz + Source URL ok + build on F12.x86_64 + BuildRequires (php-pear = 1:1.4.9-1.2) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + no documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in koji + no test suite + scriptlets ok - Final Requires php = 4.1.0 php-pear(OLE) = 0.5 /usr/bin/pear + Final Provides ok php-pear(Spreadsheet_Excel_Writer) = 0.9.2 php-pear-Spreadsheet-Excel-Writer = 0.9.2-1.fc8 + Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=1870628 All is ok, except the dependency on httpd... Just remove the php 4.1.0 (as for previous #542500, just requires php-common when version check is necessary). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 --- Comment #8 from David Nalley da...@gnsa.us 2009-12-11 22:05:27 EDT --- SPEC: http://ke4qqq.fedorapeople.org/php-pear-Spreadsheet-Excel-Writer.spec SRPM: http://ke4qqq.fedorapeople.org/php-pear-Spreadsheet-Excel-Writer-0.9.2-2.fc12.src.rpm Remi: Thanks for the review. I corrected the requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 David Nalley da...@gnsa.us changed: What|Removed |Added Blocks||544722 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 --- Comment #6 from David Nalley da...@gnsa.us 2009-12-02 13:55:37 EDT --- thanks for catching the %clean problem. I have updated spec/srpm to fix above problems and update to 0.9.2 SPEC: http://ke4qqq.fedorapeople.org/php-pear-Spreadsheet-Excel-Writer.spec SRPM: http://ke4qqq.fedorapeople.org/php-pear-Spreadsheet-Excel-Writer-0.9.2-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 --- Comment #5 from Remi Collet fed...@famillecollet.com 2009-12-01 12:19:24 EDT --- Please, fix Requires: php-pear-(OLE) Requires: php-pear(OLE) %clean section is mandatory Please update to latest version 0.9.2 (great, this package seems back to life) as it fixes a number of bugs, especially php 5.3 compatibility. package.xml in 0.9.1 is an old V1 one, in 0.9.2 is a new V2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 David Nalley da...@gnsa.us changed: What|Removed |Added Depends on||542500 --- Comment #4 from David Nalley da...@gnsa.us 2009-11-29 18:58:54 EDT --- Adding php-pear-OLE as a blocker -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 Remi Collet fed...@famillecollet.com changed: What|Removed |Added CC||fed...@famillecollet.com --- Comment #1 from Remi Collet fed...@famillecollet.com 2009-11-28 09:15:42 EDT --- It seems to be an auto-generated spec : # Expand this as needed to avoid owning dirs owned by our dependencies # and to avoid unowned dirs So you MUST own all the dir you create (as explicit writen in the Guidelines and in this comment) and you should, then, remove this comment. Requires: php-(OLE) This is a bug, see https://bugzilla.redhat.com/show_bug.cgi?id=536756 But I don't think php-pear-OLE is available in Fedora. So you must submit it for review first and set the it as a blocker for this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 --- Comment #2 from David Nalley da...@gnsa.us 2009-11-28 20:34:56 EDT --- (In reply to comment #1) It seems to be an auto-generated spec : Indeed it is. # Expand this as needed to avoid owning dirs owned by our dependencies # and to avoid unowned dirs So you MUST own all the dir you create (as explicit writen in the Guidelines and in this comment) and you should, then, remove this comment. ouch, thanks for catching that. Requires: php-(OLE) This is a bug, see https://bugzilla.redhat.com/show_bug.cgi?id=536756 But I don't think php-pear-OLE is available in Fedora. So you must submit it for review first and set the it as a blocker for this one. So it is. I have a spec file I am building. I'll submit it hopefully tonight and mark it as blocking this review. Thanks for the review Remi. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542028] Review Request: php-pear-Spreadsheet-Excel-Writer - Package for generating Excel spreadsheets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542028 --- Comment #3 from David Nalley da...@gnsa.us 2009-11-28 21:03:43 EDT --- Bah - forgot links to updated SPEC and SRPM SPEC: http://ke4qqq.fedorapeople.org/php-pear-Spreadsheet-Excel-Writer.spec SRPM: http://ke4qqq.fedorapeople.org/php-pear-Spreadsheet-Excel-Writer-0.9.1-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
