[FFmpeg-devel] [PATCH] avcodec/qsv: remove MFX_EXTBUFF_CODING_OPTION3

2016-06-17 Thread zeranoe 
From: Kyle Schwarz 

4th generation Intel CPUs don't support MFX_EXTBUFF_CODING_OPTION3.

This patch fixes bug #5324.
---
 libavcodec/qsvenc.c | 18 --
 1 file changed, 18 deletions(-)

diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index 132cf47..a561df8 100644
--- a/libavcodec/qsvenc.c
+++ b/libavcodec/qsvenc.c
@@ -132,9 +132,6 @@ static void dump_video_param(AVCodecContext *avctx, 
QSVEncContext *q,
 #if QSV_HAVE_CO2
 mfxExtCodingOption2 *co2 = (mfxExtCodingOption2*)coding_opts[1];
 #endif
-#if QSV_HAVE_CO3
-mfxExtCodingOption3 *co3 = (mfxExtCodingOption3*)coding_opts[2];
-#endif
 
 av_log(avctx, AV_LOG_VERBOSE, "profile: %s; level: %"PRIu16"\n",
print_profile(info->CodecProfile), info->CodecLevel);
@@ -186,12 +183,6 @@ static void dump_video_param(AVCodecContext *avctx, 
QSVEncContext *q,
info->ICQQuality, co2->LookAheadDepth);
 }
 #endif
-#if QSV_HAVE_QVBR
-else if (info->RateControlMethod == MFX_RATECONTROL_QVBR) {
-av_log(avctx, AV_LOG_VERBOSE, "QVBRQuality: %"PRIu16"\n",
-   co3->QVBRQuality);
-}
-#endif
 
 av_log(avctx, AV_LOG_VERBOSE, "NumSlice: %"PRIu16"; NumRefFrame: 
%"PRIu16"\n",
info->NumSlice, info->NumRefFrame);
@@ -577,12 +568,6 @@ static int qsv_retrieve_enc_params(AVCodecContext *avctx, 
QSVEncContext *q)
 .Header.BufferSz = sizeof(co2),
 };
 #endif
-#if QSV_HAVE_CO3
-mfxExtCodingOption3 co3 = {
-.Header.BufferId = MFX_EXTBUFF_CODING_OPTION3,
-.Header.BufferSz = sizeof(co3),
-};
-#endif
 
 mfxExtBuffer *ext_buffers[] = {
 (mfxExtBuffer*),
@@ -590,9 +575,6 @@ static int qsv_retrieve_enc_params(AVCodecContext *avctx, 
QSVEncContext *q)
 #if QSV_HAVE_CO2
 (mfxExtBuffer*),
 #endif
-#if QSV_HAVE_CO3
-(mfxExtBuffer*),
-#endif
 };
 
 int need_pps = avctx->codec_id != AV_CODEC_ID_MPEG2VIDEO;
-- 
2.7.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-06-17 Thread Michael Niedermayer 
On Thu, Jun 16, 2016 at 11:16:05AM -0700, Jon Toohill wrote:
> Also removes decoder delay compensation from libmp3lame and mp3enc.
> initial_padding specifies only encoder delay, decoder delay is
> handled by start_skip_samples.
> ---
>  libavcodec/libmp3lame.c | 2 +-
>  libavformat/mp3dec.c| 2 ++
>  libavformat/mp3enc.c| 9 ++---
>  3 files changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c
> index 5642264..198ac94 100644
> --- a/libavcodec/libmp3lame.c
> +++ b/libavcodec/libmp3lame.c
> @@ -137,7 +137,7 @@ static av_cold int mp3lame_encode_init(AVCodecContext 
> *avctx)
>  }
>  
>  /* get encoder delay */
> -avctx->initial_padding = lame_get_encoder_delay(s->gfp) + 528 + 1;
> +avctx->initial_padding = lame_get_encoder_delay(s->gfp);
>  ff_af_queue_init(avctx, >afq);
>  
>  avctx->frame_size  = lame_get_framesize(s->gfp);

you are changing a field of the public API
changing public API without major version bumps is tricky, we dont want
to break applications linkng to a newer lib

is there software that uses this?
software that would break if this is applied ? (or maybe it wuld fix
some software usig it)

If this is a bugfix it should be documented in APIChanges with
minor version bumps, any available references to specifications
should be added too

Such bugfix should also be seperate of other unrelated changes


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [GSoC] Motion Interpolation

2016-06-17 Thread Michael Niedermayer 
On Fri, Jun 17, 2016 at 08:19:00AM +, Davinder Singh wrote:
> On Wed, Jun 15, 2016 at 5:04 PM Michael Niedermayer 
> wrote:
> 
> > Hi
> >
> > On Tue, May 31, 2016 at 10:43:38PM +, Davinder Singh wrote:
> > > There’s a lot of research done on Motion Estimation. Depending upon the
> > > intended application of the resultant motion vectors, the method used for
> > > motion estimation can be very different.
> > >
> > > Classification of Motion Estimation Methods:
> > >
> > > Direct Methods: In direct methods we calculate optical flow
> > >  in the scene.
> > >
> > > - Phase Correlation
> > >
> > > - Block Matching
> > >
> > > - Spatio-Temporal Gradient
> > >
> > >  - Optical flow: Uses optical flow equation to find motion in the scene.
> > >
> > >  - Pel-recursive: Also compute optical flow, but in such a way that allow
> > > recursive computability on vector fields)
> > >
> > > Indirect Methods
> > >
> > > - Feature based Method: Find features in the frame, and used for
> > estimation.
> > >
> > > Here are some papers on Frame Rate Up-Conversion (FRUC):
> > >
> > > Phase Correlation:
> > >
> > > This method relies on frequency-domain representation of data, calculated
> > > using fast Fourier transform.
> > >  Phase Correlation
> > > provides a correlation surface from the comparison of images. This
> > enables
> > > the identification of motion on a pixel-by-pixel basis for correct
> > > processing of each motion type. Since phase correlation operates in the
> > > frequency rather than the spatial domain, it is able to zero in on
> > details
> > > while ignoring such factors as noise and grain within the picture. In
> > other
> > > words, the system is highly tolerant of the noise variations and rapid
> > > changes in luminance levels that are found in many types of content –
> > > resulting in high-quality performance on fades, objects moving in and out
> > > of shade, and light ashes.
> > >
> > > Papers:
> > >
> > > [1] "Disney Research » Phase-Based Frame Interpolation for Video." IEEE
> > > CVPR 2015 
> > >
> > > [2] Yoo, DongGon et al. "Phase Correlated Bilateral Motion Estimation for
> > > Frame Rate Up-Conversion." The 23rd International Technical Conference on
> > > Circuits/Systems, Computers and Communications (ITC-CSCC Jul. 2008.
> > >
> > > 
> > >
> > > The video on paper [1] page demonstrate comparison between various
> > methods.
> > >
> > > Optical Flow:
> > >
> > > http://www.cs.toronto.edu/~fleet/research/Papers/flowChapter05.pdf
> > >
> > > [3] Brox et al. "High accuracy optical flow estimation based on a theory
> > > for warping." Computer Vision - ECCV 2004: 25-36.
> > >
> > > <
> > >
> > http://www.wisdom.weizmann.ac.il/~/vision/courses/2006_2/papers/optic_flow_multigrid/brox_eccv04_of.pdf
> > > >
> > >
> > > Slowmovideo  open-source project is
> > based
> > > on Optical flow equation.
> > >
> > > Algorithm we can implement is based on block matching method.
> > >
> > > Motion Compensated Frame Interpolation
> > >
> > > Paper:
> > >
> > > [4] Zhai et al. "A low complexity motion compensated frame interpolation
> > > method." IEEE ISCAS 2005: 4927-4930.
> > >
> > > 
> > >
> > > Block-based motion estimation and pixel-wise motion estimation are the
> > two
> > > main categories of motion estimation methods. In general, pixel-wise
> > motion
> > > estimation can attain accurate motion fields, but needs a substantial
> > > amount of computation. In contrast, block matching algorithms (BMA) can
> > be
> > > efficiently implemented and provide good performance.
> > >
> > > Most MCFI algorithms utilize the block-matching algorithm (BMA) for
> > motion
> > > estimation (ME). BMA is simple and easy to implement. It also generates a
> > > compactly represented motion field. However, unlike video compression, it
> > > is more important to find true motion trajectories in MCFI. The objective
> > > of MC in MCFI is not to minimize the energy of MC residual signals, but
> > to
> > > reconstruct interpolated frames with better visual quality.
> > >
> > > The algorithm uses motion vectors which are embedded in bit-stream. If
> > > vectors exported by codec (using +export_mvs flag2) are used when
> > > available, computation of the motion vectors will be significantly
> > reduced
> > > for realtime playback. Otherwise the mEstimate filter will generate MVs,
> > > and to make the process faster, same algorithms (used by x264 and x265) -
> > > Diamond, Hex, UMH, Star will be implemented in the filter. Other filter -
> > > mInterpolate will use the MVs in the frame side data to interpolate
> > frames
> > > using various methods - OBMC (Overlapped block motion

Re: [FFmpeg-devel] PATCH: dshow: don't add two instances of same device to graphs

2016-06-17 Thread Roger Pack 
On 6/15/16, Clément Bœsch  wrote:
> On Wed, Jun 15, 2016 at 02:54:09AM -0600, Roger Pack wrote:
>> A handful of devices don't support this, and the rest work fine with it
>> :)
>>
>> -roger-
>
>> From e724d7f169bcae3217455cd88f9c023d275d367a Mon Sep 17 00:00:00 2001
>> From: rogerdpack 
>> Date: Wed, 15 Jun 2016 02:17:11 -0600
>> Subject: [PATCH] dshow: don't add two instances of same device to graphs
>>
>> Signed-off-by: rogerdpack 
>> ---
>>  libavdevice/dshow.c | 37 ++---
>>  libavdevice/dshow_capture.h |  2 ++
>>  2 files changed, 32 insertions(+), 7 deletions(-)
>>
>> diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
>> index 5f2cad7..e1ac855 100644
>> --- a/libavdevice/dshow.c
>> +++ b/libavdevice/dshow.c
>> @@ -108,6 +108,10 @@ dshow_read_close(AVFormatContext *s)
>>  av_freep(>device_name[0]);
>>  if (ctx->device_name[1])
>>  av_freep(>device_name[1]);
>
>> +if (ctx->device_unique_name[0])
>> +av_freep(>device_unique_name[0]);
>> +if (ctx->device_unique_name[1])
>> +av_freep(>device_unique_name[1]);
>
> I can't comment the rest of the patch, but please remove the ifs. They are,
> and always were, totally useless. Just like those above.

OK see also attached patch, to be applied after patch 1.
Thanks, will wait three days and if no objections, request these
patches be committed.
Cheers!
From 61e07cc85785345122832b1b5333412b5272c545 Mon Sep 17 00:00:00 2001
From: rogerdpack 
Date: Fri, 17 Jun 2016 14:04:34 -0600
Subject: [PATCH 2/2] dshow: avoid duplicate NULL check before free

Signed-off-by: rogerdpack 
---
 libavdevice/dshow.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
index e1ac855..127e4c2 100644
--- a/libavdevice/dshow.c
+++ b/libavdevice/dshow.c
@@ -104,14 +104,10 @@ dshow_read_close(AVFormatContext *s)
 if (ctx->device_filter[AudioDevice])
 IBaseFilter_Release(ctx->device_filter[AudioDevice]);
 
-if (ctx->device_name[0])
-av_freep(>device_name[0]);
-if (ctx->device_name[1])
-av_freep(>device_name[1]);
-if (ctx->device_unique_name[0])
-av_freep(>device_unique_name[0]);
-if (ctx->device_unique_name[1])
-av_freep(>device_unique_name[1]);
+av_freep(>device_name[0]);
+av_freep(>device_name[1]);
+av_freep(>device_unique_name[0]);
+av_freep(>device_unique_name[1]);
 
 if(ctx->mutex)
 CloseHandle(ctx->mutex);
-- 
2.8.3.windows.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: silence warning about deprecated coded_frame

2016-06-17 Thread James Almer 
On 6/17/2016 4:49 PM, Michael Niedermayer wrote:
> On Fri, Jun 17, 2016 at 01:49:06PM -0300, James Almer wrote:
>> Signed-off-by: James Almer 
>> ---
>>  libavcodec/ffv1enc.c | 4 
>>  1 file changed, 4 insertions(+)
> 
> LGTM
> 
> thx
> 

Pushed.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: silence warning about deprecated coded_frame

2016-06-17 Thread Michael Niedermayer 
On Fri, Jun 17, 2016 at 01:49:06PM -0300, James Almer wrote:
> Signed-off-by: James Almer 
> ---
>  libavcodec/ffv1enc.c | 4 
>  1 file changed, 4 insertions(+)

LGTM

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Loop option

2016-06-17 Thread Riko Ghanem 
Hi,

- Thank you very much for such a wonderful piece of art and knowlage. Is there 
any chance you can add a loop option to the the concat ''demuxer'' so if we 
have a playlist.txt with any amount file it can start over again when it done 
with them all? That would be so great and useful for many things. 
  
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Sponsoring feature for H.264 decoding with scaling factor (1/2, 1/4...) (if possible)

2016-06-17 Thread Eric Beuque 
2016-06-17 19:16 GMT+02:00 Michael Niedermayer :

> On Fri, Jun 17, 2016 at 05:39:23PM +0200, Eric Beuque wrote:
> > Hi,
> >
> > i'm posting here for a feature that is missing in ffmpeg (or may be i
> > missed something), which consist of decoding H.264 frame with a scaling
> > factor of 1/2, 1/4, 1/8...
> >
> > I found the parameter lowres, which works well with MJPEG stream but it's
> > not working with the H.264 decoder.
> >
> > I don't know if it's something possible to implement in the decoder, but
> if
> > yes, my compagny agreed to sponsor the feature (depending on the cost of
> > course), if a developer qualified is interested to do it.
> >
> > Is someone know if it is possible, and if it can exist someone interested
> > to develop this feature?
>
> is it acceptable if the encoder enforces some restrictions on the used
> features ?
>
> most general h264 likely cannot efficiently be decoded in lower
> resolution with acceptable quality
> Restricting the used intra modes may make it possible to do it though
> i dont know what the quality would be but better than without
> restrictions
>
> [...]
>


Actually, the main goal is for motion detection algorithm, so we need small
resolution and best quality is not required. We just need good estimation
for the moving pixel.

For now, we decode in H.264, and scale it close 320x240, the then we
perform motion detection on it. The goal is to speed up the process and
reduce the memory usage since decoding a 2048x1536 picture lead around a 5
MB for the decoded image in memory.

So i think it could be OK.



>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> In fact, the RIAA has been known to suggest that students drop out
> of college or go to community college in order to be able to afford
> settlements. -- The RIAA
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Sponsoring feature for H.264 decoding with scaling factor (1/2, 1/4...) (if possible)

2016-06-17 Thread Michael Niedermayer 
On Fri, Jun 17, 2016 at 05:39:23PM +0200, Eric Beuque wrote:
> Hi,
> 
> i'm posting here for a feature that is missing in ffmpeg (or may be i
> missed something), which consist of decoding H.264 frame with a scaling
> factor of 1/2, 1/4, 1/8...
> 
> I found the parameter lowres, which works well with MJPEG stream but it's
> not working with the H.264 decoder.
> 
> I don't know if it's something possible to implement in the decoder, but if
> yes, my compagny agreed to sponsor the feature (depending on the cost of
> course), if a developer qualified is interested to do it.
> 
> Is someone know if it is possible, and if it can exist someone interested
> to develop this feature?

is it acceptable if the encoder enforces some restrictions on the used
features ?

most general h264 likely cannot efficiently be decoded in lower
resolution with acceptable quality
Restricting the used intra modes may make it possible to do it though
i dont know what the quality would be but better than without
restrictions

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v7] Add experimental support for vp9 in iso-bmff

2016-06-17 Thread KongQun Yang 
-- KongQun Yang (KQ)

On Fri, Jun 17, 2016 at 7:37 AM, Ronald S. Bultje 
wrote:

> Hi,
>
> On Thu, Jun 16, 2016 at 9:06 AM, Ronald S. Bultje 
> wrote:
>
>> Hi,
>>
>> On Wed, Jun 15, 2016 at 7:22 PM, KongQun Yang  wrote:
>>
>>>
>>>
>>> -- KongQun Yang (KQ)
>>>
>>> On Wed, Jun 15, 2016 at 3:08 PM, Ronald S. Bultje 
>>> wrote:
>>>
 Hi,

 On Wed, Jun 15, 2016 at 4:53 PM, Kongqun Yang 
 wrote:

> Implemented according to the draft specification
> "VP Codec ISO Media File Format Binding":
>
> http://www.webmproject.org/vp9/#draft-vp-codec-iso-media-file-format-binding
>
> '-strict -2' is required to use this feature.
>
> Change-Id: Iaa7ddf5524b17e8d79cd1923b26f096d6e91
> ---
>  libavformat/Makefile |   2 +-
>  libavformat/isom.c   |   3 ++
>  libavformat/movenc.c |  26 +
>  libavformat/vpcc.c   | 148
> +++
>  libavformat/vpcc.h   |  47 
>  5 files changed, 225 insertions(+), 1 deletion(-)
>  create mode 100644 libavformat/vpcc.c
>  create mode 100644 libavformat/vpcc.h


 No further comments from me, LGTM but I'd wait a day before push to
 give others a day to re-review also.

>>>
>>> Sure, thanks for reviewing and all the helpful comments! Btw, are you
>>> going to help commit the change?
>>>
>>
>> Yes. (Poke me if I haven't by tomorrow.)
>>
>
> Pushed.
>

Cool. Thanks!

>
> Ronald
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/ffv1enc: silence warning about deprecated coded_frame

2016-06-17 Thread James Almer 
Signed-off-by: James Almer 
---
 libavcodec/ffv1enc.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
index 9ee9921..f2434e6 100644
--- a/libavcodec/ffv1enc.c
+++ b/libavcodec/ffv1enc.c
@@ -1289,7 +1289,11 @@ static int encode_frame(AVCodecContext *avctx, AVPacket 
*pkt,
 av_frame_unref(p);
 if ((ret = av_frame_ref(p, pict)) < 0)
 return ret;
+#if FF_API_CODED_FRAME
+FF_DISABLE_DEPRECATION_WARNINGS
 avctx->coded_frame->pict_type = AV_PICTURE_TYPE_I;
+FF_ENABLE_DEPRECATION_WARNINGS
+#endif
 
 if (avctx->gop_size == 0 || f->picture_number % avctx->gop_size == 0) {
 put_rac(c, , 1);
-- 
2.8.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] two small untested VT patches

2016-06-17 Thread Clément Bœsch 
On Fri, Jun 17, 2016 at 10:49:32AM -0400, Richard Kern wrote:
> 
> > On Jun 17, 2016, at 10:10 AM, Clément Bœsch  wrote:
> > 
> > $subj
> > 
> > (sorry no mac available right now)
> 
> OS X works fine. I can test iOS later today if you like, but it’s small. LGTM.
> 

Applied, thanks

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fate/h264: add test for ticket #631

2016-06-17 Thread Clément Bœsch 
On Fri, Jun 17, 2016 at 02:38:14PM +0200, Clément Bœsch wrote:
> From: Clément Bœsch 
> 
> ---
>  tests/fate/h264.mak|  2 ++
>  tests/ref/fate/h264-attachment-631 | 20 
>  2 files changed, 22 insertions(+)
>  create mode 100644 tests/ref/fate/h264-attachment-631
> 

17:56  ubitux, about 631, i dont see a better solution, so its ok

applied

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Sponsoring feature for H.264 decoding with scaling factor (1/2, 1/4...) (if possible)

2016-06-17 Thread Eric Beuque 
Hi,

i'm posting here for a feature that is missing in ffmpeg (or may be i
missed something), which consist of decoding H.264 frame with a scaling
factor of 1/2, 1/4, 1/8...

I found the parameter lowres, which works well with MJPEG stream but it's
not working with the H.264 decoder.

I don't know if it's something possible to implement in the decoder, but if
yes, my compagny agreed to sponsor the feature (depending on the cost of
course), if a developer qualified is interested to do it.

Is someone know if it is possible, and if it can exist someone interested
to develop this feature?

In advance thank you very much,

Regards,

Eric Beuque
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/videotoolbox: fix H.264 hwaccel init issue

2016-06-17 Thread Richard Kern 

> On Jun 17, 2016, at 10:36 AM, Clément Bœsch  wrote:
> 
> On Fri, Jun 17, 2016 at 09:43:09AM -0400, Richard Kern wrote:
>> Since ca2f19b9cc (h264: switch to h2645_parse for NAL parsing) the hwaccel 
>> wouldn’t init (when the first h.264 frame is decoded). It was the same on OS 
>> X and iOS - creating the decoder would return a “decoder malfunction” error. 
>> Apple’s suggested way to create the decoder config for h.264 decoders is 
>> CMVideoFormatDescriptionCreateFromH264ParameterSets(), and switching to this 
>> function solved the issue on OS X and iOS. A user on IRC confirmed it worked 
>> for them too.
>> 
> 
> So avc_info constructed from extradata in decoder_config_create() wasn't
> enough? (Any idea why?)

I don’t know why. Unfortunately there isn’t much documentation, and the error 
message is vague.

> 
> "the hwaccel wouldn't init", why? Is it because the SPS/PPS NALs were
> somehow split out of the packets since ca2f19b9cc and thus VT never got
> them, or I misunderstand?

The same SPS and PPS from the H264Context are being used to create the avcC 
atom as are passed to CMVideoFormatDescriptionCreateFromH264ParameterSets()… 
I’ll need to do some digging in the commit that broke it this weekend.

> 
> -- 
> Clément B.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] two small untested VT patches

2016-06-17 Thread Richard Kern 

> On Jun 17, 2016, at 10:10 AM, Clément Bœsch  wrote:
> 
> $subj
> 
> (sorry no mac available right now)

OS X works fine. I can test iOS later today if you like, but it’s small. LGTM.

> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/videotoolbox: fix H.264 hwaccel init issue

2016-06-17 Thread Clément Bœsch 
On Fri, Jun 17, 2016 at 09:43:09AM -0400, Richard Kern wrote:
> Since ca2f19b9cc (h264: switch to h2645_parse for NAL parsing) the hwaccel 
> wouldn’t init (when the first h.264 frame is decoded). It was the same on OS 
> X and iOS - creating the decoder would return a “decoder malfunction” error. 
> Apple’s suggested way to create the decoder config for h.264 decoders is 
> CMVideoFormatDescriptionCreateFromH264ParameterSets(), and switching to this 
> function solved the issue on OS X and iOS. A user on IRC confirmed it worked 
> for them too.
> 

So avc_info constructed from extradata in decoder_config_create() wasn't
enough? (Any idea why?)

"the hwaccel wouldn't init", why? Is it because the SPS/PPS NALs were
somehow split out of the packets since ca2f19b9cc and thus VT never got
them, or I misunderstand?

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v7] Add experimental support for vp9 in iso-bmff

2016-06-17 Thread Ronald S. Bultje 
Hi,

On Thu, Jun 16, 2016 at 9:06 AM, Ronald S. Bultje 
wrote:

> Hi,
>
> On Wed, Jun 15, 2016 at 7:22 PM, KongQun Yang  wrote:
>
>>
>>
>> -- KongQun Yang (KQ)
>>
>> On Wed, Jun 15, 2016 at 3:08 PM, Ronald S. Bultje 
>> wrote:
>>
>>> Hi,
>>>
>>> On Wed, Jun 15, 2016 at 4:53 PM, Kongqun Yang 
>>> wrote:
>>>
 Implemented according to the draft specification
 "VP Codec ISO Media File Format Binding":

 http://www.webmproject.org/vp9/#draft-vp-codec-iso-media-file-format-binding

 '-strict -2' is required to use this feature.

 Change-Id: Iaa7ddf5524b17e8d79cd1923b26f096d6e91
 ---
  libavformat/Makefile |   2 +-
  libavformat/isom.c   |   3 ++
  libavformat/movenc.c |  26 +
  libavformat/vpcc.c   | 148
 +++
  libavformat/vpcc.h   |  47 
  5 files changed, 225 insertions(+), 1 deletion(-)
  create mode 100644 libavformat/vpcc.c
  create mode 100644 libavformat/vpcc.h
>>>
>>>
>>> No further comments from me, LGTM but I'd wait a day before push to give
>>> others a day to re-review also.
>>>
>>
>> Sure, thanks for reviewing and all the helpful comments! Btw, are you
>> going to help commit the change?
>>
>
> Yes. (Poke me if I haven't by tomorrow.)
>

Pushed.

Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] lavc/videotoolbox: CFRelease() session

2016-06-17 Thread Clément Bœsch 
From: Clément Bœsch 

"When you are done with a decompression session you created, call
VTDecompressionSessionInvalidate to tear it down and then CFRelease to
release your object reference."
---
 libavcodec/videotoolbox.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
index 384bb8a..7f72612 100644
--- a/libavcodec/videotoolbox.c
+++ b/libavcodec/videotoolbox.c
@@ -628,8 +628,10 @@ static void videotoolbox_default_free(AVCodecContext 
*avctx)
 if (videotoolbox->cm_fmt_desc)
 CFRelease(videotoolbox->cm_fmt_desc);
 
-if (videotoolbox->session)
+if (videotoolbox->session) {
 VTDecompressionSessionInvalidate(videotoolbox->session);
+CFRelease(videotoolbox->session);
+}
 }
 }
 
-- 
2.8.3

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/videotoolbox: fix H.264 hwaccel init issue

2016-06-17 Thread Richard Kern 

> On Jun 17, 2016, at 5:31 AM, Clément Bœsch  wrote:
> 
> On Fri, Jun 17, 2016 at 03:24:10AM +0200, Rick Kern wrote:
>> ffmpeg | branch: master | Rick Kern  | Wed Jun  1 21:40:22 
>> 2016 -0400| [8e47a99f576da10b2a36e33b6b9acbf1c2da7485] | committer: Rick Kern
>> 
>> lavc/videotoolbox: fix H.264 hwaccel init issue
>> 
>> Fixes VTDecompressionSessionCreate() error.
>> 
> 
> Please reference the closing Ticket next time, and mention that it's a
> regression.

ok

> 
> Also, can you elaborate on why this fix is required? What was wrong
> exactly previously, and why was it working?
> 
> It feels like it's including more than a fix.

Since ca2f19b9cc (h264: switch to h2645_parse for NAL parsing) the hwaccel 
wouldn’t init (when the first h.264 frame is decoded). It was the same on OS X 
and iOS - creating the decoder would return a “decoder malfunction” error. 
Apple’s suggested way to create the decoder config for h.264 decoders is 
CMVideoFormatDescriptionCreateFromH264ParameterSets(), and switching to this 
function solved the issue on OS X and iOS. A user on IRC confirmed it worked 
for them too.

> 
> (BTW, do you happen to be on IRC?)

Yeah, I’m rkern. I’m in the eastern US time zone and sign in to both #ffmpeg 
and #ffmpeg-devel.

> 
> Regards,
> 
> -- 
> Clément B.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] fate/h264: add test for ticket #631

2016-06-17 Thread Clément Bœsch 
From: Clément Bœsch 

---
 tests/fate/h264.mak|  2 ++
 tests/ref/fate/h264-attachment-631 | 20 
 2 files changed, 22 insertions(+)
 create mode 100644 tests/ref/fate/h264-attachment-631

diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak
index e12263c..4ae1305 100644
--- a/tests/fate/h264.mak
+++ b/tests/fate/h264.mak
@@ -208,6 +208,7 @@ FATE_H264-$(call ALLYES, MOV_DEMUXER H264_MP4TOANNEXB_BSF) 
+= fate-h264-bsf-mp4t
 FATE_H264-$(call DEMDEC, MATROSKA, H264) += fate-h264-direct-bff
 FATE_H264-$(call DEMDEC, FLV, H264) += fate-h264-brokensps-2580
 FATE_H264-$(call DEMDEC, MXF, H264) += fate-h264-xavc-4389
+FATE_H264-$(call DEMDEC, MOV, H264) += fate-h264-attachment-631
 FATE_H264_FFPROBE-$(call DEMDEC, MATROSKA, H264) += fate-h264-dts_5frames
 
 FATE_SAMPLES_AVCONV += $(FATE_H264-yes)
@@ -410,6 +411,7 @@ fate-h264-lossless:   CMD = 
framecrc -i $(TARGET_SAM
 fate-h264-direct-bff: CMD = framecrc -i 
$(TARGET_SAMPLES)/h264/direct-bff.mkv
 fate-h264-brokensps-2580: CMD = framecrc -i 
$(TARGET_SAMPLES)/h264/brokensps.flv -vf format=yuv420p,scale=w=192:h=144 
-sws_flags bitexact+bilinear
 fate-h264-xavc-4389:  CMD = framecrc -i 
$(TARGET_SAMPLES)/h264/SonyXAVC_LongGOP_green_pixelation_early_Frames.MXF 
-pix_fmt yuv422p10le
+fate-h264-attachment-631: CMD = framecrc -i 
$(TARGET_SAMPLES)/h264/attachment631-small.mp4 -an -max_error_rate 0.95
 fate-h264-invalid-ref-mod:CMD = framecrc -i 
$(TARGET_SAMPLES)/h264/h264refframeregression.mp4 -an -frames 10 -pix_fmt 
yuv420p10le
 fate-h264-unescaped-extradata:CMD = framecrc -i 
$(TARGET_SAMPLES)/h264/unescaped_extradata.mp4 -an -frames 10
 
diff --git a/tests/ref/fate/h264-attachment-631 
b/tests/ref/fate/h264-attachment-631
new file mode 100644
index 000..ebb5eb4
--- /dev/null
+++ b/tests/ref/fate/h264-attachment-631
@@ -0,0 +1,20 @@
+#tb 0: 1/60
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 720x480
+#sar 0: 8/9
+0,598,598,1,   518400, 0xc3c0f1cf
+0,603,603,1,   518400, 0x21a5df80
+0,607,607,1,   518400, 0x5b8e115b
+0,611,611,1,   518400, 0x7ce09331
+0,615,615,1,   518400, 0x30ff1f1f
+0,619,619,1,   518400, 0x64f091ed
+0,623,623,1,   518400, 0xb3c117a2
+0,627,627,1,   518400, 0x0fbe146d
+0,631,631,1,   518400, 0x75209293
+0,635,635,1,   518400, 0xa3030208
+0,639,639,1,   518400, 0x8cea6941
+0,643,643,1,   518400, 0xf41d1dbd
+0,647,647,1,   518400, 0xcc9fe95e
+0,651,651,1,   518400, 0xa2a60dbc
+0,655,655,1,   518400, 0x3f5eecdb
-- 
2.8.3

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/videotoolbox: fix H.264 hwaccel init issue

2016-06-17 Thread Clément Bœsch 
On Fri, Jun 17, 2016 at 03:24:10AM +0200, Rick Kern wrote:
> ffmpeg | branch: master | Rick Kern  | Wed Jun  1 21:40:22 
> 2016 -0400| [8e47a99f576da10b2a36e33b6b9acbf1c2da7485] | committer: Rick Kern
> 
> lavc/videotoolbox: fix H.264 hwaccel init issue
> 
> Fixes VTDecompressionSessionCreate() error.
> 

Please reference the closing Ticket next time, and mention that it's a
regression.

Also, can you elaborate on why this fix is required? What was wrong
exactly previously, and why was it working?

It feels like it's including more than a fix.

(BTW, do you happen to be on IRC?)

Regards,

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] swresample: fix phase_count calculation

2016-06-17 Thread Muhammad Faiz 
On Fri, Jun 17, 2016 at 2:23 PM, Michael Niedermayer
 wrote:
> On Fri, Jun 17, 2016 at 05:48:55AM +0700, Muhammad Faiz wrote:
>> On Thu, Jun 16, 2016 at 10:03 PM, Michael Niedermayer
>>  wrote:
>> > On Thu, Jun 16, 2016 at 12:31:03AM +0700, Muhammad Faiz wrote:
>> >> support odd phase_count
>> >> stick to low phase_count until set_compensation is called
>> >
>> > can you split these in 2 seperate patches ?
>> >
>> >
>> > [...]
>> >> @@ -382,6 +382,9 @@ static ResampleContext *resample_init(ResampleContext 
>> >> *c, int out_rate, int in_r
>> >>  c->index= -phase_count*((c->filter_length-1)/2);
>> >>  c->frac= 0;
>> >>
>> >> +/*av_log(NULL, AV_LOG_ERROR, "phase_count = %d, dst_incr = %d (%d + 
>> >> %d/%d)\n",
>> >> +   c->phase_count, c->dst_incr, c->dst_incr_div, 
>> >> c->dst_incr_mod, c->src_incr);*/
>> >> +
>> >>  swri_resample_dsp_init(c);
>> >>
>> >>  return c;
>> > [...]
>> >> +/*av_log(NULL, AV_LOG_ERROR, "phase_count = %d, dst_incr = %d (%d + 
>> >> %d/%d)\n",
>> >> +   c->phase_count, c->dst_incr, c->dst_incr_div, 
>> >> c->dst_incr_mod, c->src_incr);*/
>> >
>> > these disabled debug av_log() should probably not be pushed
>> >
>>
>> OK, patches attached
>>
>> Thank's
>
>>  resample.c |   17 -
>>  1 file changed, 8 insertions(+), 9 deletions(-)
>> 23ee69b87f2a83e8d8d394eabba6cf727940127b  
>> 0001-swresample-resample-add-support-for-odd-phase_count.patch
>> From 8cb201c678337dbf7c73545919e183f24ada2269 Mon Sep 17 00:00:00 2001
>> From: Muhammad Faiz 
>> Date: Fri, 17 Jun 2016 05:30:37 +0700
>> Subject: [PATCH 1/2] swresample/resample: add support for odd phase_count
>>
>> because exact_rational does not guarantee
>> that phase_count is even
>>
>> Signed-off-by: Muhammad Faiz 
>
> LGTM
>
applied

> [...]
>
>> diff --git a/libswresample/resample.h b/libswresample/resample.h
>> index 53788c4..2c29959 100644
>> --- a/libswresample/resample.h
>> +++ b/libswresample/resample.h
>> @@ -51,6 +51,7 @@ typedef struct ResampleContext {
>>  enum AVSampleFormat format;
>>  int felem_size;
>>  int filter_shift;
>
>> +int phase_count_comp;
>
> comp makes me think of computation before compensation, please
> use a different name and document the field
>
> should be ok otherwise
>
> thanks
>
renamed to phase_count_compensation
and applied

thanks
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [GSoC] Motion Interpolation

2016-06-17 Thread Davinder Singh 
On Wed, Jun 15, 2016 at 5:04 PM Michael Niedermayer 
wrote:

> Hi
>
> On Tue, May 31, 2016 at 10:43:38PM +, Davinder Singh wrote:
> > There’s a lot of research done on Motion Estimation. Depending upon the
> > intended application of the resultant motion vectors, the method used for
> > motion estimation can be very different.
> >
> > Classification of Motion Estimation Methods:
> >
> > Direct Methods: In direct methods we calculate optical flow
> >  in the scene.
> >
> > - Phase Correlation
> >
> > - Block Matching
> >
> > - Spatio-Temporal Gradient
> >
> >  - Optical flow: Uses optical flow equation to find motion in the scene.
> >
> >  - Pel-recursive: Also compute optical flow, but in such a way that allow
> > recursive computability on vector fields)
> >
> > Indirect Methods
> >
> > - Feature based Method: Find features in the frame, and used for
> estimation.
> >
> > Here are some papers on Frame Rate Up-Conversion (FRUC):
> >
> > Phase Correlation:
> >
> > This method relies on frequency-domain representation of data, calculated
> > using fast Fourier transform.
> >  Phase Correlation
> > provides a correlation surface from the comparison of images. This
> enables
> > the identification of motion on a pixel-by-pixel basis for correct
> > processing of each motion type. Since phase correlation operates in the
> > frequency rather than the spatial domain, it is able to zero in on
> details
> > while ignoring such factors as noise and grain within the picture. In
> other
> > words, the system is highly tolerant of the noise variations and rapid
> > changes in luminance levels that are found in many types of content –
> > resulting in high-quality performance on fades, objects moving in and out
> > of shade, and light ashes.
> >
> > Papers:
> >
> > [1] "Disney Research » Phase-Based Frame Interpolation for Video." IEEE
> > CVPR 2015 
> >
> > [2] Yoo, DongGon et al. "Phase Correlated Bilateral Motion Estimation for
> > Frame Rate Up-Conversion." The 23rd International Technical Conference on
> > Circuits/Systems, Computers and Communications (ITC-CSCC Jul. 2008.
> >
> > 
> >
> > The video on paper [1] page demonstrate comparison between various
> methods.
> >
> > Optical Flow:
> >
> > http://www.cs.toronto.edu/~fleet/research/Papers/flowChapter05.pdf
> >
> > [3] Brox et al. "High accuracy optical flow estimation based on a theory
> > for warping." Computer Vision - ECCV 2004: 25-36.
> >
> > <
> >
> http://www.wisdom.weizmann.ac.il/~/vision/courses/2006_2/papers/optic_flow_multigrid/brox_eccv04_of.pdf
> > >
> >
> > Slowmovideo  open-source project is
> based
> > on Optical flow equation.
> >
> > Algorithm we can implement is based on block matching method.
> >
> > Motion Compensated Frame Interpolation
> >
> > Paper:
> >
> > [4] Zhai et al. "A low complexity motion compensated frame interpolation
> > method." IEEE ISCAS 2005: 4927-4930.
> >
> > 
> >
> > Block-based motion estimation and pixel-wise motion estimation are the
> two
> > main categories of motion estimation methods. In general, pixel-wise
> motion
> > estimation can attain accurate motion fields, but needs a substantial
> > amount of computation. In contrast, block matching algorithms (BMA) can
> be
> > efficiently implemented and provide good performance.
> >
> > Most MCFI algorithms utilize the block-matching algorithm (BMA) for
> motion
> > estimation (ME). BMA is simple and easy to implement. It also generates a
> > compactly represented motion field. However, unlike video compression, it
> > is more important to find true motion trajectories in MCFI. The objective
> > of MC in MCFI is not to minimize the energy of MC residual signals, but
> to
> > reconstruct interpolated frames with better visual quality.
> >
> > The algorithm uses motion vectors which are embedded in bit-stream. If
> > vectors exported by codec (using +export_mvs flag2) are used when
> > available, computation of the motion vectors will be significantly
> reduced
> > for realtime playback. Otherwise the mEstimate filter will generate MVs,
> > and to make the process faster, same algorithms (used by x264 and x265) -
> > Diamond, Hex, UMH, Star will be implemented in the filter. Other filter -
> > mInterpolate will use the MVs in the frame side data to interpolate
> frames
> > using various methods - OBMC (Overlapped block motion compensation),
> simple
> > frame blending and frame duplication etc.
> >
> > However, MVs generated based on SAD or BAD might bring serious artifacts
> if
> > they are used directly. So, the algorithm first examines the motion
> vectors
> > and classify into two groups, one group with vectors which are

[FFmpeg-devel] [PATCH] lavc/mediacodecdec{, _h264}: set FF_CODEC_CAP_SETS_PKT_DTS capability

2016-06-17 Thread Matthieu Bouron 
From: Matthieu Bouron 

And sets frames pkt_dts to AV_NOPTS_VALUE as we do not want lavc/utils
to overwrite the field with incorrect values as the decoder is
asynchronous.
---
 libavcodec/mediacodecdec.c  | 1 +
 libavcodec/mediacodecdec_h264.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c
index 0b08f020..68df885 100644
--- a/libavcodec/mediacodecdec.c
+++ b/libavcodec/mediacodecdec.c
@@ -162,6 +162,7 @@ static int mediacodec_wrap_buffer(AVCodecContext *avctx,
  *   * N avpackets can be pushed before 1 frame is actually returned
  *   * 0-sized avpackets are pushed to flush remaining frames at EOS */
 frame->pkt_pts = info->presentationTimeUs;
+frame->pkt_dts = AV_NOPTS_VALUE;
 
 av_log(avctx, AV_LOG_DEBUG,
 "Frame: width=%d stride=%d height=%d slice-height=%d "
diff --git a/libavcodec/mediacodecdec_h264.c b/libavcodec/mediacodecdec_h264.c
index 52e48ae..0f90606 100644
--- a/libavcodec/mediacodecdec_h264.c
+++ b/libavcodec/mediacodecdec_h264.c
@@ -344,4 +344,5 @@ AVCodec ff_h264_mediacodec_decoder = {
 .flush  = mediacodec_decode_flush,
 .close  = mediacodec_decode_close,
 .capabilities   = CODEC_CAP_DELAY,
+.caps_internal  = FF_CODEC_CAP_SETS_PKT_DTS,
 };
-- 
2.8.3

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] swresample: fix phase_count calculation

2016-06-17 Thread Michael Niedermayer 
On Fri, Jun 17, 2016 at 05:48:55AM +0700, Muhammad Faiz wrote:
> On Thu, Jun 16, 2016 at 10:03 PM, Michael Niedermayer
>  wrote:
> > On Thu, Jun 16, 2016 at 12:31:03AM +0700, Muhammad Faiz wrote:
> >> support odd phase_count
> >> stick to low phase_count until set_compensation is called
> >
> > can you split these in 2 seperate patches ?
> >
> >
> > [...]
> >> @@ -382,6 +382,9 @@ static ResampleContext *resample_init(ResampleContext 
> >> *c, int out_rate, int in_r
> >>  c->index= -phase_count*((c->filter_length-1)/2);
> >>  c->frac= 0;
> >>
> >> +/*av_log(NULL, AV_LOG_ERROR, "phase_count = %d, dst_incr = %d (%d + 
> >> %d/%d)\n",
> >> +   c->phase_count, c->dst_incr, c->dst_incr_div, c->dst_incr_mod, 
> >> c->src_incr);*/
> >> +
> >>  swri_resample_dsp_init(c);
> >>
> >>  return c;
> > [...]
> >> +/*av_log(NULL, AV_LOG_ERROR, "phase_count = %d, dst_incr = %d (%d + 
> >> %d/%d)\n",
> >> +   c->phase_count, c->dst_incr, c->dst_incr_div, c->dst_incr_mod, 
> >> c->src_incr);*/
> >
> > these disabled debug av_log() should probably not be pushed
> >
> 
> OK, patches attached
> 
> Thank's

>  resample.c |   17 -
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 23ee69b87f2a83e8d8d394eabba6cf727940127b  
> 0001-swresample-resample-add-support-for-odd-phase_count.patch
> From 8cb201c678337dbf7c73545919e183f24ada2269 Mon Sep 17 00:00:00 2001
> From: Muhammad Faiz 
> Date: Fri, 17 Jun 2016 05:30:37 +0700
> Subject: [PATCH 1/2] swresample/resample: add support for odd phase_count
> 
> because exact_rational does not guarantee
> that phase_count is even
> 
> Signed-off-by: Muhammad Faiz 

LGTM

[...]

> diff --git a/libswresample/resample.h b/libswresample/resample.h
> index 53788c4..2c29959 100644
> --- a/libswresample/resample.h
> +++ b/libswresample/resample.h
> @@ -51,6 +51,7 @@ typedef struct ResampleContext {
>  enum AVSampleFormat format;
>  int felem_size;
>  int filter_shift;

> +int phase_count_comp;

comp makes me think of computation before compensation, please
use a different name and document the field

should be ok otherwise

thanks

[...]


-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] d3d11va: don't keep the context lock while waiting for a frame

2016-06-17 Thread Michael Niedermayer 
On Wed, Jun 15, 2016 at 09:24:29AM +0200, Steve Lhomme wrote:
> also fixes a deadlock found by Денис Кулаков 
> ---
>  libavcodec/dxva2.c | 12 +---
>  1 file changed, 9 insertions(+), 3 deletions(-)

applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel